Stop spinner before calling logger in optimize

jdalton · jdalton · commit 77d4116b0d22 · 2025-04-21T10:31:03.000-06:00
diff --git a/src/commands/optimize/update-lockfile.ts b/src/commands/optimize/update-lockfile.ts
@@ -35,6 +35,7 @@ export async function updateLockfile(
   try {
     await runAgentInstall(pkgEnvDetails, { spinner })
     if (pkgEnvDetails.features.npmBuggyOverrides) {
+      spinner?.stop()
       logger?.log(
         `💡 Re-run ${cmdName ? `${cmdName} ` : ''}whenever ${pkgEnvDetails.lockName} changes.\n   This can be skipped for ${pkgEnvDetails.agent} >=${NPM_BUGGY_OVERRIDES_PATCHED_VERSION}.`
       )

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,7 @@ export async function updateLockfile(`
`35`	`35`	`try {`
`36`	`36`	`await runAgentInstall(pkgEnvDetails, { spinner })`
`37`	`37`	`if (pkgEnvDetails.features.npmBuggyOverrides) {`
	`38`	`+ spinner?.stop()`
`38`	`39`	`logger?.log(`
`39`	`40`	`💡 Re-run ${cmdName ? `${cmdName} ` : ''}whenever ${pkgEnvDetails.lockName} changes.\n This can be skipped for ${pkgEnvDetails.agent} >=${NPM_BUGGY_OVERRIDES_PATCHED_VERSION}.`
`40`	`41`	`)`