Skip to content

Commit 80d6a20

Browse files
committed
fix(build): skip onnxruntime build (temporarily disabled)
ONNX Runtime WASM build is temporarily disabled in CI workflow due to build issues. Update root build script to skip it and prevent provenance workflow from failing when onnxruntime is missing. Changes: - Comment out onnxruntime from BUILD_PACKAGES array - Update build order documentation (3 packages instead of 4) - Update help text to note onnxruntime is disabled - Update README.md and docs/build/README.md - Add note that AI features use pre-built assets Benefits: - Provenance workflow won't fail looking for onnxruntime WASM - Build time reduced (one fewer package to check) - Clear communication that onnxruntime is temporarily disabled - Easy to re-enable when build issues are resolved Related: .github/workflows/build-wasm.yml lines 244-359
1 parent b3f9ab2 commit 80d6a20

File tree

3 files changed

+25
-24
lines changed

3 files changed

+25
-24
lines changed

README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -114,10 +114,11 @@ pnpm exec socket --version
114114

115115
Socket CLI uses an **intelligent build system with automatic caching** that only rebuilds packages when their source files change. The build system ensures packages are built in the correct dependency order:
116116

117-
1. **ONNX Runtime WASM** - AI features (text classification, issue detection)
118-
2. **Yoga WASM** - Terminal layout engine (tables, progress bars)
119-
3. **CLI Package** - TypeScript compilation and bundling
120-
4. **SEA Binary** - Node.js Single Executable Application
117+
1. **Yoga WASM** - Terminal layout engine (tables, progress bars)
118+
2. **CLI Package** - TypeScript compilation and bundling
119+
3. **SEA Binary** - Node.js Single Executable Application
120+
121+
> **Note**: ONNX Runtime WASM is temporarily disabled due to build issues. AI features use pre-built assets.
121122
122123
#### Quick start (easiest)
123124

@@ -129,7 +130,7 @@ pnpm run build
129130
```
130131

131132
**How it works:**
132-
- Checks if output files exist (e.g., `packages/onnxruntime/dist/ort-wasm-simd.wasm`)
133+
- Checks if output files exist (e.g., `packages/yoga/dist/yoga.wasm`)
133134
- Skips building if output is present and up-to-date
134135
- Shows which packages were built vs. skipped
135136
- Displays build time summary
@@ -140,7 +141,6 @@ pnpm run build
140141
Socket CLI Build System
141142
============================================================
142143
143-
→ ONNX Runtime WASM: skipped (up to date)
144144
→ Yoga WASM: skipped (up to date)
145145
→ CLI Package: building...
146146
✓ CLI Package: built (12.3s)
@@ -152,7 +152,7 @@ Build Summary
152152
============================================================
153153
154154
Built: 2
155-
Skipped: 2
155+
Skipped: 1
156156
Total: 57.4s
157157
158158
✓ Build completed successfully

docs/build/README.md

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,22 +24,20 @@ pnpm dev
2424

2525
The Socket CLI build system builds packages in this order:
2626

27-
1. **ONNX Runtime WASM** (`@socketsecurity/onnxruntime`)
28-
- AI model execution runtime
29-
- Output: `packages/onnxruntime/dist/ort-wasm-simd.wasm`
30-
31-
2. **Yoga WASM** (`@socketsecurity/yoga`)
27+
1. **Yoga WASM** (`@socketsecurity/yoga`)
3228
- Terminal layout engine
3329
- Output: `packages/yoga/dist/yoga.wasm`
3430

35-
3. **CLI Package** (`@socketsecurity/cli`)
31+
2. **CLI Package** (`@socketsecurity/cli`)
3632
- Main CLI application
3733
- Output: `packages/cli/dist/index.js`
3834

39-
4. **SEA Binary** (`@socketbin/node-sea-builder-builder`)
35+
3. **SEA Binary** (`@socketbin/node-sea-builder-builder`)
4036
- Single Executable Application (Node.js + CLI bundled)
4137
- Output: `packages/socketbin-node-sea-builder-builder/bin/socket`
4238

39+
> **Note**: ONNX Runtime WASM (`@socketsecurity/onnxruntime`) is temporarily disabled due to build issues. AI features use pre-built assets.
40+
4341
## Build Commands
4442

4543
### Root Level Commands

scripts/build.mjs

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* Comprehensive build script with intelligent caching.
55
*
66
* Builds packages in the correct order:
7-
* 1. WASM packages (onnxruntime, yoga)
7+
* 1. WASM packages (yoga) - onnxruntime temporarily disabled
88
* 2. CLI package
99
* 3. SEA binary
1010
*
@@ -66,11 +66,13 @@ const PLATFORM_TARGETS = [
6666
* Build configuration for each package in the default build order.
6767
*/
6868
const BUILD_PACKAGES = [
69-
{
70-
name: 'ONNX Runtime WASM',
71-
filter: '@socketsecurity/onnxruntime',
72-
outputCheck: 'packages/onnxruntime/dist/ort-wasm-simd.wasm',
73-
},
69+
// TEMPORARILY DISABLED: ONNX Runtime build issues (see build-wasm.yml).
70+
// Re-enable once build script is working correctly.
71+
// {
72+
// name: 'ONNX Runtime WASM',
73+
// filter: '@socketsecurity/onnxruntime',
74+
// outputCheck: 'packages/onnxruntime/dist/ort-wasm-simd.wasm',
75+
// },
7476
{
7577
name: 'Yoga WASM',
7678
filter: '@socketsecurity/yoga',
@@ -156,10 +158,11 @@ function showHelp() {
156158
logger.log(' pnpm run build --help # Show this help')
157159
logger.log('')
158160
logger.log('Default Build Order:')
159-
logger.log(' 1. ONNX Runtime WASM (AI features)')
160-
logger.log(' 2. Yoga WASM (terminal layouts)')
161-
logger.log(' 3. CLI Package (TypeScript compilation + bundling)')
162-
logger.log(' 4. SEA Binary (Node.js Single Executable)')
161+
logger.log(' 1. Yoga WASM (terminal layouts)')
162+
logger.log(' 2. CLI Package (TypeScript compilation + bundling)')
163+
logger.log(' 3. SEA Binary (Node.js Single Executable)')
164+
logger.log('')
165+
logger.log('Note: ONNX Runtime WASM temporarily disabled (build issues)')
163166
logger.log('')
164167
logger.log('Platform Targets:')
165168
for (const target of PLATFORM_TARGETS) {

0 commit comments

Comments
 (0)