fix(build): address PR review feedback

- runBuild() rethrows after catching so Promise.allSettled can detect rejections
- download-assets: handle rejected promises in allSettled, not just ok:false
- esbuild.cli.mjs: fix plugin order so envVarReplacement runs after unicode transform
- build.mjs: fix watch mode error message to use fallback exit code 1
- package.json: fix e2e:sea indentation

Author: jdalton

packages/cli/.config/esbuild.cli.mjs

@@ -82,9 +82,9 @@ const config = {
   },
 
   plugins: [
+    unicodeTransformPlugin(),
     // Environment variable replacement must run AFTER unicode transform.
     envVarReplacementPlugin(inlinedEnvVars),
-    unicodeTransformPlugin(),
     {
       name: 'resolve-socket-lib-internals',
       setup(build) {

packages/cli/package.json

@@ -50,7 +50,7 @@
     "dev:npx": "cross-env SOCKET_CLI_MODE=npx node --experimental-strip-types src/cli-dispatch.mts",
     "e2e-tests": "dotenvx -q run -f .env.test -- vitest run --config vitest.e2e.config.mts",
     "e2e:js": "node scripts/e2e.mjs --js",
-"e2e:sea": "node scripts/e2e.mjs --sea",
+    "e2e:sea": "node scripts/e2e.mjs --sea",
     "e2e:all": "node scripts/e2e.mjs --all",
     "test": "run-s check test:*",
     "test:prepare": "dotenvx -q run -f .env.test -- pnpm build && del-cli 'test/**/node_modules'",

packages/cli/scripts/build.mjs

@@ -143,7 +143,7 @@ async function main() {
 
     if (!watchResult || watchResult.code !== 0) {
       process.exitCode = watchResult?.code ?? 1
-      throw new Error(`Watch mode failed with exit code ${watchResult?.code}`)
+      throw new Error(`Watch mode failed with exit code ${watchResult?.code ?? 1}`)
     }
     return
   }

packages/cli/scripts/download-assets.mjs

@@ -336,12 +336,14 @@ async function downloadAssets(assetNames, parallel = true) {
     )
 
     const failed = settled.filter(
-      r => r.status === 'fulfilled' && !r.value.ok,
+      r => r.status === 'rejected' || (r.status === 'fulfilled' && !r.value.ok),
     )
     if (failed.length > 0) {
       logger.error(`\n${failed.length} asset(s) failed:`)
       for (const r of failed) {
-        logger.error(`  - ${r.value.name}`)
+        logger.error(
+          `  - ${r.status === 'rejected' ? r.reason?.message ?? r.reason : r.value.name}`,
+        )
       }
       process.exitCode = 1
     }

packages/cli/scripts/esbuild-utils.mjs

@@ -158,5 +158,6 @@ export async function runBuild(config, description = 'Build') {
     logger.error(`Build failed: ${description || 'Unknown'}`)
     logger.error(e)
     process.exitCode = 1
+    throw e
   }
 }