Skip to content

Commit 88cc370

Browse files
author
Graydon Hope
committed
Removing unnecessary test
1 parent ab9b932 commit 88cc370

File tree

2 files changed

+6
-21
lines changed

2 files changed

+6
-21
lines changed

packages/cli/src/commands/scan/output-scan-report.mts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,12 @@ export async function outputScanReport(
9696
process.exitCode = 1;
9797
}
9898

99+
// I don't think we emit the default error message with banner for an unhealthy report, do we?
100+
// if (!scanReport.data.healthy) {
101+
// logger.fail(failMsgWithBadge(scanReport.message, scanReport.cause))
102+
// return
103+
// }
104+
99105
if (
100106
outputKind === OUTPUT_JSON ||
101107
(outputKind === OUTPUT_TEXT && filepath && filepath.endsWith('.json'))

packages/cli/test/unit/commands/ci/handle-ci.test.mts

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -266,25 +266,4 @@ describe('handleCi', () => {
266266
expect(mockDebug).toHaveBeenCalledWith('Failed to get default org slug')
267267
expect(mockDebugDir).toHaveBeenCalledWith({ orgSlugCResult: error })
268268
})
269-
270-
it('sets exit code to 1 when scan report is unhealthy',
271-
async () => {
272-
mockGetDefaultOrgSlug.mockResolvedValue({
273-
ok: true,
274-
data: 'test-org',
275-
})
276-
277-
mockGitBranch.mockResolvedValue('main')
278-
mockGetRepoName.mockResolvedValue('test-repo')
279-
280-
mockHandleCreateNewScan.mockImplementation(async () => {
281-
process.exitCode = 1;
282-
})
283-
284-
await handleCi(false)
285-
286-
expect(process.exitCode).toBe(1)
287-
expect(mockHandleCreateNewScan).toHaveBeenCalled()
288-
}
289-
)
290269
})

0 commit comments

Comments
 (0)