Skip to content

Commit 9e95043

Browse files
jdaltonjdalton
committed
refactor: replace logger.log() with logger.log('') for explicit empty line
Change all instances of logger.log() with no arguments to logger.log('') for explicit clarity that we're printing an empty line. This makes the intent clearer and is more consistent with the logger API. Files affected: 22 files across scripts and packages
1 parent c2d8f7f commit 9e95043

23 files changed

+140
-127
lines changed

‎packages/cli/scripts/build.mjs‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,21 +26,21 @@ const log = {
2626
error: msg => logger.error(msg),
2727
}
2828
const printHeader = title => {
29-
logger.log()
29+
logger.log('')
3030
logger.log(title)
3131
logger.log('='.repeat(title.length))
32-
logger.log()
32+
logger.log('')
3333
}
34-
const printFooter = () => logger.log()
34+
const printFooter = () => logger.log('')
3535
const printSuccess = msg => {
36-
logger.log()
36+
logger.log('')
3737
logger.success(msg)
38-
logger.log()
38+
logger.log('')
3939
}
4040
const printError = msg => {
41-
logger.log()
41+
logger.log('')
4242
logger.error(msg)
43-
logger.log()
43+
logger.log('')
4444
}
4545

4646
async function main() {

‎packages/cli/scripts/claude.mjs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3820,7 +3820,7 @@ async function validateBeforePush(cwd) {
38203820
// Check 1: No console.log statements
38213821
if (diff.match(/^\+.*console\.log\(/m)) {
38223822
warnings.push(
3823-
`${colors.yellow('⚠')} Added logger.log() statements detected`,
3823+
`${colors.yellow('⚠')} Added logger.log('') statements detected`,
38243824
)
38253825
}
38263826

‎packages/cli/scripts/cover.mjs‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -98,11 +98,11 @@ async function main() {
9898

9999
if (typeCoverageMatch) {
100100
const typeCoveragePercent = Number.parseFloat(typeCoverageMatch[1])
101-
logger.log()
101+
logger.log('')
102102
logger.log(' Coverage Summary')
103103
logger.log(' ───────────────────────────────')
104104
logger.log(` Type Coverage: ${typeCoveragePercent.toFixed(2)}%`)
105-
logger.log()
105+
logger.log('')
106106
}
107107
}
108108

@@ -140,9 +140,9 @@ async function main() {
140140
/Test Files\s+\d+[^\n]*\n[\s\S]*?Duration\s+[\d.]+m?s[^\n]*/,
141141
)
142142
if (!values.summary && testSummaryMatch) {
143-
logger.log()
143+
logger.log('')
144144
logger.log(testSummaryMatch[0])
145-
logger.log()
145+
logger.log('')
146146
}
147147

148148
// Extract and display coverage summary
@@ -161,14 +161,14 @@ async function main() {
161161
logger.log(coverageHeaderMatch[1])
162162
logger.log(allFilesMatch[0])
163163
logger.log(coverageHeaderMatch[1])
164-
logger.log()
164+
logger.log('')
165165
}
166166

167167
const codeCoveragePercent = Number.parseFloat(allFilesMatch[1])
168168
logger.log(' Coverage Summary')
169169
logger.log(' ───────────────────────────────')
170170
logger.log(` Code Coverage: ${codeCoveragePercent.toFixed(2)}%`)
171-
logger.log()
171+
logger.log('')
172172
} else if (code !== 0) {
173173
logger.log('\n--- Output ---')
174174
logger.log(output)
@@ -225,9 +225,9 @@ async function main() {
225225
// Display clean output
226226
if (!quiet) {
227227
if (!values.summary && testSummaryMatch) {
228-
logger.log()
228+
logger.log('')
229229
logger.log(testSummaryMatch[0])
230-
logger.log()
230+
logger.log('')
231231
}
232232

233233
if (coverageHeaderMatch && allFilesMatch) {
@@ -238,7 +238,7 @@ async function main() {
238238
logger.log(coverageHeaderMatch[1]) // Middle border
239239
logger.log(allFilesMatch[0]) // All files row
240240
logger.log(coverageHeaderMatch[1]) // Bottom border
241-
logger.log()
241+
logger.log('')
242242
}
243243

244244
// Display type coverage and cumulative summary
@@ -256,7 +256,7 @@ async function main() {
256256
logger.log(` Code Coverage: ${codeCoveragePercent.toFixed(2)}%`)
257257
logger.log(' ───────────────────────────────')
258258
logger.log(` Cumulative: ${cumulativePercent}%`)
259-
logger.log()
259+
logger.log('')
260260
}
261261
}
262262
}

‎packages/cli/scripts/fix.mjs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ async function main() {
4040
try {
4141
if (!quiet) {
4242
printHeader('Running Auto-fix')
43-
logger.log()
43+
logger.log('')
4444
}
4545

4646
// Build lint command arguments.
@@ -68,7 +68,7 @@ async function main() {
6868
process.exitCode = 1
6969
} else {
7070
if (!quiet) {
71-
logger.log()
71+
logger.log('')
7272
logger.success('Auto-fix completed!')
7373
}
7474
}

‎packages/node-sea-builder/scripts/publish.mjs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ async function main() {
195195
logger.log('Socket CLI SEA Publisher')
196196
logger.log('========================')
197197
logger.log(`Version: ${version}`)
198-
logger.log()
198+
logger.log('')
199199

200200
// Build binaries.
201201
if (!options.skipBuild) {

‎packages/node-sea-builder/scripts/verify-sea-transforms.mjs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ async function main() {
109109
} else {
110110
logger.log(`${colors.red('✗')} Polyfill NOT found`)
111111
}
112-
logger.log()
112+
logger.log('')
113113

114114
// Check 2: Unsafe patterns.
115115
logger.log('Check 2: Unsafe require.resolve.paths Patterns')
@@ -125,10 +125,10 @@ async function main() {
125125
logger.log(` Line ${issue.line}: ${issue.type}`)
126126
logger.log(` Code: ${issue.code}`)
127127
logger.log(` Reason: ${issue.reason}`)
128-
logger.log()
128+
logger.log('')
129129
}
130130
}
131-
logger.log()
131+
logger.log('')
132132

133133
// Check 3: Sentinel obscuration.
134134
logger.log('Check 3: Sentinel Obscuration')
@@ -146,7 +146,7 @@ async function main() {
146146
} else {
147147
logger.log(`${colors.blue('ℹ')} Sentinel status unclear`)
148148
}
149-
logger.log()
149+
logger.log('')
150150

151151
// Summary.
152152
logger.log('Summary')

‎packages/node-smol-builder/scripts/compress-macho.mjs‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ async function buildTools() {
4747

4848
logger.log('Building compression tools...')
4949
logger.log(` Directory: ${TOOLS_DIR}`)
50-
logger.log()
50+
logger.log('')
5151

5252
try {
5353
const { stdout, stderr } = await execFileAsync('make', ['all'], {
@@ -66,7 +66,7 @@ async function buildTools() {
6666
}
6767

6868
logger.log(`${colors.green('✓')} Tools built successfully`)
69-
logger.log()
69+
logger.log('')
7070
} catch (error) {
7171
logger.error(`${colors.red('✗')} Failed to build tools:`)
7272
logger.error(error.message)
@@ -82,7 +82,7 @@ async function compressBinary(inputPath, outputPath, quality = 'lzfse') {
8282
logger.log(` Input: ${inputPath}`)
8383
logger.log(` Output: ${outputPath}`)
8484
logger.log(` Quality: ${quality}`)
85-
logger.log()
85+
logger.log('')
8686

8787
// Ensure input exists.
8888
if (!existsSync(inputPath)) {
@@ -106,7 +106,7 @@ async function compressBinary(inputPath, outputPath, quality = 'lzfse') {
106106
throw new Error('Compressed binary was not created')
107107
}
108108

109-
logger.log()
109+
logger.log('')
110110
logger.log(`${colors.green('✓')} Compression complete`)
111111
} catch (error) {
112112
logger.error(`${colors.red('✗')} Compression failed:`)
@@ -153,18 +153,18 @@ async function main() {
153153
// Compress binary.
154154
await compressBinary(inputPath, outputPath, quality)
155155

156-
logger.log()
156+
logger.log('')
157157
logger.log('📝 Next steps:')
158-
logger.log()
158+
logger.log('')
159159
logger.log('1. Test the compressed binary:')
160160
logger.log(` ${DECOMPRESS_TOOL} ${outputPath} --version`)
161-
logger.log()
161+
logger.log('')
162162
logger.log('2. Sign the compressed binary (macOS):')
163163
logger.log(` codesign --sign - --force ${outputPath}`)
164-
logger.log()
164+
logger.log('')
165165
logger.log('3. Distribute the compressed binary with the decompressor')
166166
logger.log(` cp ${DECOMPRESS_TOOL} <distribution-directory>/`)
167-
logger.log()
167+
logger.log('')
168168
} catch (error) {
169169
logger.error()
170170
logger.error(`${colors.red('✗')} Compression failed`)

‎pnpm-lock.yaml‎

Lines changed: 24 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎pnpm-workspace.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ packages:
44
catalog:
55
# Socket shared dependencies - define versions once, reference with catalog: protocol.
66
'@socketsecurity/config': 3.0.1
7-
'@socketsecurity/lib': 2.1.0
7+
'@socketsecurity/lib': 2.2.0
88
'@socketsecurity/registry': 2.0.0
99
'@socketsecurity/sdk': 3.0.7

‎scripts/apply-socket-mods.mjs‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ async function fixV8IncludePaths() {
9898
}
9999

100100
logger.log(`${colors.green('✓')} V8 include paths fixed`)
101-
logger.log()
101+
logger.log('')
102102
}
103103

104104
/**
@@ -130,25 +130,25 @@ const { getAsset: getAssetInternal, getAssetKeys: getAssetKeysInternal } = inter
130130
}
131131

132132
logger.log(`${colors.green('✓')} SEA detection enabled`)
133-
logger.log()
133+
logger.log('')
134134
}
135135

136136
/**
137137
* Main function
138138
*/
139139
async function main() {
140140
logger.log('🔨 Applying Socket modifications to Node.js source')
141-
logger.log()
141+
logger.log('')
142142

143143
await fixV8IncludePaths()
144144
await enableSeaForPkg()
145145

146146
logger.log('🎉 All modifications applied!')
147-
logger.log()
147+
logger.log('')
148148
logger.log('📝 To generate patches:')
149149
logger.log(' cd build/node-smol')
150150
logger.log(' git diff > ../../build/patches/socket/my-changes.patch')
151-
logger.log()
151+
logger.log('')
152152
}
153153

154154
// Run main function

0 commit comments

Comments
 (0)