refactor: remove manual file validation from coana-fix

jdalton · jdalton · commit b25b68b509b3 · 2025-10-23T13:25:39.000-04:00
SDK v3.0 now handles file validation automatically via the
onFileValidation callback, eliminating the need for manual
validation code in individual commands.
diff --git a/packages/cli/src/commands/fix/coana-fix.mts b/packages/cli/src/commands/fix/coana-fix.mts
@@ -84,6 +84,8 @@ export async function coanaFix(
   const scanFilepaths = await getPackageFilesForScan(['.'], supportedFiles, {
     cwd,
   })
+
+  // SDK v3.0 automatically validates file readability via onFileValidation callback.
   const uploadCResult = await handleApiCall(
     sockSdk.uploadManifestFiles(orgSlug, scanFilepaths),
     {
@@ -195,7 +197,7 @@ export async function coanaFix(
       // Clean up the temporary file.
       try {
         await fs.unlink(tmpFile)
-      } catch (e) {
+      } catch (_e) {
         // Ignore cleanup errors.
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -84,6 +84,8 @@ export async function coanaFix(`
`84`	`84`	`const scanFilepaths = await getPackageFilesForScan(['.'], supportedFiles, {`
`85`	`85`	`cwd,`
`86`	`86`	`})`
	`87`	`+`
	`88`	`+ // SDK v3.0 automatically validates file readability via onFileValidation callback.`
`87`	`89`	`const uploadCResult = await handleApiCall(`
`88`	`90`	`sockSdk.uploadManifestFiles(orgSlug, scanFilepaths),`
`89`	`91`	`{`
`@@ -195,7 +197,7 @@ export async function coanaFix(`
`195`	`197`	`// Clean up the temporary file.`
`196`	`198`	`try {`
`197`	`199`	`await fs.unlink(tmpFile)`
`198`		`- } catch (e) {`
	`200`	`+ } catch (_e) {`
`199`	`201`	`// Ignore cleanup errors.`
`200`	`202`	`}`
`201`	`203`	`}`