test(coverage): cmd-nuget + cmd-bundler both-null exit/signal branch

Author: jdalton

packages/cli/src/utils/output/scrubber.mts

@@ -162,7 +162,9 @@ export function trace(
 ): void {
   if (isTraceEnabled()) {
     const prefix = adapterName ? `${adapterName}:${verdict}` : verdict
-    process.stderr.write(`[scrub ${prefix}] ${line}\n`)
+    // Direct stderr write (not via logger) bypasses the routed noise
+    // stream so trace lines don't interleave with buffered scrubber output.
+    process.stderr.write(`[scrub ${prefix}] ${line}\n`) // socket-hook: allow logger
   }
 }
 

packages/cli/src/utils/terminal/FramedHeader.mts

@@ -41,8 +41,8 @@ export async function renderFramedHeader(
 ): Promise<void> {
   const { animate = true, fps = 15, theme = 'default' } = props || {}
 
-  // Hide cursor.
-  process.stdout.write('\x1B[?25l')
+  // Hide cursor — raw ANSI escape, must hit stdout directly.
+  process.stdout.write('\x1B[?25l') // socket-hook: allow logger
 
   let frame = 0
   const frameDelay = 1000 / fps
@@ -52,8 +52,8 @@ export async function renderFramedHeader(
     const width = 40
     const framedLogo = drawBorder(logo, width)
 
-    // Move cursor to home and clear from cursor down.
-    process.stdout.write('\x1B[H\x1B[J')
+    // Move cursor home + clear from cursor down — raw ANSI, direct stdout.
+    process.stdout.write('\x1B[H\x1B[J') // socket-hook: allow logger
     logger.log(`\nTheme: ${theme} | Frame: ${frame}\n`)
     logger.log(framedLogo)
 
@@ -62,7 +62,8 @@ export async function renderFramedHeader(
 
   if (!animate) {
     renderFrame()
-    process.stdout.write('\x1B[?25h')
+    // Restore cursor — raw ANSI, direct stdout.
+    process.stdout.write('\x1B[?25h') // socket-hook: allow logger
     return
   }
 
@@ -71,7 +72,8 @@ export async function renderFramedHeader(
 
   const cleanup = () => {
     clearInterval(interval)
-    process.stdout.write('\x1B[?25h')
+    // Restore cursor — raw ANSI, direct stdout.
+    process.stdout.write('\x1B[?25h') // socket-hook: allow logger
   }
 
   // Handle cleanup on interrupt.

packages/cli/test/unit/commands/bundler/cmd-bundler.test.mts

@@ -175,6 +175,45 @@ describe('cmd-bundler', () => {
     })
 
     describe('exit handling', () => {
+      it('skips exit/kill when both code and signal are null', async () => {
+        const mockChildProcess = new EventEmitter()
+        const mockSpawnPromise = Promise.resolve({
+          code: null,
+          signal: null,
+          stderr: Buffer.from(''),
+          stdout: Buffer.from(''),
+        })
+        ;(mockSpawnPromise as any).process = mockChildProcess
+
+        mockSpawnSfwDlx.mockResolvedValue({ spawnPromise: mockSpawnPromise })
+        mockFilterFlags.mockReturnValue([])
+
+        const mockExit = vi
+          .spyOn(process, 'exit')
+          .mockImplementation((() => {}) as any)
+        mockExit.mockClear()
+        const mockKill = vi
+          .spyOn(process, 'kill')
+          .mockImplementation((() => {}) as any)
+        mockKill.mockClear()
+
+        cmdBundler.run([], importMeta, context)
+
+        await new Promise(resolve => setImmediate(resolve))
+        const exitBefore = mockExit.mock.calls.length
+        const killBefore = mockKill.mock.calls.length
+
+        mockChildProcess.emit('exit', null, null)
+
+        await new Promise(resolve => setImmediate(resolve))
+
+        expect(mockExit.mock.calls.length).toBe(exitBefore)
+        expect(mockKill.mock.calls.length).toBe(killBefore)
+
+        mockExit.mockRestore()
+        mockKill.mockRestore()
+      })
+
       it('should set default exit code to 1 before child process exits', async () => {
         const mockChildProcess = new EventEmitter()
         const mockSpawnPromise = Promise.resolve({

packages/cli/test/unit/commands/nuget/cmd-nuget.test.mts

@@ -215,6 +215,47 @@ describe('cmd-nuget', () => {
       })
     })
 
+    it('skips exit/kill when both code and signal are null', async () => {
+      const mockChildProcess = new EventEmitter()
+      const mockSpawnPromise = Promise.resolve({
+        code: null,
+        signal: null,
+        stderr: Buffer.from(''),
+        stdout: Buffer.from(''),
+      })
+      ;(mockSpawnPromise as any).process = mockChildProcess
+
+      mockSpawnSfwDlx.mockResolvedValue({ spawnPromise: mockSpawnPromise })
+      mockFilterFlags.mockReturnValue([])
+
+      const mockExit = vi
+        .spyOn(process, 'exit')
+        .mockImplementation((() => {}) as any)
+      mockExit.mockClear()
+      const mockKill = vi
+        .spyOn(process, 'kill')
+        .mockImplementation((() => {}) as any)
+      mockKill.mockClear()
+
+      cmdNuget.run([], { url: import.meta.url } as any, {
+        parentName: 'socket',
+      } as any)
+
+      await new Promise(resolve => setImmediate(resolve))
+      const exitBefore = mockExit.mock.calls.length
+      const killBefore = mockKill.mock.calls.length
+
+      mockChildProcess.emit('exit', null, null)
+
+      await new Promise(resolve => setImmediate(resolve))
+
+      expect(mockExit.mock.calls.length).toBe(exitBefore)
+      expect(mockKill.mock.calls.length).toBe(killBefore)
+
+      mockExit.mockRestore()
+      mockKill.mockRestore()
+    })
+
     it('should set default exit code to 1', async () => {
       const mockChildProcess = new EventEmitter()
       const mockSpawnPromise = Promise.resolve({