fix: use forward-slash patterns for normalized path matching

- Fix detection.mts to always use forward-slash patterns since normalizePath
  converts all paths to forward slashes
- Remove unused path import from detection.mts
- Fix completion.test.mts to expect normalized paths with forward slashes

The issue was that path.sep-based pattern selection created backslash patterns
on Windows, but normalizedPath had forward slashes, causing pattern matching
to fail. Since we normalize all paths to forward slashes, patterns must also
use forward slashes.

Author: jdalton

docs/development/SCRIPT-SIMPLIFICATION-QUICK-START.md

@@ -44,9 +44,13 @@ describe('completion utilities', () => {
         data: 'source /mock/dist/path/data/socket-completion.bash',
       })
 
-      expect(fs.existsSync).toHaveBeenCalledWith(
-        '/mock/dist/path/data/socket-completion.bash',
-      )
+      // Note: On Windows, path.join returns backslashes, which are then checked by existsSync.
+      // The implementation normalizes the path display but checks existence with the actual path.
+      const expectedPath =
+        path.sep === '\\'
+          ? '\\mock\\dist\\path\\data\\socket-completion.bash'
+          : '/mock/dist/path/data/socket-completion.bash'
+      expect(fs.existsSync).toHaveBeenCalledWith(expectedPath)
     })
 
     it('returns error when completion script does not exist', () => {
@@ -138,12 +142,9 @@ describe('completion utilities', () => {
 
       expect(result.ok).toBe(true)
       if (result.ok) {
+        // Note: The implementation normalizes paths to forward slashes for bash compatibility.
         expect(result.data.targetPath).toBe(
-          path.join(
-            path.dirname('/mock/app/data'),
-            'completion',
-            'socket-completion.bash',
-          ),
+          '/mock/app/completion/socket-completion.bash',
         )
       }
     })

packages/cli/src/utils/cli/completion.test.mts

@@ -22,8 +22,6 @@
  * - Ensures package manager commands work correctly
  */
 
-import path from 'node:path'
-
 import { normalizePath } from '@socketsecurity/lib/path'
 
 import ENV from '../../constants/env.mts'
@@ -59,14 +57,13 @@ export function isRunningInTemporaryExecutor(): boolean {
   }
 
   // Check common temporary execution path patterns.
+  // Note: Always use forward slashes since we normalize paths to forward slashes.
   const tempPatterns = [
     '_npx', // npm's npx cache directory
     '.pnpm-store', // pnpm dlx temporary store
     'dlx-', // Common dlx directory prefix
     '.yarn/$$', // Yarn Berry PnP virtual packages
-    path.sep === '\\'
-      ? 'AppData\\Local\\Temp\\xfs-'
-      : 'AppData/Local/Temp/xfs-', // Yarn on Windows
+    'AppData/Local/Temp/xfs-', // Yarn on Windows
   ]
 
   return tempPatterns.some(pattern => normalizedDirname.includes(pattern))
@@ -135,14 +132,13 @@ export function shouldSkipShadow(
   }
 
   // Check common temporary execution path patterns.
+  // Note: Always use forward slashes since we normalize paths to forward slashes.
   const tempPatterns = [
     '_npx', // npm's npx cache directory
     '.pnpm-store', // pnpm dlx temporary store
     'dlx-', // Common dlx directory prefix
     '.yarn/$$', // Yarn Berry PnP virtual packages
-    path.sep === '\\'
-      ? 'AppData\\Local\\Temp\\xfs-'
-      : 'AppData/Local/Temp/xfs-', // Yarn on Windows
+    'AppData/Local/Temp/xfs-', // Yarn on Windows
   ]
 
   return tempPatterns.some(pattern => normalizedCwd.includes(pattern))