Skip to content

Commit e490937

Browse files
committed
refactor(scripts): use logger methods instead of manual emoji formatting
Replace manual emoji formatting with proper logger methods for consistent output and better compatibility across terminals. Changes: - scripts/publish.mjs: Use logger.success() instead of logger.log with ✓ emoji - packages/cli/scripts/build.mjs: Use logger methods (info, step, success, error) instead of manual emoji prefixes Benefits: - Consistent with @socketsecurity/lib/logger API - Automatic color coding and symbol selection - Unicode/ASCII fallback handled automatically - Proper line break management with logger.log() calls - Matches spinner API consistency The logger provides: - logger.success() - green ✔ - logger.error() - red ✖ - logger.warn() - yellow ⚠ - logger.info() - blue ℹ - logger.step() - for build steps - logger.substep() - for sub-steps
1 parent 475412d commit e490937

File tree

2 files changed

+25
-11
lines changed

2 files changed

+25
-11
lines changed

packages/cli/scripts/build.mjs

Lines changed: 21 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,28 @@ import { spawn } from '@socketsecurity/lib/spawn'
2020
const isQuiet = () => process.argv.includes('--quiet')
2121
const isVerbose = () => process.argv.includes('--verbose')
2222
const log = {
23-
info: msg => logger.log(`ℹ ${msg}`),
24-
step: msg => logger.log(`→ ${msg}`),
25-
success: msg => logger.log(`✓ ${msg}`),
26-
error: msg => logger.error(`✖ ${msg}`),
23+
info: msg => logger.info(msg),
24+
step: msg => logger.step(msg),
25+
success: msg => logger.success(msg),
26+
error: msg => logger.error(msg),
27+
}
28+
const printHeader = title => {
29+
logger.log()
30+
logger.log(title)
31+
logger.log('='.repeat(title.length))
32+
logger.log()
33+
}
34+
const printFooter = () => logger.log()
35+
const printSuccess = msg => {
36+
logger.log()
37+
logger.success(msg)
38+
logger.log()
39+
}
40+
const printError = msg => {
41+
logger.log()
42+
logger.error(msg)
43+
logger.log()
2744
}
28-
const printHeader = title =>
29-
logger.log(`\n${title}\n${'='.repeat(title.length)}\n`)
30-
const printFooter = () => logger.log('')
31-
const printSuccess = msg => logger.log(`\n✓ ${msg}\n`)
32-
const printError = msg => logger.error(`\n✖ ${msg}\n`)
3345

3446
async function main() {
3547
const quiet = isQuiet()

scripts/publish.mjs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,11 @@ async function main() {
7373
})
7474

7575
if (result.code === 0) {
76-
logger.log(`\n✓ Successfully published ${target}`)
76+
logger.log()
77+
logger.success(`Successfully published ${target}`)
7778
} else {
78-
logger.error(`\n✗ Failed to publish ${target}`)
79+
logger.log()
80+
logger.error(`Failed to publish ${target}`)
7981
}
8082

8183
process.exit(result.code ?? 1)

0 commit comments

Comments
 (0)