Skip to content

Commit e6d5c51

Browse files
committed
fix(smol-builder): fix smokeTestBinary API mismatch
- smokeTestBinary returns boolean, not object with passed/reason - Update all 3 call sites to handle boolean return value - Fixes smoke test failures after code signing and stripping
1 parent 74e7fb0 commit e6d5c51

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

packages/node-smol-builder/scripts/build.mjs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1625,12 +1625,12 @@ async function main() {
16251625

16261626
// Smoke test after signing to ensure signature is valid.
16271627
logger.log('Testing binary after signing...')
1628-
const signTest = await smokeTestBinary(nodeBinary)
1628+
const signTestPassed = await smokeTestBinary(nodeBinary)
16291629

1630-
if (!signTest.passed) {
1630+
if (!signTestPassed) {
16311631
printError(
16321632
'Binary Corrupted After Signing',
1633-
`Binary failed smoke test: ${signTest.reason}`,
1633+
'Binary failed smoke test after code signing',
16341634
[
16351635
'Code signing may have corrupted the binary',
16361636
'Try rebuilding: node scripts/build-custom-node.mjs --clean',
@@ -1646,12 +1646,12 @@ async function main() {
16461646

16471647
// Smoke test binary after stripping (ensure strip didn't corrupt it).
16481648
logger.log('Testing binary after stripping...')
1649-
const smokeTest = await smokeTestBinary(nodeBinary)
1649+
const smokeTestPassed = await smokeTestBinary(nodeBinary)
16501650

1651-
if (!smokeTest.passed) {
1651+
if (!smokeTestPassed) {
16521652
printError(
16531653
'Binary Corrupted After Stripping',
1654-
`Binary failed smoke test: ${smokeTest.reason}`,
1654+
'Binary failed smoke test after stripping',
16551655
[
16561656
'Strip command may have corrupted the binary',
16571657
'Try rebuilding: node scripts/build-custom-node.mjs --clean',
@@ -1762,12 +1762,12 @@ async function main() {
17621762

17631763
// Smoke test compressed+signed binary to ensure it's functional.
17641764
logger.log('Testing compressed binary after signing...')
1765-
const compressedTest = await smokeTestBinary(compressedBinary)
1765+
const compressedTestPassed = await smokeTestBinary(compressedBinary)
17661766

1767-
if (!compressedTest.passed) {
1767+
if (!compressedTestPassed) {
17681768
printError(
17691769
'Compressed Binary Corrupted After Signing',
1770-
`Compressed binary failed smoke test: ${compressedTest.reason}`,
1770+
'Compressed binary failed smoke test after signing',
17711771
[
17721772
'Compression or signing may have corrupted the binary',
17731773
'Try rebuilding: node scripts/build-custom-node.mjs --clean',

0 commit comments

Comments
 (0)