Skip to content

Commit f05828a

Browse files
committed
fix(test): delete obsolete bootstrap test and fix provider factory assertions
- Deleted obsolete SEA bootstrap entry point test (moved to packages/bootstrap) - Replaced toBeInstanceOf checks with provider name/GraphQL support checks - Fixed cross-platform paths in mock using os.tmpdir() and path.join() - Added getGithubCachePath mock to prevent module not found errors Test improvements: - Deleted 1 obsolete test (bootstrap moved to separate package) - Fixed 2 provider assertions (use name check instead of instanceof) - Test results: 4 failed, 2802 passed (down from 7 failed, 2800 passed) Remaining 3 failures are due to dynamic require() bypassing vi.mock for GitHub provider tests. GitLab tests pass, GitHub provider tests pass in isolation.
1 parent 9d27054 commit f05828a

2 files changed

Lines changed: 13 additions & 16 deletions

File tree

packages/cli/src/utils/git/providers.test.mts

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
import os from 'node:os'
2+
import path from 'node:path'
3+
14
import { beforeEach, describe, expect, it, vi } from 'vitest'
25

36
import { createPrProvider } from './provider-factory.mts'
@@ -9,8 +12,10 @@ vi.mock('node:child_process', () => ({
912
spawnSync: vi.fn(),
1013
}))
1114

15+
const mockCacheDir = path.join(os.tmpdir(), 'socket-cache')
1216
vi.mock('../../constants/paths.mjs', () => ({
13-
SOCKET_CLI_CACHE_DIR: '/tmp/socket-cache',
17+
SOCKET_CLI_CACHE_DIR: mockCacheDir,
18+
getGithubCachePath: () => path.join(mockCacheDir, 'github'),
1419
}))
1520

1621
vi.mock('./github.mts', () => ({
@@ -59,8 +64,8 @@ describe('provider-factory', () => {
5964
})
6065

6166
const provider = createPrProvider()
62-
expect(provider).toBeInstanceOf(GitHubProvider)
6367
expect(provider.getProviderName()).toBe('github')
68+
expect(provider.supportsGraphQL()).toBe(true)
6469
})
6570

6671
it('returns GitLabProvider for gitlab.com remote', async () => {
@@ -78,8 +83,8 @@ describe('provider-factory', () => {
7883
process.env.GITLAB_TOKEN = 'test-token'
7984

8085
const provider = createPrProvider()
81-
expect(provider).toBeInstanceOf(GitLabProvider)
8286
expect(provider.getProviderName()).toBe('gitlab')
87+
expect(provider.supportsGraphQL()).toBe(false)
8388
})
8489

8590
it('returns GitLabProvider when GITLAB_HOST is set', async () => {
@@ -97,8 +102,8 @@ describe('provider-factory', () => {
97102
process.env.GITLAB_TOKEN = 'test-token'
98103

99104
const provider = createPrProvider()
100-
expect(provider).toBeInstanceOf(GitLabProvider)
101105
expect(provider.getProviderName()).toBe('gitlab')
106+
expect(provider.supportsGraphQL()).toBe(false)
102107
})
103108

104109
it('falls back to GitHubProvider when git command fails', async () => {
@@ -113,7 +118,8 @@ describe('provider-factory', () => {
113118
})
114119

115120
const provider = createPrProvider()
116-
expect(provider).toBeInstanceOf(GitHubProvider)
121+
expect(provider.getProviderName()).toBe('github')
122+
expect(provider.supportsGraphQL()).toBe(true)
117123
})
118124

119125
it('falls back to GitHubProvider for empty remote', async () => {
@@ -128,7 +134,8 @@ describe('provider-factory', () => {
128134
})
129135

130136
const provider = createPrProvider()
131-
expect(provider).toBeInstanceOf(GitHubProvider)
137+
expect(provider.getProviderName()).toBe('github')
138+
expect(provider.supportsGraphQL()).toBe(true)
132139
})
133140
})
134141
})

packages/cli/test/build-sea.test.mts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,6 @@ import path from 'node:path'
88
import { describe, expect, it } from 'vitest'
99

1010
describe('SEA build validation', () => {
11-
it('should have SEA bootstrap entry point', () => {
12-
const bootstrapPath = path.join(
13-
process.cwd(),
14-
'src',
15-
'stub',
16-
'bootstrap.mts',
17-
)
18-
expect(existsSync(bootstrapPath)).toBe(true)
19-
})
20-
2111
it('should have SEA configuration', () => {
2212
const configPath = path.join(
2313
process.cwd(),

0 commit comments

Comments
 (0)