Skip to content

Commit f0b565c

Browse files
jdaltonclaude
andcommitted
Remove obsolete cdxgen flag validation tests
Remove tests for flag validation that was intentionally removed in commit de9fa08 (Simplify cdxgen command forwarding). Command now forwards all flags directly to cdxgen. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 2d15649 commit f0b565c

File tree

1 file changed

+3
-47
lines changed

1 file changed

+3
-47
lines changed

src/commands/manifest/cmd-manifest-cdxgen.test.mts

Lines changed: 3 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -154,52 +154,8 @@ describe('socket manifest cdxgen', async () => {
154154
},
155155
)
156156

157-
// TODO: Fix test failure - cdxgen unknown short flag forwarding
158-
// Test may be timing out or failing due to command forwarding logic changes
159-
it('should not forward an unknown short flag to cdxgen', async () => {
160-
const command = '-u'
161-
await expect(
162-
spawn(
163-
constants.execPath,
164-
[binCliPath, 'manifest', 'cdxgen', command],
165-
spawnOpts,
166-
),
167-
// @ts-ignore toHaveStderrInclude is defined above.
168-
).rejects.toHaveStderrInclude(
169-
`${LOG_SYMBOLS.fail} Unknown argument: ${command}`,
170-
)
171-
})
172-
173-
// TODO: Fix test failure - cdxgen unknown flag forwarding
174-
// Test may be timing out or failing due to command forwarding logic changes
175-
it('should not forward an unknown flag to cdxgen', async () => {
176-
const command = '--unknown'
177-
await expect(
178-
spawn(
179-
constants.execPath,
180-
[binCliPath, 'manifest', 'cdxgen', command],
181-
spawnOpts,
182-
),
183-
// @ts-ignore toHaveStderrInclude is defined above
184-
).rejects.toHaveStderrInclude(
185-
`${LOG_SYMBOLS.fail} Unknown argument: ${command}`,
186-
)
187-
})
188-
189-
// TODO: Fix test failure - cdxgen multiple unknown flags forwarding
190-
// Test may be timing out or failing due to command forwarding logic changes
191-
it('should not forward multiple unknown flags to cdxgen', async () => {
192-
await expect(
193-
() =>
194-
spawn(
195-
constants.execPath,
196-
[binCliPath, 'manifest', 'cdxgen', '-u', '-h', '--unknown'],
197-
spawnOpts,
198-
),
199-
// @ts-ignore toHaveStderrInclude is defined above
200-
).rejects.toHaveStderrInclude(
201-
`${LOG_SYMBOLS.fail} Unknown arguments: -u and --unknown`,
202-
)
203-
})
157+
// Note: Unknown flag validation was removed in commit de9fa089
158+
// ("Simplify cdxgen command forwarding to remove complex validation").
159+
// The command now forwards all flags to cdxgen, which handles validation.
204160
})
205161
})

0 commit comments

Comments
 (0)