fix(scan): add optional chaining for spinner safety

Handle cases where getSpinner() may return undefined by using optional
chaining (?.) for all spinner method calls in scan command handlers.

Changes:
- handle-create-new-scan.mts: Add ?. for start(), successAndStop(), stop()
- handle-scan-reach.mts: Add ?. for spinner methods
- output-create-new-scan.mts: Add ?. for spinner methods
- perform-reachability-analysis.mts: Add ?. for spinner methods

This ensures scan commands work correctly even when spinner is unavailable.

Author: jdalton

packages/cli/src/commands/scan/handle-create-new-scan.mts

@@ -103,7 +103,7 @@ export async function handleCreateNewScan({
     logger.info('Auto-generation finished. Proceeding with Scan creation.')
   }
 
-  const spinner = getSpinner()!
+  const spinner = getSpinner()
   const supportedFilesCResult = await fetchSupportedScanFileNames({ spinner })
   if (!supportedFilesCResult.ok) {
     debug('Failed to fetch supported scan file names')
@@ -116,14 +116,14 @@ export async function handleCreateNewScan({
   }
   debug(`Fetched ${supportedFilesCResult.data['size']} supported file types`)
 
-  spinner.start('Searching for local files to include in scan...')
+  spinner?.start('Searching for local files to include in scan...')
 
   const supportedFiles = supportedFilesCResult.data
   const packagePaths = await getPackageFilesForScan(targets, supportedFiles, {
     cwd,
   })
 
-  spinner.successAndStop('Finished searching for local files.')
+  spinner?.successAndStop('Finished searching for local files.')
 
   const wasValidInput = checkCommandInput(outputKind, {
     nook: true,
@@ -155,7 +155,7 @@ export async function handleCreateNewScan({
     debug('Reachability analysis enabled')
     debugDir({ reachabilityOptions: reach })
 
-    spinner.start()
+    spinner?.start()
 
     const reachResult = await performReachabilityAnalysis({
       branchName,
@@ -167,7 +167,7 @@ export async function handleCreateNewScan({
       spinner,
     })
 
-    spinner.stop()
+    spinner?.stop()
 
     if (!reachResult.ok) {
       await outputCreateNewScan(reachResult, { interactive, outputKind })

packages/cli/src/commands/scan/handle-scan-reach.mts

@@ -30,7 +30,7 @@ export async function handleScanReach({
   reachabilityOptions,
   targets,
 }: HandleScanReachConfig) {
-  const spinner = getSpinner()!
+  const spinner = getSpinner()
 
   // Get supported file names
   const supportedFilesCResult = await fetchSupportedScanFileNames({ spinner })
@@ -43,7 +43,7 @@ export async function handleScanReach({
     return
   }
 
-  spinner.start(
+  spinner?.start(
     'Searching for local manifest files to include in reachability analysis...',
   )
 
@@ -52,7 +52,7 @@ export async function handleScanReach({
     cwd,
   })
 
-  spinner.successAndStop(
+  spinner?.successAndStop(
     `Found ${packagePaths.length} ${pluralize('manifest file', { count: packagePaths.length })} for reachability analysis.`,
   )
 
@@ -71,7 +71,7 @@ export async function handleScanReach({
     `Found ${packagePaths.length} local ${pluralize('file', { count: packagePaths.length })}`,
   )
 
-  spinner.start('Running reachability analysis...')
+  spinner?.start('Running reachability analysis...')
 
   const result = await performReachabilityAnalysis({
     cwd,

packages/cli/src/commands/scan/output-create-new-scan.mts

@@ -25,7 +25,7 @@ export async function outputCreateNewScan(
   const {
     interactive = false,
     outputKind = 'text',
-    spinner = getSpinner()!,
+    spinner = getSpinner(),
   } = { __proto__: null, ...options } as CreateNewScanOptions
 
   if (!result.ok) {
@@ -39,15 +39,15 @@ export async function outputCreateNewScan(
   if (outputKind === 'json') {
     logger.log(serializeResultJson(result))
     if (wasSpinning) {
-      spinner.start()
+      spinner?.start()
     }
     return
   }
 
   if (!result.ok) {
     logger.fail(failMsgWithBadge(result.message, result.cause))
     if (wasSpinning) {
-      spinner.start()
+      spinner?.start()
     }
     return
   }
@@ -72,7 +72,7 @@ export async function outputCreateNewScan(
     }
     logger.log('')
     if (wasSpinning) {
-      spinner.start()
+      spinner?.start()
     }
     return
   }
@@ -98,6 +98,6 @@ export async function outputCreateNewScan(
   }
 
   if (wasSpinning) {
-    spinner.start()
+    spinner?.start()
   }
 }

packages/cli/src/commands/scan/perform-reachability-analysis.mts

@@ -112,15 +112,15 @@ export async function performReachabilityAnalysis(
 
     if (!uploadCResult.ok) {
       if (wasSpinning) {
-        spinner.start()
+        spinner?.start()
       }
       return uploadCResult
     }
 
     tarHash = (uploadCResult.data as { tarHash?: string })?.tarHash
     if (!tarHash) {
       if (wasSpinning) {
-        spinner.start()
+        spinner?.start()
       }
       return {
         ok: false,
@@ -188,7 +188,7 @@ export async function performReachabilityAnalysis(
   })
 
   if (wasSpinning) {
-    spinner.start()
+    spinner?.start()
   }
 
   return coanaResult.ok