chore: remove dead ink and yoga-layout dependencies#1170
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is ON. A cloud agent has been kicked off to fix the reported issue.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 70897b1. Configure here.
jdalton
force-pushed
the
chore/remove-dead-ink-yoga
branch
from
70897b1 to
59ec640
Compare
ink was removed from source but its catalog entries and yoga-layout WASM download remained. Remove: - ink, ink-table, ink-text-input, @types/ink from catalog - yoga-layout from catalog - yoga WASM download step from build-js.mjs and build.mjs - yoga asset config and transformYogaSync from download-assets.mjs
jdalton
force-pushed
the
chore/remove-dead-ink-yoga
branch
from
59ec640 to
d87f995
Compare
divmain
approved these changes
Apr 7, 2026
…ests
vi.mock('node:fs') auto-mocking fails intermittently with vitest's
threads pool + sharding. Switch source files to namespace fs imports
and tests to vi.spyOn so mocks intercept at runtime without module
replacement.
Also remove dead processAsset function and unused computeFileHash
import from download-assets.mjs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ink was removed from source but its catalog entries and yoga-layout WASM download remained as dead code.
Removes:
ink,ink-table,ink-text-input,@types/ink,yoga-layoutfrom pnpm-workspace.yaml catalogbuild-js.mjsandbuild.mjstransformYogaSyncfromdownload-assets.mjsNone of these are in the lockfile (0 references). The 403 CI failures on yoga download will be resolved by this removal.
Note
Low Risk
Low risk cleanup that removes unused dependencies and build steps; main risk is unintended reliance on the removed yoga asset download in some build path, but no references remain in the repo.
Overview
Removes the CLI build-time Yoga WASM download and related processing logic, simplifying
build-js.mjs,build.mjswatch mode, andscripts/download-assets.mjsby deleting theyogaasset definition and itstransformYogaSyncworkaround.Cleans the workspace catalog by dropping unused Ink-related packages (
ink,ink-table,ink-text-input,@types/ink) andyoga-layout, eliminating dead dependency entries that were causing CI failures during yoga asset download.Reviewed by Cursor Bugbot for commit 70897b1. Configure here.