fix(ci): use env vars instead of template expressions in run blocks (zizmor) (#138)

Author: jdalton

.github/workflows/weekly-update.yml

@@ -220,15 +220,16 @@ jobs:
       - name: Set final status
         id: final
         if: always()
+        env:
+          UPDATE_SUCCESS: ${{ steps.update.outputs.success }}
+          TESTS_PASSED: ${{ steps.tests.outputs.tests-passed }}
+          FIX_SUCCESS: ${{ steps.claude.outputs.success }}
         run: |
-          # Success if: update succeeded AND (tests passed OR fix succeeded)
-          if [ "${{ steps.update.outputs.success }}" = "true" ]; then
-            if [ "${{ steps.tests.outputs.tests-passed }}" = "true" ] || [ "${{ steps.claude.outputs.success }}" = "true" ]; then
-              echo "success=true" >> $GITHUB_OUTPUT
-              exit 0
-            fi
+          if [ "$UPDATE_SUCCESS" = "true" ] && { [ "$TESTS_PASSED" = "true" ] || [ "$FIX_SUCCESS" = "true" ]; }; then
+            echo "success=true" >> $GITHUB_OUTPUT
+          else
+            echo "success=false" >> $GITHUB_OUTPUT
           fi
-          echo "success=false" >> $GITHUB_OUTPUT
 
       - name: Validate changes
         id: validate