Skip to content

Commit 204f271

Browse files
committed
fix(spinner): remove .js extensions from dynamic requires
Changed require('./logger.js') to require('./logger') and require('./debug.js') to require('./debug') to fix test failures. The .js extensions work in compiled output but fail when vitest runs TypeScript source directly. Node.js module resolution automatically adds the correct extension (.ts in source, .js in compiled output) when no extension is specified. This fixes CI test failures where tests couldn't find modules: - Error: Cannot find module './logger.js' Fixes test failures in #14
1 parent 3dce201 commit 204f271

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

src/spinner.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,7 @@ export function Spinner(options?: SpinnerOptions | undefined): Spinner {
669669
getDefaultLogger,
670670
incLogCallCountSymbol,
671671
lastWasBlankSymbol,
672-
} = /*@__PURE__*/ require('./logger.js')
672+
} = /*@__PURE__*/ require('./logger')
673673
const logger = getDefaultLogger()
674674
if (methodName === 'stop') {
675675
if (wasSpinning && normalized) {
@@ -748,7 +748,7 @@ export function Spinner(options?: SpinnerOptions | undefined): Spinner {
748748
const {
749749
LOG_SYMBOLS,
750750
getDefaultLogger,
751-
} = /*@__PURE__*/ require('./logger.js')
751+
} = /*@__PURE__*/ require('./logger')
752752
// Note: Status messages always go to stderr.
753753
const logger = getDefaultLogger()
754754
logger.error(`${LOG_SYMBOLS[symbolType]} ${text}`, ...extras)
@@ -775,7 +775,7 @@ export function Spinner(options?: SpinnerOptions | undefined): Spinner {
775775
* @returns This spinner for chaining
776776
*/
777777
debug(text?: string | undefined, ...extras: unknown[]) {
778-
const { isDebug } = /*@__PURE__*/ require('./debug.js')
778+
const { isDebug } = /*@__PURE__*/ require('./debug')
779779
if (isDebug()) {
780780
return this.#showStatusAndKeepSpinning('info', [text, ...extras])
781781
}
@@ -792,7 +792,7 @@ export function Spinner(options?: SpinnerOptions | undefined): Spinner {
792792
* @returns This spinner for chaining
793793
*/
794794
debugAndStop(text?: string | undefined, ...extras: unknown[]) {
795-
const { isDebug } = /*@__PURE__*/ require('./debug.js')
795+
const { isDebug } = /*@__PURE__*/ require('./debug')
796796
if (isDebug()) {
797797
return this.#apply('info', [text, ...extras])
798798
}
@@ -939,7 +939,7 @@ export function Spinner(options?: SpinnerOptions | undefined): Spinner {
939939
* @returns This spinner for chaining
940940
*/
941941
log(...args: unknown[]) {
942-
const { getDefaultLogger } = /*@__PURE__*/ require('./logger.js')
942+
const { getDefaultLogger } = /*@__PURE__*/ require('./logger')
943943
const logger = getDefaultLogger()
944944
logger.log(...args)
945945
return this
@@ -1068,7 +1068,7 @@ export function Spinner(options?: SpinnerOptions | undefined): Spinner {
10681068
* ```
10691069
*/
10701070
step(text?: string | undefined, ...extras: unknown[]) {
1071-
const { getDefaultLogger } = /*@__PURE__*/ require('./logger.js')
1071+
const { getDefaultLogger } = /*@__PURE__*/ require('./logger')
10721072
if (typeof text === 'string') {
10731073
const logger = getDefaultLogger()
10741074
// Add blank line before step for visual separation.
@@ -1098,7 +1098,7 @@ export function Spinner(options?: SpinnerOptions | undefined): Spinner {
10981098
substep(text?: string | undefined, ...extras: unknown[]) {
10991099
if (typeof text === 'string') {
11001100
// Add 2-space indent for substep.
1101-
const { getDefaultLogger } = /*@__PURE__*/ require('./logger.js')
1101+
const { getDefaultLogger } = /*@__PURE__*/ require('./logger')
11021102
const logger = getDefaultLogger()
11031103
// Use error (stderr) to align with logger.substep() default stream.
11041104
logger.error(` ${text}`, ...extras)

0 commit comments

Comments
 (0)