test: drop vacuous assertions across types, zod, logger-default, signal-exit

- types.test.mts: drop tautological PURL_Type toBeDefined
- zod.test.mts: drop tautological z toBeDefined and typeof function checks (real behavior tests remain)
- logger-default.test.mts: drop log toBeDefined (typeof function checks suffice for dynamic methods)
- signal-exit.test.mts: drop redundant if (sigs) guards after toBeTruthy assertion

Author: jdalton

test/unit/logger-default.test.mts

@@ -13,9 +13,9 @@ import { getDefaultLogger } from '@socketsecurity/lib/logger'
 import { describe, expect, it } from 'vitest'
 
 describe('getDefaultLogger', () => {
-  it('should return a Logger instance', () => {
+  it('should return a Logger with dynamic log methods', () => {
     const log = getDefaultLogger()
-    expect(log).toBeDefined()
+    // Logger methods are installed dynamically; verify core methods exist.
     expect(typeof log.log).toBe('function')
     expect(typeof log.success).toBe('function')
     expect(typeof log.error).toBe('function')

test/unit/signal-exit.test.mts

@@ -91,18 +91,16 @@ describe('signal-exit', () => {
       load()
       const sigs = signals()
       expect(sigs).toBeTruthy()
-      if (sigs) {
-        // Common signals across platforms
-        expect(sigs).toContain('SIGINT')
-        expect(sigs).toContain('SIGTERM')
-      }
+      // Common signals across platforms
+      expect(sigs).toContain('SIGINT')
+      expect(sigs).toContain('SIGTERM')
     })
 
     it('should have platform-specific signals', () => {
       load()
       const sigs = signals()
       expect(sigs).toBeTruthy()
-      if (sigs && process.platform !== 'win32') {
+      if (process.platform !== 'win32') {
         // POSIX-only signals
         expect(sigs.length).toBeGreaterThan(5)
       }
@@ -246,7 +244,7 @@ describe('signal-exit', () => {
       load()
       const sigs = signals()
       expect(sigs).toBeTruthy()
-      if (process.platform === 'win32' && sigs) {
+      if (process.platform === 'win32') {
         // Windows should have fewer signals
         expect(sigs).toContain('SIGINT')
         expect(sigs).toContain('SIGTERM')
@@ -257,7 +255,7 @@ describe('signal-exit', () => {
       load()
       const sigs = signals()
       expect(sigs).toBeTruthy()
-      if (process.platform !== 'win32' && sigs) {
+      if (process.platform !== 'win32') {
         // POSIX should have more signals
         expect(sigs.length).toBeGreaterThan(5)
         expect(sigs).toContain('SIGINT')
@@ -270,7 +268,7 @@ describe('signal-exit', () => {
       load()
       const sigs = signals()
       expect(sigs).toBeTruthy()
-      if (process.platform === 'linux' && sigs) {
+      if (process.platform === 'linux') {
         // Linux-specific signals
         expect(sigs).toContain('SIGIO')
         expect(sigs).toContain('SIGPOLL')

test/unit/types.test.mts

@@ -8,10 +8,6 @@ import { PURL_Type } from '@socketsecurity/lib/types'
 
 describe('types', () => {
   describe('PURL_Type enum', () => {
-    it('should export PURL_Type enum', () => {
-      expect(PURL_Type).toBeDefined()
-    })
-
     it('should have NPM type', () => {
       expect(PURL_Type.NPM).toBe('npm')
     })

test/unit/zod.test.mts

@@ -16,31 +16,22 @@ import { z } from '@socketsecurity/lib/zod'
 
 describe('zod', () => {
   describe('z export', () => {
-    it('should export z object', () => {
-      expect(z).toBeDefined()
-      expect(typeof z).toBe('object')
-    })
-
     it('should export string schema builder', () => {
-      expect(typeof z.string).toBe('function')
       const schema = z.string()
       expect(schema.parse('test')).toBe('test')
     })
 
     it('should export number schema builder', () => {
-      expect(typeof z.number).toBe('function')
       const schema = z.number()
       expect(schema.parse(123)).toBe(123)
     })
 
     it('should export boolean schema builder', () => {
-      expect(typeof z.boolean).toBe('function')
       const schema = z.boolean()
       expect(schema.parse(true)).toBe(true)
     })
 
     it('should export object schema builder', () => {
-      expect(typeof z.object).toBe('function')
       const schema = z.object({
         name: z.string(),
         age: z.number(),
@@ -52,7 +43,6 @@ describe('zod', () => {
     })
 
     it('should export array schema builder', () => {
-      expect(typeof z.array).toBe('function')
       const schema = z.array(z.string())
       expect(schema.parse(['a', 'b', 'c'])).toEqual(['a', 'b', 'c'])
     })