fix: resolve all lint and type errors, enable strict TypeScript

- Convert non-const enums to `as const` objects in src/types.ts
- Re-enable erasableSyntaxOnly: true in tsconfig.base.json
- Remove strict: false override from tsconfig.check.json
- Fix 91 type errors across 24 source files
- Fix 401 type errors across 43 test files
- Fix 17 oxlint errors (no-import-assign, no-new-array) in test files
- Fix pico-pack.d.ts glob type reference

Author: jdalton

.config/tsconfig.base.json

@@ -5,7 +5,7 @@
     "composite": false,
     "declaration": false,
     "declarationMap": false,
-    "erasableSyntaxOnly": false,
+    "erasableSyntaxOnly": true,
     "esModuleInterop": true,
     "exactOptionalPropertyTypes": true,
     "forceConsistentCasingInFileNames": true,

.config/tsconfig.check.json

@@ -4,9 +4,7 @@
     "noEmit": true,
     "rootDir": "..",
     "types": ["node", "vitest"],
-    "skipLibCheck": true,
-    "strict": false,
-    "noImplicitAny": false
+    "skipLibCheck": true
   },
   "include": ["../src/**/*.ts", "../test/**/*.ts", "../test/**/*.mts"],
   "exclude": ["../node_modules", "../dist/**/*"]

src/archives.ts

@@ -42,7 +42,7 @@ let _path: typeof import('node:path') | undefined
 /*@__NO_SIDE_EFFECTS__*/
 function getPath() {
   if (_path === undefined) {
-    _path = /*@__PURE__*/ require('path')
+    _path = /*@__PURE__*/ require('node:path')
   }
   return _path as typeof import('node:path')
 }
@@ -57,15 +57,15 @@ export type ArchiveFormat = 'tar' | 'tar.gz' | 'tgz' | 'zip'
  */
 export interface ExtractOptions {
   /** Suppress log messages */
-  quiet?: boolean
+  quiet?: boolean | undefined
   /** Strip leading path components (like tar --strip-components) */
-  strip?: number
+  strip?: number | undefined
   /** Maximum number of entries to extract (default: 100,000) */
-  maxEntries?: number
+  maxEntries?: number | undefined
   /** Maximum size of a single extracted file in bytes (default: 100MB) */
-  maxFileSize?: number
+  maxFileSize?: number | undefined
   /** Maximum total extracted size in bytes (default: 1GB) */
-  maxTotalSize?: number
+  maxTotalSize?: number | undefined
 }
 
 /**

src/bin.ts

@@ -34,7 +34,7 @@ function getFs() {
   if (_fs === undefined) {
     // Use non-'node:' prefixed require to avoid Webpack errors.
 
-    _fs = /*@__PURE__*/ require('fs')
+    _fs = /*@__PURE__*/ require('node:fs')
   }
   return _fs as typeof import('node:fs')
 }
@@ -52,7 +52,7 @@ function getPath() {
   if (_path === undefined) {
     // Use non-'node:' prefixed require to avoid Webpack errors.
 
-    _path = /*@__PURE__*/ require('path')
+    _path = /*@__PURE__*/ require('node:path')
   }
   return _path as typeof import('node:path')
 }
@@ -806,7 +806,10 @@ export async function whichReal(
   // Depending on options `whichModule` may throw if `binName` is not found.
   // With nothrow: true, it returns null when `binName` is not found.
   /* c8 ignore next - External which call */
-  const result = await whichModule(binName, opts)
+  const result = await whichModule(
+    binName,
+    opts as import('./external/which').WhichOptions,
+  )
 
   // When 'all: true' is specified, ensure we always return an array.
   if (opts?.all) {

src/constants/agents.ts

@@ -34,8 +34,8 @@ export const NPM_REAL_EXEC_PATH = /*@__PURE__*/ (() => {
     if (!_npmBinPath) {
       return undefined
     }
-    const { existsSync } = /*@__PURE__*/ require('fs')
-    const path = /*@__PURE__*/ require('path')
+    const { existsSync } = /*@__PURE__*/ require('node:fs')
+    const path = /*@__PURE__*/ require('node:path')
     // npm bin is typically at: /path/to/node/bin/npm
     // cli.js is at: /path/to/node/lib/node_modules/npm/lib/cli.js
     // /path/to/node/bin

src/constants/package-default-node-range.ts

@@ -6,6 +6,6 @@ import { maintainedNodeVersions } from './maintained-node-versions'
 import * as semver from '../external/semver.js'
 
 /* c8 ignore next - External semver call */
-const packageDefaultNodeRange = `>=${semver.parse(maintainedNodeVersions.last).major}`
+const packageDefaultNodeRange = `>=${semver.parse(maintainedNodeVersions.last)!.major}`
 
 export { packageDefaultNodeRange }

src/constants/platform.ts

@@ -12,7 +12,7 @@ function getOs() {
   if (_os === undefined) {
     // Use non-'node:' prefixed require to avoid Webpack errors.
 
-    _os = /*@__PURE__*/ require('os')
+    _os = /*@__PURE__*/ require('node:os')
   }
   return _os as typeof import('node:os')
 }

src/cover/code.ts

@@ -26,7 +26,7 @@ function getFs() {
   if (_fs === undefined) {
     // Use non-'node:' prefixed require to avoid Webpack errors.
 
-    _fs = /*@__PURE__*/ require('fs')
+    _fs = /*@__PURE__*/ require('node:fs')
   }
   return _fs as typeof import('node:fs')
 }
@@ -39,7 +39,7 @@ function getPath() {
   if (_path === undefined) {
     // Use non-'node:' prefixed require to avoid Webpack errors.
 
-    _path = /*@__PURE__*/ require('path')
+    _path = /*@__PURE__*/ require('node:path')
   }
   return _path as typeof import('node:path')
 }

src/debug.ts

@@ -74,7 +74,7 @@ function getUtil() {
   if (_util === undefined) {
     // Use non-'node:' prefixed require to avoid Webpack errors.
 
-    _util = /*@__PURE__*/ require('util')
+    _util = /*@__PURE__*/ require('node:util')
   }
   return _util as typeof import('node:util')
 }

src/dlx/binary.ts

@@ -27,7 +27,7 @@ function getCrypto() {
   if (_crypto === undefined) {
     // Use non-'node:' prefixed require to avoid Webpack errors.
 
-    _crypto = /*@__PURE__*/ require('crypto')
+    _crypto = /*@__PURE__*/ require('node:crypto')
   }
   return _crypto as typeof import('node:crypto')
 }
@@ -44,7 +44,7 @@ function getFs() {
   if (_fs === undefined) {
     // Use non-'node:' prefixed require to avoid Webpack errors.
 
-    _fs = /*@__PURE__*/ require('fs')
+    _fs = /*@__PURE__*/ require('node:fs')
   }
   return _fs as typeof import('node:fs')
 }
@@ -62,7 +62,7 @@ function getPath() {
   if (_path === undefined) {
     // Use non-'node:' prefixed require to avoid Webpack errors.
 
-    _path = /*@__PURE__*/ require('path')
+    _path = /*@__PURE__*/ require('node:path')
   }
   return _path as typeof import('node:path')
 }