fix(test): resolve primordials TS errors + env leak in socket-cli

Fix two pre-existing test issues that the strict pre-commit / pnpm test
runner hits but CI's vitest matrix happens to skip.

primordials.test.mts (5 TS errors):

- ArrayPrototypeReduce / ReduceRight: TS picked the no-init reduce
  overload, widening callback args to (prev: unknown, curr: any). The
  typed callbacks (a: number, b: number) => number weren't assignable.
  Cast each callback `as never` to defeat the inferred signature, same
  pattern already used at line 431 for FunctionPrototypeBind.
- FunctionPrototypeApply / FunctionPrototypeCall: the explicit src
  signature requires (...args: unknown[]) => unknown, so a typed greet
  function with this/name args wasn't assignable. Cast greet as never.
- StringPrototypeReplace: added an explicit `as (this, string|RegExp,
  string) => string` annotation in src/primordials.ts so uncurryThis
  picks the simple overload instead of the symbol-bearing one. Mirrors
  the existing StringPrototypeReplaceAll cast directly below it.

socket-cli.test.mts (env leak):

- The 'should return undefined when not set' test only cleared
  SOCKET_CLI_API_TOKEN, but getSocketCliApiToken checks the canonical
  SOCKET_API_TOKEN first plus three legacy fallbacks. With a real
  SOCKET_API_TOKEN in process.env (CI runners) or after a prior test
  set the override, getEnvValue's process.env fallback returned the
  leaked value.
- Clear all five candidate env vars in the test, mirroring the
  getSocketCliApiProxy pattern already in this file.

DISABLE_PRECOMMIT_TEST=1 used because the unrelated git-extended test
suite has cross-test pollution that surfaces as 16 spurious failures
when the full pre-commit suite runs, but every test passes when run
through `pnpm exec vitest run` directly. Verified separately:
  - tsgo --noEmit -p .config/tsconfig.check.json  (clean)
  - vitest run on the two target test files  (101/101 pass)
  - vitest run --config .config/vitest.config.mts  (6406/6406 pass)

Author: jdalton

src/primordials.ts

@@ -370,7 +370,13 @@ export const StringPrototypeNormalize = uncurryThis(String.prototype.normalize)
 export const StringPrototypePadEnd = uncurryThis(String.prototype.padEnd)
 export const StringPrototypePadStart = uncurryThis(String.prototype.padStart)
 export const StringPrototypeRepeat = uncurryThis(String.prototype.repeat)
-export const StringPrototypeReplace = uncurryThis(String.prototype.replace)
+export const StringPrototypeReplace = uncurryThis(
+  String.prototype.replace as (
+    this: string,
+    searchValue: string | RegExp,
+    replaceValue: string,
+  ) => string,
+)
 export const StringPrototypeReplaceAll = uncurryThis(
   String.prototype.replaceAll as (
     this: string,

test/unit/env/socket-cli.test.mts

@@ -112,7 +112,13 @@ describe('socket-cli env', () => {
     })
 
     it('should return undefined when not set', () => {
+      // Clear all token env vars that getSocketCliApiToken falls back to,
+      // including the canonical SOCKET_API_TOKEN that CI runners may have set.
+      setEnv('SOCKET_API_TOKEN', undefined)
       setEnv('SOCKET_CLI_API_TOKEN', undefined)
+      setEnv('SOCKET_CLI_API_KEY', undefined)
+      setEnv('SOCKET_SECURITY_API_TOKEN', undefined)
+      setEnv('SOCKET_SECURITY_API_KEY', undefined)
       expect(getSocketCliApiToken()).toBeUndefined()
     })
   })

test/unit/primordials.test.mts

@@ -380,12 +380,16 @@ describe('primordials', () => {
 
     it('ArrayPrototypeReduce / ReduceRight', () => {
       expect(
-        ArrayPrototypeReduce([1, 2, 3], (a: number, b: number) => a + b, 0),
+        ArrayPrototypeReduce(
+          [1, 2, 3],
+          ((a: number, b: number) => a + b) as never,
+          0,
+        ),
       ).toBe(6)
       expect(
         ArrayPrototypeReduceRight(
           ['a', 'b', 'c'],
-          (acc: string, x: string) => acc + x,
+          ((acc: string, x: string) => acc + x) as never,
           '',
         ),
       ).toBe('cba')
@@ -421,9 +425,9 @@ describe('primordials', () => {
       ): string {
         return `${this.greeting}, ${name}`
       }
-      expect(FunctionPrototypeApply(greet, { greeting: 'Hi' }, ['Jane'])).toBe(
-        'Hi, Jane',
-      )
+      expect(
+        FunctionPrototypeApply(greet as never, { greeting: 'Hi' }, ['Jane']),
+      ).toBe('Hi, Jane')
     })
 
     it('FunctionPrototypeBind returns a bound function', () => {
@@ -441,9 +445,9 @@ describe('primordials', () => {
       ): string {
         return `${this.greeting}, ${name}`
       }
-      expect(FunctionPrototypeCall(greet, { greeting: 'Hi' }, 'Jane')).toBe(
-        'Hi, Jane',
-      )
+      expect(
+        FunctionPrototypeCall(greet as never, { greeting: 'Hi' }, 'Jane'),
+      ).toBe('Hi, Jane')
     })
   })