Skip to content

Commit a091ccf

Browse files
committed
refactor(dlx): remove unused call option and improve test isolation
Remove call option: - Removed call option from DlxPackageOptions interface (not yet implemented) - Only keep implemented options: yes, quiet, force - Follows "don't add it if it's not used" principle Improve test isolation: - Refactored dlx-package tests to use runWithTempDir helper - Each test now runs in its own isolated temporary directory - Eliminates shared state and potential race conditions - Aligns with dlx-binary test patterns for consistency - Better support for parallel test execution Benefits: - Cleaner API surface (no unused options) - More reliable tests with proper isolation - Consistent test patterns across dlx modules - Prevents flaky tests from shared temp directory usage
1 parent 4f76ebe commit a091ccf

2 files changed

Lines changed: 437 additions & 448 deletions

File tree

src/dlx-package.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -138,12 +138,6 @@ export interface DlxPackageOptions {
138138
*/
139139
quiet?: boolean | undefined
140140

141-
/**
142-
* Shell command to execute in package context.
143-
* Aligns with npx --call flag.
144-
*/
145-
call?: string | undefined
146-
147141
/**
148142
* Additional spawn options for the execution.
149143
*/

0 commit comments

Comments
 (0)