refactor(scripts): prefer undefined over null for absent values

Author: jdalton

scripts/build-externals/esbuild-config.mjs

@@ -108,10 +108,10 @@ function createForceNodeModulesPlugin() {
               }
             } catch {
               // Package not found, let esbuild handle the error
-              return null
+              return undefined
             }
           }
-          return null
+          return undefined
         })
       }
     },

scripts/build-externals/local-packages.mjs

@@ -51,7 +51,7 @@ export async function getLocalPackagePath(packageName, rootDir) {
     }
   }
 
-  return null
+  return undefined
 }
 
 /**

scripts/claude.mjs

@@ -352,7 +352,7 @@ class ProgressTracker {
       s.phases.some(p => p.name === phaseName),
     )
     if (similar.length === 0) {
-      return null
+      return undefined
     }
 
     // Get median duration for this phase.
@@ -362,7 +362,7 @@ class ProgressTracker {
       .sort((a, b) => a - b)
 
     if (durations.length === 0) {
-      return null
+      return undefined
     }
 
     const median = durations[Math.floor(durations.length / 2)]
@@ -758,14 +758,14 @@ ${similarErrors.length > 0 ? `**Similar Past Errors:**\n${similarErrors.map(e =>
 
     if (result.exitCode !== 0) {
       log.warn('Analysis failed, proceeding without root cause info')
-      return null
+      return undefined
     }
 
     // Parse JSON response.
     const jsonMatch = result.stdout.match(/\{[\s\S]*\}/)
     if (!jsonMatch) {
       log.warn('Could not parse analysis, proceeding without root cause info')
-      return null
+      return undefined
     }
 
     const analysis = JSON.parse(jsonMatch[0])
@@ -791,7 +791,7 @@ ${similarErrors.length > 0 ? `**Similar Past Errors:**\n${similarErrors.map(e =>
     return analysis
   } catch (e) {
     log.warn(`Analysis error: ${e.message}`)
-    return null
+    return undefined
   }
 }
 
@@ -2568,7 +2568,7 @@ Provide ONLY the JSON array, nothing else.`
 
   if (result.exitCode !== 0) {
     log.failed(`Failed to scan ${name}`)
-    return null
+    return undefined
   }
 
   log.done(`Scanned ${name}`)
@@ -2577,7 +2577,7 @@ Provide ONLY the JSON array, nothing else.`
     return JSON.parse(result.stdout.trim())
   } catch {
     log.warn(`Failed to parse scan results for ${name}`)
-    return null
+    return undefined
   }
 }
 
@@ -2846,7 +2846,7 @@ async function runSecurityScan(claudeCmd, options = {}) {
     const tasks = projects.map(project =>
       scanProjectForIssues(claudeCmd, project, options)
         .then(issues => ({ project: project.name, issues }))
-        .catch(error => ({ project: project.name, issues: null, error })),
+        .catch(error => ({ project: project.name, issues: undefined, error })),
     )
 
     const taskNames = projects.map(p => p.name)

scripts/lint.mjs

@@ -330,20 +330,20 @@ async function getFilesToLint(options) {
     mode = 'staged'
     changedFiles = getStagedFilesSync({ absolute: false })
     if (!changedFiles.length) {
-      return { files: null, reason: 'no staged files', mode }
+      return { files: undefined, reason: 'no staged files', mode }
     }
   } else if (changed) {
     mode = 'changed'
     changedFiles = getChangedFilesSync({ absolute: false })
     if (!changedFiles.length) {
-      return { files: null, reason: 'no changed files', mode }
+      return { files: undefined, reason: 'no changed files', mode }
     }
   } else {
     // Default to changed files if no specific flag
     mode = 'changed'
     changedFiles = getChangedFilesSync({ absolute: false })
     if (!changedFiles.length) {
-      return { files: null, reason: 'no changed files', mode }
+      return { files: undefined, reason: 'no changed files', mode }
     }
   }
 
@@ -356,10 +356,10 @@ async function getFilesToLint(options) {
   // Filter to lintable files
   const lintableFiles = filterLintableFiles(changedFiles)
   if (!lintableFiles.length) {
-    return { files: null, reason: 'no lintable files changed', mode }
+    return { files: undefined, reason: 'no lintable files changed', mode }
   }
 
-  return { files: lintableFiles, reason: null, mode }
+  return { files: lintableFiles, reason: undefined, mode }
 }
 
 async function main() {
@@ -444,7 +444,7 @@ async function main() {
       // Get files to lint based on flags
       const { files, mode, reason } = await getFilesToLint(values)
 
-      if (files === null) {
+      if (files === undefined) {
         if (!quiet) {
           logger.step('Skipping lint')
           logger.substep(reason)

scripts/utils/changed-test-mapper.mjs

@@ -103,7 +103,7 @@ export function getTestsToRun(options = {}) {
 
   if (changedFiles.length === 0) {
     // No changes, skip tests
-    return { tests: null, mode }
+    return { tests: undefined, mode }
   }
 
   const testFiles = new Set()
@@ -169,7 +169,7 @@ export function getTestsToRun(options = {}) {
   }
 
   if (testFiles.size === 0) {
-    return { tests: null, mode }
+    return { tests: undefined, mode }
   }
 
   return { tests: Array.from(testFiles), mode }

scripts/validate/file-count.mjs

@@ -38,7 +38,7 @@ async function validateStagedFileCount() {
 
     // Not a git repository
     if (!gitRoot.trim()) {
-      return null
+      return undefined
     }
 
     // Get list of staged files
@@ -59,10 +59,10 @@ async function validateStagedFileCount() {
       }
     }
 
-    return null
+    return undefined
   } catch {
     // Not a git repo or git not available
-    return null
+    return undefined
   }
 }
 

scripts/validate/markdown-filenames.mjs

@@ -168,7 +168,7 @@ function validateFilename(filePath) {
   // README.md and LICENSE are special - allowed anywhere
   // Valid - allowed in any location
   if (nameWithoutExt === 'README' || nameWithoutExt === 'LICENSE') {
-    return null
+    return undefined
   }
 
   // Check if it's an allowed SCREAMING_CASE file
@@ -183,7 +183,7 @@ function validateFilename(filePath) {
       }
     }
     // Valid
-    return null
+    return undefined
   }
 
   // Check if it's in SCREAMING_CASE but not allowed
@@ -234,7 +234,7 @@ function validateFilename(filePath) {
   }
 
   // Valid
-  return null
+  return undefined
 }
 
 /**