refactor(scripts): standardize logger method usage in validation scripts

jdalton · jdalton · commit adeee8684376 · 2025-11-11T08:50:10.000-08:00
Replace inconsistent .error() usage with proper .fail() and .log() methods
across all validation scripts for consistent user-facing output.

Pattern standardized:
- .fail() for validation failure headers
- .log() for detail/informational lines
- .error() reserved for actual exceptions only

Affects all validation scripts:
- markdown-filenames.mjs
- file-count.mjs
- file-size.mjs
- no-link-deps.mjs
- dist-exports.mjs
- esbuild-minify.mjs
- esm-named-exports.mjs
- external-esm-cjs.mjs
- external-exports.mjs
- no-extraneous-dependencies.mjs
- no-cdn-refs.mjs
diff --git a/scripts/validate/dist-exports.mjs b/scripts/validate/dist-exports.mjs
@@ -102,12 +102,12 @@ async function main() {
 
   if (failures.length > 0) {
     if (!quiet) {
-      logger.error(
+      logger.fail(
         `Found ${failures.length} public ${pluralize('export', { count: failures.length })} with incorrect exports:`,
       )
       for (const failure of failures) {
         const relativePath = path.relative(distDir, failure.path)
-        logger.error(`  ${relativePath}`)
+        logger.log(`  ${relativePath}`)
         logger.substep(failure.reason)
       }
     }
@@ -122,6 +122,6 @@ async function main() {
 }
 
 main().catch(error => {
-  logger.error(`Validation failed: ${error.message}`)
+  logger.fail(`Validation failed: ${error.message}`)
   process.exitCode = 1
 })
diff --git a/scripts/validate/esbuild-minify.mjs b/scripts/validate/esbuild-minify.mjs
@@ -50,7 +50,7 @@ async function validateEsbuildMinify() {
 
     return violations
   } catch (error) {
-    logger.error(`Failed to load esbuild config: ${error.message}`)
+    logger.fail(`Failed to load esbuild config: ${error.message}`)
     process.exitCode = 1
     return []
   }
@@ -65,25 +65,23 @@ async function main() {
     return
   }
 
-  logger.error('esbuild minify validation failed\n')
+  logger.fail('esbuild minify validation failed\n')
 
   for (const violation of violations) {
-    logger.error(`  ${violation.message}`)
-    logger.error(`  Found: minify: ${violation.value}`)
-    logger.error('  Expected: minify: false')
-    logger.error(`  Location: ${violation.location}`)
-    logger.error('')
+    logger.log(`  ${violation.message}`)
+    logger.log(`  Found: minify: ${violation.value}`)
+    logger.log('  Expected: minify: false')
+    logger.log(`  Location: ${violation.location}`)
+    logger.log('')
   }
 
-  logger.error(
-    'Minification breaks ESM/CJS interop and makes debugging harder.',
-  )
-  logger.error('')
+  logger.log('Minification breaks ESM/CJS interop and makes debugging harder.')
+  logger.log('')
 
   process.exitCode = 1
 }
 
 main().catch(error => {
-  logger.error('Validation failed:', error)
+  logger.fail('Validation failed:', error)
   process.exitCode = 1
 })
diff --git a/scripts/validate/esm-named-exports.mjs b/scripts/validate/esm-named-exports.mjs
@@ -155,12 +155,12 @@ async function main() {
 
   if (failures.length > 0) {
     if (!quiet) {
-      logger.error(
+      logger.fail(
         `Found ${failures.length} ${pluralize('file', { count: failures.length })} without ESM-compatible named exports:`,
       )
       for (const failure of failures) {
         const relativePath = path.relative(distDir, failure.path)
-        logger.error(`  ${relativePath}`)
+        logger.log(`  ${relativePath}`)
         logger.substep(failure.reason)
       }
       logger.warn(
@@ -178,6 +178,6 @@ async function main() {
 }
 
 main().catch(error => {
-  logger.error(`Validation failed: ${error.message}`)
+  logger.fail(`Validation failed: ${error.message}`)
   process.exitCode = 1
 })
diff --git a/scripts/validate/external-esm-cjs.mjs b/scripts/validate/external-esm-cjs.mjs
@@ -256,11 +256,11 @@ async function main() {
 
   if (failures.length > 0) {
     if (!quiet) {
-      logger.error(
+      logger.fail(
         `Found ${failures.length} external ${pluralize('module', { count: failures.length })} with ESM/CJS export issues:`,
       )
       for (const failure of failures) {
-        logger.error(`  ${failure.path}`)
+        logger.log(`  ${failure.path}`)
         for (const issue of failure.issues) {
           logger.substep(issue)
         }
@@ -322,7 +322,7 @@ async function main() {
 }
 
 main().catch(error => {
-  logger.error(`Validation failed: ${error.message}`)
+  logger.fail(`Validation failed: ${error.message}`)
   if (!isQuiet() && error.stack) {
     logger.log(error.stack)
   }
diff --git a/scripts/validate/external-exports.mjs b/scripts/validate/external-exports.mjs
@@ -159,11 +159,11 @@ async function main() {
 
   if (failures.length > 0) {
     if (!quiet) {
-      logger.error(
+      logger.fail(
         `Found ${failures.length} external ${pluralize('module', { count: failures.length })} with export issues:`,
       )
       for (const failure of failures) {
-        logger.error(`  ${failure.path}`)
+        logger.log(`  ${failure.path}`)
         logger.substep(failure.reason)
       }
     }
@@ -182,6 +182,6 @@ async function main() {
 }
 
 main().catch(error => {
-  logger.error(`Validation failed: ${error.message}`)
+  logger.fail(`Validation failed: ${error.message}`)
   process.exitCode = 1
 })
diff --git a/scripts/validate/file-count.mjs b/scripts/validate/file-count.mjs
@@ -76,7 +76,7 @@ async function main() {
       return
     }
 
-    logger.error('Too many files staged for commit')
+    logger.fail('Too many files staged for commit')
     logger.log('')
     logger.log(`Staged files: ${violation.count}`)
     logger.log(`Maximum allowed: ${violation.limit}`)
@@ -102,12 +102,12 @@ async function main() {
 
     process.exitCode = 1
   } catch (error) {
-    logger.error(`Validation failed: ${error.message}`)
+    logger.fail(`Validation failed: ${error.message}`)
     process.exitCode = 1
   }
 }
 
 main().catch(error => {
-  logger.error(`Validation failed: ${error}`)
+  logger.fail(`Validation failed: ${error}`)
   process.exitCode = 1
 })
diff --git a/scripts/validate/file-size.mjs b/scripts/validate/file-size.mjs
@@ -117,7 +117,7 @@ async function main() {
       return
     }
 
-    logger.error('File size violations found')
+    logger.fail('File size violations found')
     logger.log('')
     logger.log(`Maximum allowed file size: ${formatBytes(MAX_FILE_SIZE)}`)
     logger.log('')
@@ -140,12 +140,12 @@ async function main() {
 
     process.exitCode = 1
   } catch (error) {
-    logger.error(`Validation failed: ${error.message}`)
+    logger.fail(`Validation failed: ${error.message}`)
     process.exitCode = 1
   }
 }
 
 main().catch(error => {
-  logger.error(`Validation failed: ${error}`)
+  logger.fail(`Validation failed: ${error}`)
   process.exitCode = 1
 })
diff --git a/scripts/validate/markdown-filenames.mjs b/scripts/validate/markdown-filenames.mjs
@@ -264,7 +264,7 @@ async function main() {
       return
     }
 
-    logger.error('Markdown filename violations found')
+    logger.fail('Markdown filename violations found')
     logger.log('')
     logger.log('Special files (allowed anywhere):')
     logger.log('  README.md, LICENSE')
@@ -293,12 +293,12 @@ async function main() {
 
     process.exitCode = 1
   } catch (error) {
-    logger.error(`Validation failed: ${error.message}`)
+    logger.fail(`Validation failed: ${error.message}`)
     process.exitCode = 1
   }
 }
 
 main().catch(error => {
-  logger.error(`Validation failed: ${error}`)
+  logger.fail(`Validation failed: ${error}`)
   process.exitCode = 1
 })
diff --git a/scripts/validate/no-extraneous-dependencies.mjs b/scripts/validate/no-extraneous-dependencies.mjs
@@ -288,39 +288,39 @@ async function main() {
       return
     }
 
-    logger.error('Found extraneous or missing dependencies:\n')
+    logger.fail('Found extraneous or missing dependencies:\n')
 
     for (const error of errors) {
       if (error.type === 'missing-dependency') {
-        logger.error(
+        logger.log(
           `  ${error.file}:${error.line}:${error.column} - ${error.message}`,
         )
-        logger.error(`    require('${error.specifier}')`)
+        logger.log(`    require('${error.specifier}')`)
         if (
           error.message.includes('is in devDependencies but required in dist/')
         ) {
-          logger.error(
+          logger.log(
             `    Fix: Move "${error.packageName}" to dependencies OR bundle it (add to esbuild external exclusion)\n`,
           )
         } else {
-          logger.error(
+          logger.log(
             `    Fix: Add "${error.packageName}" to dependencies or peerDependencies\n`,
           )
         }
       } else if (error.type === 'missing-file') {
-        logger.error(
+        logger.log(
           `  ${error.file}:${error.line}:${error.column} - ${error.message}`,
         )
-        logger.error(`    require('${error.specifier}')`)
-        logger.error('    Fix: Create the missing file or fix the path\n')
+        logger.log(`    require('${error.specifier}')`)
+        logger.log('    Fix: Create the missing file or fix the path\n')
       } else if (error.type === 'parse-error') {
-        logger.error(`  ${error.file} - ${error.message}\n`)
+        logger.log(`  ${error.file} - ${error.message}\n`)
       }
     }
 
     process.exitCode = 1
   } catch (error) {
-    logger.error('Validation failed:', error.message)
+    logger.fail('Validation failed:', error.message)
     process.exitCode = 1
   }
 }
diff --git a/scripts/validate/no-link-deps.mjs b/scripts/validate/no-link-deps.mjs
@@ -121,26 +121,26 @@ async function main() {
   }
 
   if (allViolations.length > 0) {
-    logger.error('Found link: dependencies (prohibited)')
-    logger.error('')
-    logger.error(
+    logger.fail('Found link: dependencies (prohibited)')
+    logger.log('')
+    logger.log(
       'Use workspace: protocol for monorepo packages or catalog: for centralized versions.',
     )
-    logger.error('')
+    logger.log('')
 
     for (const violation of allViolations) {
       const relativePath = path.relative(rootPath, violation.file)
-      logger.error(`  ${relativePath}`)
-      logger.error(
+      logger.log(`  ${relativePath}`)
+      logger.log(
         `    ${violation.field}.${violation.package}: "${violation.value}"`,
       )
     }
 
-    logger.error('')
-    logger.error('Replace link: with:')
-    logger.error('  - workspace: for monorepo packages')
-    logger.error('  - catalog: for centralized version management')
-    logger.error('')
+    logger.log('')
+    logger.log('Replace link: with:')
+    logger.log('  - workspace: for monorepo packages')
+    logger.log('  - catalog: for centralized version management')
+    logger.log('')
 
     process.exitCode = 1
   } else {
@@ -149,6 +149,6 @@ async function main() {
 }
 
 main().catch(error => {
-  logger.error('Validation failed:', error)
+  logger.fail('Validation failed:', error)
   process.exitCode = 1
 })

Original file line number	Diff line number	Diff line change
`@@ -102,12 +102,12 @@ async function main() {`
`102`	`102`
`103`	`103`	`if (failures.length > 0) {`
`104`	`104`	`if (!quiet) {`
`105`		`- logger.error(`
	`105`	`+ logger.fail(`
`106`	`106`	`Found ${failures.length} public ${pluralize('export', { count: failures.length })} with incorrect exports:`,
`107`	`107`	`)`
`108`	`108`	`for (const failure of failures) {`
`109`	`109`	`const relativePath = path.relative(distDir, failure.path)`
`110`		- logger.error(` ${relativePath}`)
	`110`	+ logger.log(` ${relativePath}`)
`111`	`111`	`logger.substep(failure.reason)`
`112`	`112`	`}`
`113`	`113`	`}`
`@@ -122,6 +122,6 @@ async function main() {`
`122`	`122`	`}`
`123`	`123`
`124`	`124`	`main().catch(error => {`
`125`		- logger.error(`Validation failed: ${error.message}`)
	`125`	+ logger.fail(`Validation failed: ${error.message}`)
`126`	`126`	`process.exitCode = 1`
`127`	`127`	`})`
Original file line number	Diff line number	Diff line change
`@@ -256,11 +256,11 @@ async function main() {`
`256`	`256`
`257`	`257`	`if (failures.length > 0) {`
`258`	`258`	`if (!quiet) {`
`259`		`- logger.error(`
	`259`	`+ logger.fail(`
`260`	`260`	`Found ${failures.length} external ${pluralize('module', { count: failures.length })} with ESM/CJS export issues:`,
`261`	`261`	`)`
`262`	`262`	`for (const failure of failures) {`
`263`		- logger.error(` ${failure.path}`)
	`263`	+ logger.log(` ${failure.path}`)
`264`	`264`	`for (const issue of failure.issues) {`
`265`	`265`	`logger.substep(issue)`
`266`	`266`	`}`
`@@ -322,7 +322,7 @@ async function main() {`
`322`	`322`	`}`
`323`	`323`
`324`	`324`	`main().catch(error => {`
`325`		- logger.error(`Validation failed: ${error.message}`)
	`325`	+ logger.fail(`Validation failed: ${error.message}`)
`326`	`326`	`if (!isQuiet() && error.stack) {`
`327`	`327`	`logger.log(error.stack)`
`328`	`328`	`}`
Original file line number	Diff line number	Diff line change
`@@ -159,11 +159,11 @@ async function main() {`
`159`	`159`
`160`	`160`	`if (failures.length > 0) {`
`161`	`161`	`if (!quiet) {`
`162`		`- logger.error(`
	`162`	`+ logger.fail(`
`163`	`163`	`Found ${failures.length} external ${pluralize('module', { count: failures.length })} with export issues:`,
`164`	`164`	`)`
`165`	`165`	`for (const failure of failures) {`
`166`		- logger.error(` ${failure.path}`)
	`166`	+ logger.log(` ${failure.path}`)
`167`	`167`	`logger.substep(failure.reason)`
`168`	`168`	`}`
`169`	`169`	`}`
`@@ -182,6 +182,6 @@ async function main() {`
`182`	`182`	`}`
`183`	`183`
`184`	`184`	`main().catch(error => {`
`185`		- logger.error(`Validation failed: ${error.message}`)
	`185`	+ logger.fail(`Validation failed: ${error.message}`)
`186`	`186`	`process.exitCode = 1`
`187`	`187`	`})`
Original file line number	Diff line number	Diff line change
`@@ -288,39 +288,39 @@ async function main() {`
`288`	`288`	`return`
`289`	`289`	`}`
`290`	`290`
`291`		`- logger.error('Found extraneous or missing dependencies:\n')`
	`291`	`+ logger.fail('Found extraneous or missing dependencies:\n')`
`292`	`292`
`293`	`293`	`for (const error of errors) {`
`294`	`294`	`if (error.type === 'missing-dependency') {`
`295`		`- logger.error(`
	`295`	`+ logger.log(`
`296`	`296`	` ${error.file}:${error.line}:${error.column} - ${error.message}`,
`297`	`297`	`)`
`298`		- logger.error(` require('${error.specifier}')`)
	`298`	+ logger.log(` require('${error.specifier}')`)
`299`	`299`	`if (`
`300`	`300`	`error.message.includes('is in devDependencies but required in dist/')`
`301`	`301`	`) {`
`302`		`- logger.error(`
	`302`	`+ logger.log(`
`303`	`303`	` Fix: Move "${error.packageName}" to dependencies OR bundle it (add to esbuild external exclusion)\n`,
`304`	`304`	`)`
`305`	`305`	`} else {`
`306`		`- logger.error(`
	`306`	`+ logger.log(`
`307`	`307`	` Fix: Add "${error.packageName}" to dependencies or peerDependencies\n`,
`308`	`308`	`)`
`309`	`309`	`}`
`310`	`310`	`} else if (error.type === 'missing-file') {`
`311`		`- logger.error(`
	`311`	`+ logger.log(`
`312`	`312`	` ${error.file}:${error.line}:${error.column} - ${error.message}`,
`313`	`313`	`)`
`314`		- logger.error(` require('${error.specifier}')`)
`315`		`- logger.error(' Fix: Create the missing file or fix the path\n')`
	`314`	+ logger.log(` require('${error.specifier}')`)
	`315`	`+ logger.log(' Fix: Create the missing file or fix the path\n')`
`316`	`316`	`} else if (error.type === 'parse-error') {`
`317`		- logger.error(` ${error.file} - ${error.message}\n`)
	`317`	+ logger.log(` ${error.file} - ${error.message}\n`)
`318`	`318`	`}`
`319`	`319`	`}`
`320`	`320`
`321`	`321`	`process.exitCode = 1`
`322`	`322`	`} catch (error) {`
`323`		`- logger.error('Validation failed:', error.message)`
	`323`	`+ logger.fail('Validation failed:', error.message)`
`324`	`324`	`process.exitCode = 1`
`325`	`325`	`}`
`326`	`326`	`}`