refactor(constants): remove getNpmLifecycleEvent passthrough

Duplicate of env/npm.ts::getNpmLifecycleEvent. Consumers should import
from the canonical env/npm location.

Author: jdalton

src/constants/packages.ts

@@ -5,14 +5,12 @@
  * package extensions used during manifest processing.
  */
 
-import { getNpmLifecycleEvent as getNpmLifecycleEventEnv } from '../env/npm'
+import pacote from '../external/pacote'
+import { packageExtensions as packageExtensionsImport } from '../package-extensions'
+import { normalizePath } from '../paths/normalize'
 import { lifecycleScriptNames as lifecycleScriptNamesImport } from './lifecycle-script-names'
 import { packageDefaultNodeRange as packageDefaultNodeRangeImport } from './package-default-node-range'
 import { packageDefaultSocketCategories as packageDefaultSocketCategoriesImport } from './package-default-socket-categories'
-import { packageExtensions as packageExtensionsImport } from '../package-extensions'
-
-import pacote from '../external/pacote'
-import { normalizePath } from '../paths/normalize'
 
 let _lifecycleScriptNames: string[]
 let _packageDefaultNodeRange: string | undefined
@@ -46,11 +44,6 @@ export function getLifecycleScriptNames(): string[] {
   return _lifecycleScriptNames
 }
 
-/*@__NO_SIDE_EFFECTS__*/
-export function getNpmLifecycleEvent(): string | undefined {
-  return getNpmLifecycleEventEnv()
-}
-
 /*@__NO_SIDE_EFFECTS__*/
 export function getPackageDefaultNodeRange(): string | undefined {
   if (_packageDefaultNodeRange === undefined) {

test/unit/constants/packages.test.mts

@@ -8,21 +8,20 @@
  * Frozen constants for consistent package operations.
  */
 
-import process from 'node:process'
+import { describe, expect, it } from 'vitest'
+
 import {
   AT_LATEST,
   LATEST,
   PACKAGE,
   PACKAGE_DEFAULT_VERSION,
   getLifecycleScriptNames,
-  getNpmLifecycleEvent,
   getPackageDefaultNodeRange,
   getPackageDefaultSocketCategories,
   getPackageExtensions,
   getPackumentCache,
   getPacoteCachePath,
 } from '@socketsecurity/lib/constants/packages'
-import { describe, expect, it } from 'vitest'
 
 describe('constants/packages', () => {
   describe('package constants', () => {
@@ -124,20 +123,6 @@ describe('constants/packages', () => {
     })
   })
 
-  describe('getNpmLifecycleEvent', () => {
-    it('should return string or undefined', () => {
-      const event = getNpmLifecycleEvent()
-      const type = typeof event
-      expect(type === 'string' || type === 'undefined').toBe(true)
-    })
-
-    it('should match npm_lifecycle_event env var', () => {
-      const event = getNpmLifecycleEvent()
-      const envValue = process.env['npm_lifecycle_event']
-      expect(event).toBe(envValue)
-    })
-  })
-
   describe('getLifecycleScriptNames', () => {
     it('should return array', () => {
       const scripts = getLifecycleScriptNames()
@@ -266,15 +251,6 @@ describe('constants/packages', () => {
       expect(arr.length).toBeGreaterThanOrEqual(0)
     })
 
-    it('should handle undefined npm lifecycle event', () => {
-      const event = getNpmLifecycleEvent()
-      if (event === undefined) {
-        expect(typeof event).toBe('undefined')
-      } else {
-        expect(typeof event).toBe('string')
-      }
-    })
-
     it('should handle empty lifecycle script names', () => {
       const scripts = getLifecycleScriptNames()
       expect(scripts.length).toBeGreaterThanOrEqual(0)