fix(build): add 'use strict' to all CJS files

jdalton · jdalton · commit fc1552bb38a0 · 2025-11-04T09:25:25.000-05:00
- Add 'use strict' banner to esbuild config for dist/*.js files
- Add 'use strict' banner to external bundler config
- Add 'use strict' to all src/external/*.js wrapper files
- Ensures strict mode enforcement across all CommonJS modules
diff --git a/.config/esbuild.config.mjs b/.config/esbuild.config.mjs
@@ -260,7 +260,7 @@ export const buildConfig = {
 
   // Banner for generated code
   banner: {
-    js: '/* Socket Lib - Built with esbuild */',
+    js: '"use strict";\n/* Socket Lib - Built with esbuild */',
   },
 }
 
diff --git a/scripts/build-externals/bundler.mjs b/scripts/build-externals/bundler.mjs
@@ -89,11 +89,14 @@ export async function bundlePackage(packageName, outputPath, options = {}) {
 
     // Add a header comment to the bundled file.
     const bundleContent = await fs.readFile(outputPath, 'utf8')
-    const finalContent = `/**
+    // Strip 'use strict' from bundle content if present (will be re-added at top)
+    const contentWithoutStrict = bundleContent.replace(/^"use strict";\n/, '')
+    const finalContent = `"use strict";
+/**
  * Bundled from ${packageName}
  * This is a zero-dependency bundle created by esbuild.
  */
-${bundleContent}`
+${contentWithoutStrict}`
     await fs.writeFile(outputPath, finalContent)
 
     // Get file size for logging.
diff --git a/scripts/build-externals/esbuild-config.mjs b/scripts/build-externals/esbuild-config.mjs
@@ -174,5 +174,9 @@ export function getEsbuildConfig(entryPoint, outfile, packageOpts = {}) {
       ...packageOpts.define,
     },
     charset: 'utf8',
+    // Banner for generated code
+    banner: {
+      js: '"use strict";',
+    },
   }
 }
diff --git a/src/external/@inquirer/confirm.js b/src/external/@inquirer/confirm.js
@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('@inquirer/confirm')
diff --git a/src/external/@inquirer/input.js b/src/external/@inquirer/input.js
@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('@inquirer/input')
diff --git a/src/external/@inquirer/password.js b/src/external/@inquirer/password.js
@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('@inquirer/password')
diff --git a/src/external/@inquirer/search.js b/src/external/@inquirer/search.js
@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('@inquirer/search')
diff --git a/src/external/@inquirer/select.js b/src/external/@inquirer/select.js
@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('@inquirer/select')
diff --git a/src/external/@npmcli/package-json.js b/src/external/@npmcli/package-json.js
@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('@npmcli/package-json')
diff --git a/src/external/@npmcli/package-json/index.js b/src/external/@npmcli/package-json/index.js
@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('@npmcli/package-json')
diff --git a/src/external/@npmcli/package-json/lib/read-package.js b/src/external/@npmcli/package-json/lib/read-package.js
@@ -1,2 +1,4 @@
+'use strict'
+
 // Entry point for bundling @npmcli/package-json/lib/read-package
 module.exports = require('@npmcli/package-json/lib/read-package.js')
diff --git a/src/external/@npmcli/package-json/lib/sort.js b/src/external/@npmcli/package-json/lib/sort.js
@@ -1,2 +1,4 @@
+'use strict'
+
 // Entry point for bundling @npmcli/package-json/lib/sort
 module.exports = require('@npmcli/package-json/lib/sort.js')
diff --git a/src/external/@npmcli/promise-spawn.js b/src/external/@npmcli/promise-spawn.js
@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('@npmcli/promise-spawn')
diff --git a/src/external/@socketregistry/is-unicode-supported.js b/src/external/@socketregistry/is-unicode-supported.js
@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('@socketregistry/is-unicode-supported/index.cjs')
diff --git a/src/external/@socketregistry/packageurl-js.js b/src/external/@socketregistry/packageurl-js.js
@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('@socketregistry/packageurl-js')
diff --git a/src/external/@socketregistry/yocto-spinner.js b/src/external/@socketregistry/yocto-spinner.js
@@ -1,3 +1,5 @@
+'use strict'
+
 // Re-export the yocto-spinner constructor
 const YoctoSpinner = require('@socketregistry/yocto-spinner')
 module.exports = YoctoSpinner
diff --git a/src/external/@yarnpkg/extensions.js b/src/external/@yarnpkg/extensions.js
@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('@yarnpkg/extensions')
diff --git a/src/external/cacache.js b/src/external/cacache.js
@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('cacache')
diff --git a/src/external/debug.js b/src/external/debug.js
@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('debug')
diff --git a/src/external/del.js b/src/external/del.js
@@ -1,3 +1,5 @@
+'use strict'
+
 // Export only what we use to reduce bundle size
 const { deleteAsync, deleteSync } = require('del')
 
diff --git a/src/external/fast-glob.js b/src/external/fast-glob.js
@@ -1,3 +1,5 @@
+'use strict'
+
 // Export only what we use to reduce bundle size
 const fastGlob = require('fast-glob')
 
diff --git a/src/external/fast-sort.js b/src/external/fast-sort.js
@@ -1,3 +1,5 @@
+'use strict'
+
 // Export only what we use to reduce bundle size
 const { createNewSortInstance } = require('fast-sort')
 
diff --git a/src/external/get-east-asian-width.js b/src/external/get-east-asian-width.js
@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('get-east-asian-width')
diff --git a/src/external/libnpmexec.js b/src/external/libnpmexec.js
@@ -1,3 +1,5 @@
+'use strict'
+
 // Export only what we use from libnpmexec to reduce bundle size
 // libnpmexec provides the npm exec (npx) programmatic API
 
diff --git a/src/external/libnpmpack.js b/src/external/libnpmpack.js
@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('libnpmpack')
diff --git a/src/external/make-fetch-happen.js b/src/external/make-fetch-happen.js
@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('make-fetch-happen')
diff --git a/src/external/normalize-package-data.js b/src/external/normalize-package-data.js
@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('normalize-package-data')
diff --git a/src/external/npm-package-arg.js b/src/external/npm-package-arg.js
@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('npm-package-arg')
diff --git a/src/external/pacote.js b/src/external/pacote.js
@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('pacote')
diff --git a/src/external/picomatch.js b/src/external/picomatch.js
@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('picomatch')
diff --git a/src/external/semver.js b/src/external/semver.js
@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('semver')
diff --git a/src/external/spdx-correct.js b/src/external/spdx-correct.js
@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('spdx-correct')
diff --git a/src/external/spdx-expression-parse.js b/src/external/spdx-expression-parse.js
@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('spdx-expression-parse')
diff --git a/src/external/streaming-iterables.js b/src/external/streaming-iterables.js
@@ -1,3 +1,5 @@
+'use strict'
+
 // Export only what we use to reduce bundle size
 const { parallelMap, transform } = require('streaming-iterables')
 
diff --git a/src/external/validate-npm-package-name.js b/src/external/validate-npm-package-name.js
@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('validate-npm-package-name')
diff --git a/src/external/which.js b/src/external/which.js
@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('which')
diff --git a/src/external/yargs-parser.js b/src/external/yargs-parser.js
@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('yargs-parser')
diff --git a/src/external/yoctocolors-cjs.js b/src/external/yoctocolors-cjs.js
@@ -1,3 +1,5 @@
+'use strict'
+
 const colors = require('yoctocolors-cjs')
 module.exports = colors
 module.exports.default = colors
diff --git a/src/external/zod.js b/src/external/zod.js
@@ -1,2 +1,4 @@
+'use strict'
+
 const { z } = require('zod')
 module.exports = { z }

Original file line number	Diff line number	Diff line change
`@@ -260,7 +260,7 @@ export const buildConfig = {`
`260`	`260`
`261`	`261`	`// Banner for generated code`
`262`	`262`	`banner: {`
`263`		`- js: '/* Socket Lib - Built with esbuild */',`
	`263`	`+ js: '"use strict";\n/* Socket Lib - Built with esbuild */',`
`264`	`264`	`},`
`265`	`265`	`}`
`266`	`266`
Original file line number	Diff line number	Diff line change
`@@ -174,5 +174,9 @@ export function getEsbuildConfig(entryPoint, outfile, packageOpts = {}) {`
`174`	`174`	`...packageOpts.define,`
`175`	`175`	`},`
`176`	`176`	`charset: 'utf8',`
	`177`	`+ // Banner for generated code`
	`178`	`+ banner: {`
	`179`	`+ js: '"use strict";',`
	`180`	`+ },`
`177`	`181`	`}`
`178`	`182`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1 +1,3 @@`
	`1`	`+'use strict'`
	`2`	`+`
`1`	`3`	`module.exports = require('@inquirer/confirm')`
Original file line number	Diff line number	Diff line change
`@@ -1 +1,3 @@`
	`1`	`+'use strict'`
	`2`	`+`
`1`	`3`	`module.exports = require('@inquirer/input')`
Original file line number	Diff line number	Diff line change
`@@ -1 +1,3 @@`
	`1`	`+'use strict'`
	`2`	`+`
`1`	`3`	`module.exports = require('@inquirer/password')`
Original file line number	Diff line number	Diff line change
`@@ -1 +1,3 @@`
	`1`	`+'use strict'`
	`2`	`+`
`1`	`3`	`module.exports = require('@inquirer/search')`
Original file line number	Diff line number	Diff line change
`@@ -1 +1,3 @@`
	`1`	`+'use strict'`
	`2`	`+`
`1`	`3`	`module.exports = require('@inquirer/select')`
Original file line number	Diff line number	Diff line change
`@@ -1 +1,3 @@`
	`1`	`+'use strict'`
	`2`	`+`
`1`	`3`	`module.exports = require('@npmcli/package-json')`