revert: remove in-memory TTL cache for GitHub API responses#108
Closed
John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
Closed
revert: remove in-memory TTL cache for GitHub API responses#108John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
Conversation
This reverts commit 3d14b95.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the in-memory TTL cache added in 3d14b95 which caused test failures in CI.
The cache interfered with vitest mocks — cached responses from one test leaked into subsequent tests running concurrently, causing 25 test failures in
releases-github.test.mts.The rate limit issue that motivated the cache should be addressed at the build layer (skip rebuild when fresh) rather than the API layer.