Skip to content

feat(paths): add fromUnixPath for MSYS-to-Windows path conversion#168

Merged
John-David Dalton (jdalton) merged 1 commit intomainfrom
feat/from-unix-path
Apr 13, 2026
Merged

feat(paths): add fromUnixPath for MSYS-to-Windows path conversion#168
John-David Dalton (jdalton) merged 1 commit intomainfrom
feat/from-unix-path

Conversation

@jdalton
Copy link
Copy Markdown
Collaborator

Summary

  • Adds fromUnixPath() as the inverse of toUnixPath() — converts MSYS/Git Bash paths (/c/path/to/file) back to native Windows format (C:/path/to/file)
  • Needed for sfw shim creation on Windows runners where command -v returns MSYS-style paths that PowerShell and cmd.exe can't resolve
  • On Unix platforms, passes through normalization unchanged (same behavior as toUnixPath)

Test plan

  • 14 new test cases covering drive letters, edge cases, Buffer/URL input, round-trip with toUnixPath
  • All 101 normalize tests pass
  • Build passes
  • Lint and TypeScript check pass

@jdalton John-David Dalton (jdalton) force-pushed the feat/from-unix-path branch 2 times, most recently from dea6d0e to 431867f Compare April 13, 2026 20:45
@jdalton John-David Dalton (jdalton) marked this pull request as ready for review April 13, 2026 20:52
@jdalton John-David Dalton (jdalton) merged commit d85cbb6 into main Apr 13, 2026
12 checks passed
@jdalton John-David Dalton (jdalton) deleted the feat/from-unix-path branch April 13, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant