refactor(paths): consolidate ~/.socket dir constants, add _state, drop dead helpers#197
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reshape the
~/.socket/directory constants + helpers inpaths/socket.tsandconstants/socket.ts._state(~/.socket/_state) — version-less persistent app state: the home for daemon sockets, locks, OAuth refresh, durable caches that survive version bumps (mirrors pnpmstate-dir/XDG_STATE_HOME). NewgetSocketStateDir/getSocketAppStateDir/getSocketAppRuntimeDir(the_state/<app>/run/dir for a daemon's socket +concurrency.lock+ pid) +RUN_DIR+getSocketStateDirEnv.SOCKET_DIRmap holding full_-prefixed names (cacache/dlx/state/wheelhouse).SOCKET_APP_PREFIX->SOCKET_DIR_PREFIX— it prefixes dirs (including infra dirs like_cacache), not apps.getSocketCliDir,getSocketRegistryDir,getSocketRegistryGithubCacheDir, plus orphanedSOCKET_CLI_APP_NAME/SOCKET_FIREWALL_APP_NAME/SOCKET_REGISTRY_APP_NAME.@filelayout comment.Why
Foundation for the proteus credential-broker daemon (needs a stable, version-less
_state/<app>/run/home for its Unix socket + lock). Also removes accumulated dead code + a self-contradicting*_APP_NAMEnaming (the constants describe dirs, not apps).Verification
lint --all— 0 / 0getSocketAppCacheDir/getSocketAppCacheTtlDirkept (bundled into socket-cli dist);getSocketWheelhouseDirkept (used by janus).