-
Notifications
You must be signed in to change notification settings - Fork 15
Add optional Claude Code hook for blocking malicious packages #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dc-larsen
wants to merge
2
commits into
main
Choose a base branch
from
add-claude-code-hook
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+400
−0
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| #!/usr/bin/env node | ||
| import { test } from 'node:test' | ||
| import assert from 'node:assert' | ||
| import { execFileSync } from 'node:child_process' | ||
| import { join } from 'node:path' | ||
|
|
||
| const hookPath = join(import.meta.dirname, 'socket-gate.ts') | ||
|
|
||
| function runHook (input: string): string { | ||
| return execFileSync('node', ['--experimental-strip-types', hookPath], { | ||
| input, | ||
| encoding: 'utf-8', | ||
| timeout: 60_000, | ||
| env: { ...process.env } | ||
| }).trim() | ||
| } | ||
|
|
||
| function parseOutput (output: string): { decision: string, reason?: string } { | ||
| const parsed = JSON.parse(output) | ||
| return { | ||
| decision: parsed.hookSpecificOutput.permissionDecision, | ||
| reason: parsed.hookSpecificOutput.permissionDecisionReason | ||
| } | ||
| } | ||
|
|
||
| function makeInput (command: string): string { | ||
| return JSON.stringify({ | ||
| session_id: 'test', | ||
| tool_name: 'Bash', | ||
| tool_input: { command } | ||
| }) | ||
| } | ||
|
|
||
| function socketCliAvailable (): boolean { | ||
| try { | ||
| execFileSync('which', ['socket'], { encoding: 'utf-8', timeout: 5_000 }) | ||
| return true | ||
| } catch { | ||
| return false | ||
| } | ||
| } | ||
|
|
||
| const hasCli = socketCliAvailable() | ||
|
|
||
| test('socket-gate hook', async (t) => { | ||
| // ======================================== | ||
| // Unit tests (no Socket CLI required) | ||
| // ======================================== | ||
|
|
||
| await t.test('allows non-Bash tools', () => { | ||
| const input = JSON.stringify({ session_id: 'test', tool_name: 'Read', tool_input: { path: '/tmp/foo' } }) | ||
| const result = parseOutput(runHook(input)) | ||
| assert.strictEqual(result.decision, 'allow') | ||
| }) | ||
|
|
||
| await t.test('allows non-install commands', () => { | ||
| const result = parseOutput(runHook(makeInput('ls -la'))) | ||
| assert.strictEqual(result.decision, 'allow') | ||
| }) | ||
|
|
||
| await t.test('allows lockfile-only installs', () => { | ||
| for (const cmd of ['npm install', 'npm i', 'npm ci', 'yarn', 'yarn install', 'bun install', 'pnpm install']) { | ||
| const result = parseOutput(runHook(makeInput(cmd))) | ||
| assert.strictEqual(result.decision, 'allow', `should allow: ${cmd}`) | ||
| } | ||
| }) | ||
|
|
||
| await t.test('allows empty input', () => { | ||
| const result = parseOutput(runHook('')) | ||
| assert.strictEqual(result.decision, 'allow') | ||
| }) | ||
|
|
||
| await t.test('allows invalid JSON', () => { | ||
| const result = parseOutput(runHook('not json')) | ||
| assert.strictEqual(result.decision, 'allow') | ||
| }) | ||
|
|
||
| // ======================================== | ||
| // Integration tests (require Socket CLI with `socket login`) | ||
| // ======================================== | ||
|
|
||
| await t.test('allows safe package (lodash)', { skip: !hasCli && 'Socket CLI not installed' }, () => { | ||
| const result = parseOutput(runHook(makeInput('npm install lodash'))) | ||
| assert.strictEqual(result.decision, 'allow') | ||
| }) | ||
|
|
||
| await t.test('allows safe scoped package (@types/node)', { skip: !hasCli && 'Socket CLI not installed' }, () => { | ||
| const result = parseOutput(runHook(makeInput('yarn add @types/node'))) | ||
| assert.strictEqual(result.decision, 'allow') | ||
| }) | ||
|
|
||
| await t.test('blocks typosquat (browserlist)', { skip: !hasCli && 'Socket CLI not installed' }, () => { | ||
| const result = parseOutput(runHook(makeInput('npm install browserlist'))) | ||
| assert.strictEqual(result.decision, 'deny') | ||
| assert.ok(result.reason?.includes('browserlist'), 'reason should mention package name') | ||
| assert.ok(result.reason?.includes('socket.dev'), 'reason should include review link') | ||
| }) | ||
|
|
||
| await t.test('handles versioned install', { skip: !hasCli && 'Socket CLI not installed' }, () => { | ||
| const result = parseOutput(runHook(makeInput('npm install express@4.18.2'))) | ||
| assert.strictEqual(result.decision, 'allow') | ||
| }) | ||
|
|
||
| await t.test('handles pnpm add', { skip: !hasCli && 'Socket CLI not installed' }, () => { | ||
| const result = parseOutput(runHook(makeInput('pnpm add express'))) | ||
| assert.strictEqual(result.decision, 'allow') | ||
| }) | ||
|
|
||
| await t.test('handles bun add', { skip: !hasCli && 'Socket CLI not installed' }, () => { | ||
| const result = parseOutput(runHook(makeInput('bun add express'))) | ||
| assert.strictEqual(result.decision, 'allow') | ||
| }) | ||
| }) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No such thing as "None" severity