Commit 1723e71
committed
fix(ci): allowBuilds.puppeteer:true and drop dead pnpm.onlyBuiltDependencies
CI on main has been failing across all three workflows (CI, Tour GH Pages, Val Town deploy) since the puppeteer/mermaid feature landed in b34ba09. The error was always:
ERR_PNPM_IGNORED_BUILDS Ignored build scripts: puppeteer@24.41.0
Run "pnpm approve-builds" to pick which dependencies should be allowed to run scripts.
Root cause: pnpm v11.0.0-rc.5 reads build-script approvals from
pnpm-workspace.yaml's `allowBuilds:` map, NOT from package.json's
`pnpm.onlyBuiltDependencies` array. The package.json field was added
alongside the puppeteer dep but had no effect under rc.5. Lockfile state
in CI runners always tripped the missing approval.
Fix:
- Declare `puppeteer: true` under `allowBuilds:` in pnpm-workspace.yaml.
Tour (GH Pages) requires Chromium for mermaid rendering, so allowing
the postinstall is the correct stance. CI + Val Town pay the ~300MB
download cost as the uniform-install tradeoff.
- Drop the dead `pnpm.onlyBuiltDependencies` entry from package.json
per CLAUDE.md "actively remove backward-compat" rule.
Side effects:
- pnpm run update bumped @socketsecurity/lib in .claude/hooks/check-new-deps
from 5.20.1 -> 5.24.0 (matches root manifest pin).
- oxfmt normalized markdown italics in CLAUDE.md (*order* -> _order_).1 parent ad40adf commit 1723e71
5 files changed
Lines changed: 10 additions & 22 deletions
File tree
- .claude/hooks/check-new-deps
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
155 | 155 | | |
156 | 156 | | |
157 | 157 | | |
158 | | - | |
| 158 | + | |
159 | 159 | | |
160 | 160 | | |
161 | 161 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | 125 | | |
131 | 126 | | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
11 | 17 | | |
12 | 18 | | |
13 | 19 | | |
| |||
0 commit comments