Skip to content

Commit 2d8f54a

Browse files
committed
pages: pin node-version to 25.9.0 on the shared setup-and-install
Previously relying on the shared action's default. Making it explicit in the workflow so the Node version this build runs under is visible without chasing into socket-registry. Matches fleet standard. Also drop an overexplained comment in walkthrough.mts (sriForUrl).
1 parent f91fcc4 commit 2d8f54a

2 files changed

Lines changed: 1 addition & 5 deletions

File tree

.github/workflows/pages.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ jobs:
6060
uses: SocketDev/socket-registry/.github/actions/setup-and-install@d7b5d15a9be8973a5715459d12b9a033603a5ff5 # main
6161
with:
6262
checkout-fetch-depth: '1'
63+
node-version: '25.9.0'
6364

6465
# The fleet's shared checkout action doesn't init submodules.
6566
# We need upstream/meander because the generate step shells out

scripts/walkthrough.mts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -171,11 +171,6 @@ async function sriForUrl(url: string, cacheDir: string): Promise<string> {
171171
throw new Error(`SRI fetch ${url} → HTTP ${res.status}`)
172172
}
173173
const bytes = new Uint8Array(await res.arrayBuffer())
174-
// `crypto.hash` is the Node 21+ one-shot helper — base64-encodes
175-
// the sha384 digest in a single call. Equivalent to the
176-
// createHash(...).update(...).digest('base64') dance but shorter.
177-
// SRI format itself is just `<algo>-<base64hash>`; no stdlib helper
178-
// does the string prefix, so we build that ourselves.
179174
const integrity = `sha384-${cryptoHash('sha384', bytes, 'base64')}`
180175
mkdirSync(cacheDir, { recursive: true })
181176
writeFileSync(cachePath, integrity + '\n')

0 commit comments

Comments
 (0)