Skip to content

Commit 36c2da1

Browse files
committed
Fix package.json field removal in npm package installation
1 parent b1383ef commit 36c2da1

1 file changed

Lines changed: 12 additions & 10 deletions

File tree

scripts/install-npm-packages.mjs

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -387,8 +387,8 @@ async function applySocketOverrideIfExists(packageName, packagePath) {
387387
...(overridePkgJson.dependencies
388388
? { dependencies: overridePkgJson.dependencies }
389389
: {}),
390-
main: overridePkgJson.main,
391-
module: overridePkgJson.module,
390+
...(overridePkgJson.main ? { main: overridePkgJson.main } : {}),
391+
...(overridePkgJson.module ? { module: overridePkgJson.module } : {}),
392392
})
393393

394394
// Write updated package.json.
@@ -522,8 +522,8 @@ async function installPackage(packageInfo) {
522522
...(overridePkgJson.dependencies
523523
? { dependencies: overridePkgJson.dependencies }
524524
: {}),
525-
main: overridePkgJson.main,
526-
module: overridePkgJson.module,
525+
...(overridePkgJson.main ? { main: overridePkgJson.main } : {}),
526+
...(overridePkgJson.module ? { module: overridePkgJson.module } : {}),
527527
private: true,
528528
})
529529

@@ -898,12 +898,14 @@ async function installPackage(packageInfo) {
898898
...(overridePkgJson.dependencies
899899
? { dependencies: overridePkgJson.dependencies }
900900
: {}),
901-
main: overridePkgJson.main,
902-
module: overridePkgJson.module,
903-
types: overridePkgJson.types,
904-
files: overridePkgJson.files,
905-
sideEffects: overridePkgJson.sideEffects,
906-
socket: overridePkgJson.socket,
901+
...(overridePkgJson.main ? { main: overridePkgJson.main } : {}),
902+
...(overridePkgJson.module ? { module: overridePkgJson.module } : {}),
903+
...(overridePkgJson.types ? { types: overridePkgJson.types } : {}),
904+
...(overridePkgJson.files ? { files: overridePkgJson.files } : {}),
905+
...(overridePkgJson.sideEffects !== undefined
906+
? { sideEffects: overridePkgJson.sideEffects }
907+
: {}),
908+
...(overridePkgJson.socket ? { socket: overridePkgJson.socket } : {}),
907909
// Make the package private for testing.
908910
private: true,
909911
})

0 commit comments

Comments
 (0)