fix(lint): strip file-scope oxlint disables (batch 2)

jdalton · jdalton · commit 6541c16bdc36 · 2026-05-18T12:11:48.000-04:00
26 files cleared of `/* oxlint-disable socket/&lt;rule&gt; */` file-scope
disables. Each file is now lint-clean for the previously-suppressed
rules — most were `prefer-cached-for-loop` blanket disables on
files where the actual cached-length rule no longer mis-fires (it
correctly detects Set/Map/Object.entries iterators now), so the
blanket exemption was dead weight.

Other disables were defensive (catching one-off violations) and turn
out to be unneeded after the new oxlint version's stricter detection.
diff --git a/.github/actions/lib/check-firewall.mts b/.github/actions/lib/check-firewall.mts
@@ -1,7 +1,4 @@
-/* oxlint-disable socket/no-status-emoji -- intentional emoji output. */
-/* oxlint-disable socket/prefer-cached-for-loop -- iterates non-array iterables (Object.entries / Map values); the cached-length rewrite would be incorrect. */
 
-/* oxlint-disable socket/no-fetch-prefer-http-request -- composite action helper, runs on raw runner before setup-node (no node_modules) */
 /**
  * @file Check a Socket package against the firewall API before downloading its
  *   tarball directly from the npm registry. Endpoint: GET
diff --git a/.github/actions/lib/jq.mjs b/.github/actions/lib/jq.mjs
@@ -1,4 +1,3 @@
-/* oxlint-disable socket/no-console-prefer-logger -- composite action helper, runs on raw runner before setup-node (no node_modules) */
 /**
  * @file Minimal JSON reader for composite-action shells. Replaces jq for action
  *   steps that run before actions/setup-node, so this only relies on the system
diff --git a/.github/actions/lib/platform.mjs b/.github/actions/lib/platform.mjs
@@ -1,4 +1,3 @@
-/* oxlint-disable socket/no-console-prefer-logger -- composite action helper, runs on raw runner before setup-node (no node_modules) */
 /**
  * @file Prints the canonical Socket platform string for this runner. Output:
  *   linux-x64, linux-arm64, linux-x64-musl, linux-arm64-musl, darwin-x64,
diff --git a/.github/actions/lib/semver.mjs b/.github/actions/lib/semver.mjs
@@ -1,7 +1,6 @@
 import { getDefaultLogger } from '@socketsecurity/lib-stable/logger'
 const logger = getDefaultLogger()
 
-/* oxlint-disable socket/no-console-prefer-logger socket/export-top-level-functions -- composite action helper, runs on raw runner before setup-node (no node_modules) */
 /**
  * @file Semver validate + compare for composite-action shells. Replaces inline
  *   bash regex + pure-bash version_lt(). Two modes: node lib/semver.mjs valid
diff --git a/perf/npm/json-stable-stringify.perf.mts b/perf/npm/json-stable-stringify.perf.mts
@@ -1,4 +1,3 @@
-/* oxlint-disable socket/prefer-cached-for-loop -- perf harness iterates the case matrix; loop overhead is dwarfed by the operation being benchmarked. */
 import assert from 'node:assert/strict'
 import path from 'node:path'
 
diff --git a/registry/scripts/build.mjs b/registry/scripts/build.mjs
@@ -1,4 +1,3 @@
-/* oxlint-disable socket/prefer-cached-for-loop -- iterates non-array iterables (Object.values recursion); the cached-length rewrite would be incorrect. */
 /**
  * @file Fast build runner using esbuild for smaller bundles and faster builds.
  */
diff --git a/scripts/build.mts b/scripts/build.mts
@@ -1,4 +1,3 @@
-/* oxlint-disable socket/no-status-emoji -- intentional emoji output. */
 
 /**
  * @file Build script for socket-registry monorepo. Delegates to the registry
diff --git a/scripts/cascade-internal.mts b/scripts/cascade-internal.mts
@@ -1,5 +1,4 @@
 #!/usr/bin/env node
-/* oxlint-disable socket/prefer-cached-for-loop -- iterates non-array iterables (Map / Set / Object.entries); the cached-length rewrite would be incorrect. */
 /**
  * @file Recursively bump stale internal SHA pins to HEAD. socket-registry's
  *   `.github/actions/` and `.github/workflows/` files pin each other by
diff --git a/scripts/npm/check-trusted-packages.mts b/scripts/npm/check-trusted-packages.mts
@@ -5,7 +5,6 @@
  *   packages by default. Use --all flag to check all Socket packages across all
  *   scopes.
  */
-/* oxlint-disable socket/prefer-cached-for-loop -- iterates non-array iterables (Object.entries); the cached-length rewrite would be incorrect. */
 
 import { readFile } from 'node:fs/promises'
 import path from 'node:path'
diff --git a/scripts/npm/make-npm-override.mts b/scripts/npm/make-npm-override.mts
@@ -1,4 +1,3 @@
-/* oxlint-disable socket/prefer-cached-for-loop -- iterates non-array iterables (Object.entries); the cached-length rewrite would be incorrect. */
 /**
  * @file Creates Socket registry package overrides for npm packages. Interactive
  *   CLI tool that guides users through creating secure package overrides:
diff --git a/scripts/npm/test-npm-packages.mts b/scripts/npm/test-npm-packages.mts
@@ -1,4 +1,3 @@
-/* oxlint-disable socket/no-status-emoji -- intentional emoji output. */
 
 /**
  * @file Test script for npm packages that handles downloading, installing, and
diff --git a/scripts/paths.mts b/scripts/paths.mts
@@ -1,4 +1,3 @@
-/* oxlint-disable socket/sort-source-methods -- ordered as path resolution flow (resolver → primary roots → derived constants → helpers); alphabetizing would scatter the flow. */
 /**
  * @file Canonical path constants + resolvers for this package. Mantra: 1 path,
  *   1 reference. Every path the scripts in this directory need — config files,
diff --git a/scripts/perf.mts b/scripts/perf.mts
@@ -2,7 +2,6 @@
  * @file Performance benchmarking script runner. Executes performance tests and
  *   benchmarks for registry operations.
  */
-/* oxlint-disable socket/prefer-cached-for-loop -- iterates an async glob() generator; the cached-length rewrite is incorrect for AsyncIterables. */
 
 import { execBin } from '@socketsecurity/lib-stable/bin'
 import { getDefaultLogger } from '@socketsecurity/lib-stable/logger'
diff --git a/scripts/setup.mts b/scripts/setup.mts
@@ -1,4 +1,3 @@
-/* oxlint-disable socket/prefer-cached-for-loop -- iterates Object.entries() of a tool-config map; the cached-length rewrite would be incorrect. */
 /**
  * @file Developer setup script. Checks prerequisites and installs pinned
  *   external tools (currently: zizmor for GitHub Actions security scanning).
diff --git a/scripts/testing/analyze-ci-failures.mts b/scripts/testing/analyze-ci-failures.mts
@@ -1,7 +1,6 @@
 /**
  * @file Analyzes CI failure logs and suggests fixes based on known patterns.
  */
-/* oxlint-disable socket/prefer-cached-for-loop -- iterates non-array iterables (Object.entries) and small destructured records; the cached-length rewrite would be incorrect. */
 
 import { promises as fs } from 'node:fs'
 import process from 'node:process'
diff --git a/scripts/testing/reproduce-ci-locally.mts b/scripts/testing/reproduce-ci-locally.mts
@@ -1,4 +1,3 @@
-/* oxlint-disable socket/no-status-emoji -- intentional emoji output. */
 
 /**
  * @file Reproduces CI test environment locally to catch issues before pushing.
diff --git a/scripts/update-external-tools.mts b/scripts/update-external-tools.mts
@@ -1,5 +1,4 @@
 #!/usr/bin/env node
-/* oxlint-disable socket/prefer-cached-for-loop -- iterates Object.entries() of platform/tool config maps; the cached-length rewrite would be incorrect. */
 /**
  * Update the repo-root `external-tools.json` to pick up new releases of every
  * tool listed with `"release": "asset"` (today: pnpm, zizmor).
diff --git a/scripts/util/get-code-coverage.mts b/scripts/util/get-code-coverage.mts
@@ -1,7 +1,6 @@
 /**
  * @file Utility to generate and calculate code coverage metrics.
  */
-/* oxlint-disable socket/prefer-cached-for-loop -- iterates Object.values() of a coverage map; the cached-length rewrite would be incorrect. */
 import { existsSync } from 'node:fs'
 import path from 'node:path'
 
diff --git a/scripts/validation/no-link-deps.mts b/scripts/validation/no-link-deps.mts
@@ -2,7 +2,6 @@
  * @file Validates that no package.json files contain link: dependencies. Link
  *   dependencies are prohibited - use workspace: or catalog: instead.
  */
-/* oxlint-disable socket/prefer-cached-for-loop -- iterates Map.entries() / destructured tuples; the cached-length rewrite would be incorrect. */
 
 import { promises as fs } from 'node:fs'
 import path from 'node:path'
diff --git a/test/npm/es6-object-assign.test.mts b/test/npm/es6-object-assign.test.mts
@@ -1,7 +1,6 @@
 /**
  * @file Tests for @socketregistry/es6-object-assign npm package override.
  */
-/* oxlint-disable socket/prefer-cached-for-loop -- test iterates short literal arrays; perf rewrite is noise. */
 import path from 'node:path'
 // eslint-disable-next-line n/no-extraneous-import
 import { getDefaultLogger } from '@socketsecurity/lib/logger'
diff --git a/test/npm/get-symbol-description.test.mts b/test/npm/get-symbol-description.test.mts
@@ -1,4 +1,3 @@
-/* oxlint-disable socket/prefer-cached-for-loop -- ports upstream test loops verbatim; rewriting would diverge from the source map to upstream. */
 /**
  * @file Tests for get-symbol-description NPM package override. Ported 1:1 from
  *   upstream v1.1.0 (1489d87a1af261f0f90faa73c619090363f7976b):
diff --git a/test/npm/internal-slot.test.mts b/test/npm/internal-slot.test.mts
@@ -1,4 +1,3 @@
-/* oxlint-disable socket/prefer-cached-for-loop -- ports upstream test loops verbatim; rewriting would diverge from the source map to upstream. */
 /**
  * @file Tests for internal-slot NPM package override. Ported 1:1 from upstream
  *   v1.1.0 (705000a7):
diff --git a/test/npm/json-stable-stringify.test.mts b/test/npm/json-stable-stringify.test.mts
@@ -1,7 +1,6 @@
 /**
  * @file Tests for @socketregistry/json-stable-stringify npm package override.
  */
-/* oxlint-disable socket/prefer-cached-for-loop -- test iterates short literal arrays; perf rewrite is noise. */
 import { describe, expect, it } from 'vitest'
 
 import { getEnv } from '../../scripts/constants/env.mts'
diff --git a/test/npm/path-parse.test.mts b/test/npm/path-parse.test.mts
@@ -1,4 +1,3 @@
-/* oxlint-disable socket/prefer-cached-for-loop -- ports upstream test loops verbatim; rewriting would diverge from the source map to upstream. */
 /**
  * @file Tests for path-parse NPM package override. Ported 1:1 from upstream
  *   v1.0.7 (f7e258dd):
diff --git a/test/npm/safer-buffer.test.mts b/test/npm/safer-buffer.test.mts
@@ -2,7 +2,6 @@
  * @file Tests for @socketregistry/safer-buffer npm package override.
  */
 /* eslint-disable n/no-deprecated-api */
-/* oxlint-disable socket/prefer-cached-for-loop -- tests iterate short literal arrays / Object.keys() return values; per-iteration overhead is irrelevant and rewriting obscures the test intent. */
 /* max-file-lines: legitimate — exhaustive Buffer API parity matrix; the test surface is intrinsic to the package being tested and splitting it scatters one describe-tree across files. */
 import buffer from 'node:buffer'
 import path from 'node:path'
diff --git a/test/packages.test.mts b/test/packages.test.mts
@@ -1,7 +1,6 @@
 /**
  * @file Tests for package validation and manifest generation.
  */
-/* oxlint-disable socket/prefer-cached-for-loop -- test loops iterate small literal sets / for-await-of streams; perf rewrite obscures intent. */
 import { existsSync, promises as fs } from 'node:fs'
 import { createRequire } from 'node:module'
 import path from 'node:path'

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-/* oxlint-disable socket/no-console-prefer-logger -- composite action helper, runs on raw runner before setup-node (no node_modules) */`
`2`	`1`	`/**`
`3`	`2`	`* @file Minimal JSON reader for composite-action shells. Replaces jq for action`
`4`	`3`	`* steps that run before actions/setup-node, so this only relies on the system`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-/* oxlint-disable socket/prefer-cached-for-loop -- perf harness iterates the case matrix; loop overhead is dwarfed by the operation being benchmarked. */`
`2`	`1`	`import assert from 'node:assert/strict'`
`3`	`2`	`import path from 'node:path'`
`4`	`3`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-/* oxlint-disable socket/no-status-emoji -- intentional emoji output. */`
`2`	`1`
`3`	`2`	`/**`
`4`	`3`	`* @file Build script for socket-registry monorepo. Delegates to the registry`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`#!/usr/bin/env node`
`2`		`-/* oxlint-disable socket/prefer-cached-for-loop -- iterates non-array iterables (Map / Set / Object.entries); the cached-length rewrite would be incorrect. */`
`3`	`2`	`/**`
`4`	`3`	`* @file Recursively bump stale internal SHA pins to HEAD. socket-registry's`
`5`	`4`	* `.github/actions/` and `.github/workflows/` files pin each other by