fix(lint): convert cached-length for-loops over iterables to for-of

Drop manual cached-length for-loops at call sites the new
`socket/no-cached-for-on-iterable` rule catches. Pure mechanical
swap to `for (const item of X)`; no logic change.

Author: jdalton

scripts/util/suppress-warnings.mts

@@ -21,9 +21,9 @@ export function setupSuppression() {
     process.emitWarning = (warning, ...args) => {
       // Check both string warnings and warning objects.
       if (typeof warning === 'string') {
-        // Check if any suppressed warning type matches.
-        for (let i = 0, { length } = suppressedWarnings; i < length; i += 1) {
-          const suppressedType = suppressedWarnings[i]
+        // `suppressedWarnings` is a Set — iterate with for...of
+        // since the body only needs each element, not an index.
+        for (const suppressedType of suppressedWarnings) {
           if (warning.includes(suppressedType)) {
             return
           }

scripts/validation/bundle-deps.mts

@@ -320,26 +320,26 @@ export async function validateBundleDeps() {
     const externals = await extractExternalPackages(file)
     const bundled = await extractBundledPackages(file)
 
-    for (let i = 0, { length } = externals; i < length; i += 1) {
-      const ext = externals[i]
+    // `externals` and `bundled` are Sets — use for...of, not the
+    // cached-length for-loop.
+    for (const ext of externals) {
       const packageName = getPackageName(ext)
       if (packageName && !BUILTIN_MODULES.has(packageName)) {
         allExternals.add(packageName)
       }
     }
 
-    for (let i = 0, { length } = bundled; i < length; i += 1) {
-      const bun = bundled[i]
+    for (const bun of bundled) {
       allBundled.add(bun)
     }
   }
 
   const violations = []
   const warnings = []
 
-  // Validate external packages are in dependencies or peerDependencies
-  for (let i = 0, { length } = allExternals; i < length; i += 1) {
-    const packageName = allExternals[i]
+  // Validate external packages are in dependencies or peerDependencies.
+  // `allExternals` / `allBundled` are Sets — use for...of.
+  for (const packageName of allExternals) {
     if (!dependencies.has(packageName) && !peerDependencies.has(packageName)) {
       violations.push({
         type: 'external-not-in-deps',
@@ -353,8 +353,7 @@ export async function validateBundleDeps() {
   }
 
   // Validate bundled packages are in devDependencies (not dependencies)
-  for (let i = 0, { length } = allBundled; i < length; i += 1) {
-    const packageName = allBundled[i]
+  for (const packageName of allBundled) {
     if (dependencies.has(packageName)) {
       violations.push({
         type: 'bundled-in-deps',