chore(pnpm): drop dead .pnpmrc, declare pnpm defaults in pnpm-workspace.yaml#617
Merged
John-David Dalton (jdalton) merged 1 commit intomainfrom Apr 25, 2026
Merged
chore(pnpm): drop dead .pnpmrc, declare pnpm defaults in pnpm-workspace.yaml#617John-David Dalton (jdalton) merged 1 commit intomainfrom
John-David Dalton (jdalton) merged 1 commit intomainfrom
Conversation
2e8a7d0 to
e7eab4f
Compare
…ce.yaml pnpm v11 reads settings from pnpm-workspace.yaml (and the npm-compat subset from .npmrc), not from .pnpmrc. The .pnpmrc file previously on main was silently ignored. Changes: - Delete .pnpmrc (dead file, pnpm does not read it). - Add to pnpm-workspace.yaml: - autoInstallPeers: true pnpm default, declared explicitly - enablePrePostScripts: true pnpm default, declared explicitly (husky) - saveExact: true pin exact on `pnpm add` No behavioral change — these match current pnpm defaults + existing .npmrc settings. Declaring explicitly hardens against future pnpm default flips silently diverging across the fleet.
e7eab4f to
1be1fd8
Compare
Dale Bustad (divmain)
approved these changes
Apr 25, 2026
Elijah Insua (tmpvar)
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm v11 reads settings from
pnpm-workspace.yaml(and the npm-compat subset from.npmrc), not from.pnpmrc. The.pnpmrcfile previously committed to main was being silently ignored.Amended: drop the
.pnpmrcentirely (it was dead), and add pnpm defaults explicitly topnpm-workspace.yaml:autoInstallPeers: true— pnpm default, declared explicitly.enablePrePostScripts: true— pnpm default, declared explicitly (husky).saveExact: true— pin exact onpnpm add.Existing settings preserved:
loglevel,trustPolicy,allowBuilds,pmOnFail,overrides,minimumReleaseAge,minimumReleaseAgeExclude. The.npmrckeeps handlingignore-scripts,min-release-age, andloglevelfrom the npm-compat subset.No behavioral change
Install/resolve/build work identically. This just locks in current behavior against future pnpm default flips.
Test plan
pnpm install --lockfile-onlypasses (no lockfile changes needed).