Skip to content

fix: harden GitHub Actions workflows#57

Merged
bmeck merged 2 commits intomasterfrom
fix/zizmor-workflow-security
Mar 25, 2026
Merged

fix: harden GitHub Actions workflows#57
bmeck merged 2 commits intomasterfrom
fix/zizmor-workflow-security

Conversation

@reberhardt7
Copy link
Copy Markdown
Contributor

@reberhardt7 reberhardt7 commented Mar 25, 2026

Summary

  • Fix template injection: Replace direct ${{ github.ref }} interpolation in run: blocks with an environment variable to prevent script injection attacks
  • Pin actions to SHAs: Pin actions/checkout, actions/setup-node, HaaLeo/publish-vscode-extension, and softprops/action-gh-release to full-length commit SHAs instead of mutable tags
  • Add permissions: Add explicit permissions: contents: write to the publish workflow and persist-credentials: false to the checkout step
  • Add zizmor config: Add .github/zizmor.yml configuration file for the zizmor GitHub Actions security linter

- Fix template injection vulnerability by using environment variables
  instead of direct interpolation of github.ref
- Pin all third-party actions to full-length commit SHAs
- Add explicit permissions (contents: write) to publish workflow
- Add persist-credentials: false to checkout step
- Add zizmor.yml configuration file

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@reberhardt7 reberhardt7 requested a review from bmeck March 25, 2026 04:04
…zmor finding

Update actions/checkout to v6.0.2 and actions/setup-node to v4.4.0
with pinned SHAs. Suppress false positive cache-poisoning finding for
setup-node in publish.yml (caching is not enabled without explicit
cache: config).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@reberhardt7 reberhardt7 changed the title fix: harden GitHub Actions workflows (zizmor) fix: harden GitHub Actions workflows Mar 25, 2026
@bmeck bmeck merged commit 4410475 into master Mar 25, 2026
10 checks passed
@bmeck bmeck deleted the fix/zizmor-workflow-security branch March 25, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants