Skip to content

Commit e13c01d

Browse files
authored
Cleanup the plugin and fix compilation (#12)
* Remove unnecessary includes to ConstantForceField.h * Missing Sofa.Component.Mapping.Linear package * sort lines * cleaning dependencies
1 parent 6b21423 commit e13c01d

4 files changed

Lines changed: 9 additions & 39 deletions

File tree

CMakeLists.txt

Lines changed: 4 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,11 @@ project(Shell VERSION 1.0 LANGUAGES CXX)
33

44
# Find and load CMake configuration of packages containing this plugin's dependencies
55
find_package(Sofa.Config REQUIRED)
6-
sofa_find_package(Sofa.GL REQUIRED)
7-
sofa_find_package(Sofa.Type REQUIRED)
8-
sofa_find_package(Sofa.Geometry REQUIRED)
9-
sofa_find_package(Sofa.Simulation.Core REQUIRED)
106
sofa_find_package(Sofa.Component.Controller REQUIRED)
11-
sofa_find_package(Sofa.Component.StateContainer REQUIRED)
12-
sofa_find_package(Sofa.Component.Mapping.NonLinear REQUIRED)
13-
sofa_find_package(Sofa.Component.Constraint REQUIRED)
14-
sofa_find_package(Sofa.Component.Constraint.Lagrangian REQUIRED)
15-
sofa_find_package(Sofa.Component.Constraint.Lagrangian.Model REQUIRED)
16-
sofa_find_package(Sofa.Component.Constraint.Lagrangian.Solver REQUIRED)
177
sofa_find_package(Sofa.Component.Topology.Container.Dynamic REQUIRED)
18-
sofa_find_package(Sofa.Component.Collision.Detection.Intersection REQUIRED)
8+
sofa_find_package(Sofa.Component.StateContainer REQUIRED)
9+
sofa_find_package(Sofa.Component.Mapping.Linear REQUIRED)
10+
sofa_find_package(Sofa.GL REQUIRED)
1911

2012
set(README_FILE README.md)
2113

@@ -120,20 +112,8 @@ target_link_libraries(${PROJECT_NAME}
120112
Sofa.Component.Controller
121113
Sofa.Component.Topology.Container.Dynamic
122114
Sofa.Component.StateContainer
123-
Sofa.GL
124-
Sofa.Component.Collision.Detection.Intersection
125-
Sofa.Component.Mapping.NonLinear
126-
Sofa.Component.Constraint.Lagrangian.Model
127-
Sofa.Component.Constraint.Lagrangian.Solver
128-
Sofa.Component.Constraint.Lagrangian
129-
Sofa.Component.Constraint.Projective
130-
Sofa.Component.Mass
131-
Sofa.Component.SolidMechanics.Spring
132-
Sofa.Component.MechanicalLoad
133-
Sofa.Component.LinearSolver.Iterative
134-
Sofa.Component.ODESolver.Backward
135-
Sofa.Component.Engine.Select
136115
Sofa.Component.Mapping.Linear
116+
Sofa.GL
137117
)
138118

139119
sofa_create_package_with_targets(

src/Shell/mapping/BendingPlateMechanicalMapping.inl

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,19 +25,18 @@
2525
#pragma once
2626
#include <Shell/mapping/BendingPlateMechanicalMapping.h>
2727
#include <sofa/component/topology/container/dynamic/TriangleSetTopologyContainer.h>
28-
#include <sofa/component/collision/detection/intersection/MinProximityIntersection.h>
28+
// #include <sofa/component/collision/detection/intersection/MinProximityIntersection.h>
2929
#include <sofa/core/visual/VisualParams.h>
3030

31-
#include <sofa/component/collision/detection/intersection/MinProximityIntersection.h>
32-
#include <sofa/component/collision/detection/intersection/MeshMinProximityIntersection.h>
31+
// #include <sofa/component/collision/detection/intersection/MinProximityIntersection.h>
32+
// #include <sofa/component/collision/detection/intersection/MeshMinProximityIntersection.h>
3333

34-
#include <sofa/component/mechanicalload/ConstantForceField.h>
3534

3635
namespace sofa::component::mapping
3736
{
3837

39-
using namespace sofa::component::collision;
40-
38+
// using namespace sofa::component::collision;
39+
//
4140

4241
template <class TIn, class TOut>
4342
void BendingPlateMechanicalMapping<TIn, TOut>::init()

src/Shell/mapping/BezierTriangleMechanicalMapping.inl

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,8 @@
2727

2828
#include <Shell/mapping/BezierTriangleMechanicalMapping.h>
2929
#include <sofa/component/topology/container/dynamic/TriangleSetTopologyContainer.h>
30-
#include <sofa/component/collision/detection/intersection/MinProximityIntersection.h>
3130
#include <sofa/core/visual/VisualParams.h>
3231

33-
#include <sofa/component/mechanicalload/ConstantForceField.h>
34-
35-
3632
namespace sofa
3733
{
3834

@@ -42,7 +38,6 @@ namespace component
4238
namespace mapping
4339
{
4440

45-
using namespace sofa::component::collision;
4641
using namespace sofa::helper;
4742

4843
// Returns the skew-symetric matrix for computing a cross-product with the

src/Shell/shells2/mapping/BezierShellMechanicalMapping.inl

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,8 @@
3030
#include <Shell/misc/PointProjection.h>
3131

3232
#include <sofa/component/topology/container/dynamic/TriangleSetTopologyContainer.h>
33-
#include <sofa/component/collision/detection/intersection/MinProximityIntersection.h>
3433
#include <sofa/core/ConstraintParams.h>
3534

36-
#include <sofa/component/mechanicalload/ConstantForceField.h>
37-
3835
// We have own code to check the getJ() because checkJacobian sucks (at this
3936
// point in time).
4037
//#define CHECK_J
@@ -48,7 +45,6 @@ namespace component
4845
namespace mapping
4946
{
5047

51-
using namespace sofa::component::collision;
5248
using namespace sofa::helper;
5349

5450

0 commit comments

Comments
 (0)