Fix: Update Electron & Remote debugging fix#31
Merged
Conversation
This disables the Windows-multi-dpi-screens hack.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds a pinned Yarn binary and updates Electron tooling, introduces a /debug/remote-debug HTTP endpoint that proxies Chrome DevTools targets using a --remote-debugging-port arg, and adds a canSpanMultipleDisplays window config with conditional bounds application in window update logic. Changes
Sequence DiagramsequenceDiagram
participant Client as Client
participant API as API Helper
participant Proc as Process Args
participant CDP as Remote Debug Service\r\n(localhost:PORT)
Client->>API: GET /debug/remote-debug
API->>Proc: Read --remote-debugging-port
alt port provided
API->>CDP: GET /json/list
CDP-->>API: JSON targets
API->>API: Build HTML with target links
API-->>Client: 200 OK (HTML)
else port missing
API-->>Client: 500 (missing port guidance)
end
alt fetch/parse error
API->>API: Log error
API-->>Client: 500 (error message)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/helpers/APIHelper.ts`:
- Around line 161-217: The new route handler defined in
router.get('/debug/remote-debug', async (ctx) => { ... }) has
Prettier/formatting violations; fix by running the project's Prettier formatter
(or applying the project's ESLint --fix) on src/helpers/APIHelper.ts and adjust
the block so spacing, indentation, quotes and template-literal indentation match
project style (including the JSON.stringify(list) insertion inside the template
literal and consistent semicolons/commas), then ensure the catch block logging
(this.logger.error(...)) and ctx.body lines are formatted consistently; re-run
CI formatting checks to confirm the route compiles with Prettier.
- Around line 194-205: The debug page currently injects untrusted values
(page.title, page.url, page.webSocketDebuggerUrl) into a script and uses
innerHTML, enabling XSS; modify the rendering in APIHelper so you do not embed
raw JSON into a script or use innerHTML: instead build the DOM purely with
document.createElement, set element.textContent for visible strings, set
anchor.href by safely constructing the URL using encodeURIComponent for
components and by parsing/validating page.webSocketDebuggerUrl (from list)
before use, and avoid injecting raw HTML; update the code block that sets
ctx.body (and the script that iterates over list) to create anchors via
createElement('a') with a safe href and appendNodes rather than using innerHTML
or raw script-embedded data.
- Line 191: The fetch to `http://localhost:${remoteDebuggingPort}/json/list`
must be hardened: wrap the request in an AbortController with a short
configurable timeout, use that controller's signal in the fetch call, and clear
the timeout on completion; after fetch returns check `response.ok` and throw a
descriptive error (including status) if false, then parse JSON inside a
try/catch to surface parsing errors. Locate the expression containing
`fetch(\`http://localhost:${remoteDebuggingPort}/json/list\`)` and replace it
with the timed/abortable fetch + response.ok check and proper error handling so
the call cannot hang and failures are explicit.
In `@src/lib/config.ts`:
- Around line 25-26: Legacy persisted ConfigWindow objects may lack the new
canSpanMultipleDisplays field causing runtime shape mismatch; update the config
migration/normalization in src/helpers/ConfigHelper.ts to detect ConfigWindow
entries missing canSpanMultipleDisplays and backfill a sensible default (e.g.,
false) before returning or storing the config. Locate the code paths that
construct/normalize ConfigWindow (reference ConfigWindow and any
migration/normalize function in ConfigHelper) and add logic to set
window.canSpanMultipleDisplays = false when undefined so all loaded configs
conform to the ConfigWindow interface.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: cb922b44-0c57-4282-8400-ba812d032dd8
⛔ Files ignored due to path filters (3)
.yarn/plugins/@yarnpkg/plugin-version.cjsis excluded by!**/.yarn/**.yarn/releases/yarn-4.13.0.cjsis excluded by!**/.yarn/**yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (5)
.yarnrc.ymlpackage.jsonsrc/helpers/APIHelper.tssrc/helpers/WindowHelper.tssrc/lib/config.ts
jstarpl
approved these changes
Mar 4, 2026
Contributor
|
I think it would be nice to fix the linting issues before merging. |
siljekristensen
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the NRK
Type of Contribution
This is a:
Bug fix / Code improvement
Current Behavior
New Behavior
/debug/remote-debugfor remote debuggingStatus