Skip to content

fix: /healthz and /readyz wait for initial device connection (SOFIE-4325) #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jstarpl merged 2 commits into from
Jun 2, 2026
Merged

fix: /healthz and /readyz wait for initial device connection (SOFIE-4325) #1730

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b1643b
feat(mos-gateway): move synchronous updateDevices out of init
jstarpl Apr 27, 2026
594ed23
fix: ensure _initMosConnections() is run before setupObservers() duri…
jstarpl Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions packages/mos-gateway/src/mosHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,9 @@ export class MosHandler {
private _logger: Winston.Logger
private _disposed = false
private _settings?: MosGatewayConfig
private _coreHandler: CoreHandler | undefined
private _coreHandler!: CoreHandler
private _observers: Array<Observer<any>> = []
private _triggerupdateDevicesTimeout: any = null
private _triggerUpdateDevicesTimeout: any = null
private mosTypes: MosTypes

public static async create(
Expand Down Expand Up @@ -119,9 +119,6 @@ export class MosHandler {
}
}
*/
if (!coreHandler) {
throw Error('coreHandler is undefined!')
}

if (!coreHandler.core) {
throw Error('coreHandler.core is undefined!')
Expand All @@ -133,15 +130,16 @@ export class MosHandler {

this.mosTypes = getMosTypes(this.strict)

await this._updateDevices()
await this._initMosConnection()

if (!this._coreHandler) throw Error('_coreHandler is undefined!')
this._coreHandler.onConnected(() => {
coreHandler.onConnected(() => {
// This is called whenever a connection to Core has been (re-)established
this.setupObservers()
this.sendStatusOfAllMosDevices()
})
this.setupObservers()

this.triggerUpdateDevices()
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
async dispose(): Promise<void> {
this._disposed = true
Expand Down Expand Up @@ -209,10 +207,13 @@ export class MosHandler {
this._logger.debug('test log debug')
}
}
if (this._triggerupdateDevicesTimeout) {
clearTimeout(this._triggerupdateDevicesTimeout)
this.triggerUpdateDevices()
}
private triggerUpdateDevices() {
if (this._triggerUpdateDevicesTimeout) {
clearTimeout(this._triggerUpdateDevicesTimeout)
}
this._triggerupdateDevicesTimeout = setTimeout(() => {
this._triggerUpdateDevicesTimeout = setTimeout(() => {
this._updateDevices().catch((e) => {
this._logger.error(stringifyError(e))
})
Expand Down
Loading