packages/webui/src/client/lib/viewPort.ts (1)

258-265: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Release currentScrollingElement on the non-second-stage exits.

Line 263 stores a live segment element, but the first-stage success path and the no-scroll return never clear it. If that segment is later detached, the module scope still keeps the node reachable until another scroll or lifecycle reset happens.

Suggested fix

 					if (!secondStage) {
 						//  Wait to settle 1 atemt to scroll
 						pendingFirstStageTimeout = setTimeout(() => {
 							pendingFirstStageTimeout = undefined
 							let { top, bottom } = elementToScrollTo.getBoundingClientRect()
 							top = Math.floor(top)
 							bottom = Math.floor(bottom)
 							if (bottom > Math.floor(window.innerHeight) || top < headerHeight) {
 								// If not in place atempt to scroll again
 								innerScrollToSegment(elementToScrollTo, forceScroll, true, true).then(resolve, reject)
 							} else {
+								currentScrollingElement = undefined
 								resolve(true)
 							}
 						}, 1000) // When UI is getting optimized further we could lower this value
 					} else {
 						currentScrollingElement = undefined
 						resolve(true)
 					}
 				})
 			},
@@
 	}
 
+	currentScrollingElement = undefined
 	return Promise.resolve(false)
 }

Also applies to: 287-299, 315-315

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/webui/src/client/lib/viewPort.ts` around lines 258 - 265,
currentScrollingElement is being retained on non-second-stage exits which keeps
DOM nodes reachable; change the logic so non-second-stage paths release the
reference by setting currentScrollingElement = undefined instead of storing
elementToScrollTo, and ensure you also clear currentScrollingElement before any
early/no-scroll returns and in the similar blocks referenced (the branches
around pendingFirstStageTimeout, the block covering lines ~287-299, and the
single-line exit near 315). Update places that set currentScrollingElement to
elementToScrollTo (and any early-return paths) to clear it (use
currentScrollingElement = undefined) and keep the second-stage behavior
unchanged.

packages/webui/src/client/ui/SegmentTimeline/SourceLayerItem.tsx (1)

253-260: ⚠️ Potential issue | 🟡 Minor

Add togglePreviewPopUp to the mini-inspector callback dependency arrays
toggleMiniInspectorOn/toggleMiniInspectorOff call togglePreviewPopUp but don’t depend on it, so they can retain a stale togglePreviewPopUp closure when its own dependencies change (also applies to ~333-342).

Suggested fix

 const toggleMiniInspectorOn = useCallback(
 	(e: React.MouseEvent) => togglePreviewPopUp(e, true),
-	[piece, cursorTimePosition, contentStatus, timeScale]
+	[togglePreviewPopUp]
 )
 const toggleMiniInspectorOff = useCallback(
 	(e: React.MouseEvent) => togglePreviewPopUp(e, false),
-	[piece, cursorTimePosition, contentStatus, timeScale]
+	[togglePreviewPopUp]
 )

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/webui/src/client/ui/SegmentTimeline/SourceLayerItem.tsx` around
lines 253 - 260, The two callbacks toggleMiniInspectorOn and
toggleMiniInspectorOff call togglePreviewPopUp but don't list it in their
dependency arrays, which can lead to stale closures; update both useCallback
dependency arrays to include togglePreviewPopUp, and also add togglePreviewPopUp
to the dependency arrays of the other callbacks in the same area (~lines
333-342) that invoke it so they always capture the latest togglePreviewPopUp
reference.

packages/webui/src/client/ui/SegmentTimeline/TimelineGrid.tsx (1)

444-452: ⚠️ Potential issue | 🟡 Minor

Cancel contextResize throttling during unmount

contextResize is a _.throttle that can execute a trailing call after componentWillUnmount, invoking repaint() / props.onResize(). Add this.contextResize.cancel() (same .cancel() pattern already used for other _.throttle handlers in this repo).

Suggested fix

 componentWillUnmount(): void {
 	if (typeof this.scheduledRepaint === 'number') {
 		window.cancelAnimationFrame(this.scheduledRepaint)
 		this.scheduledRepaint = null
 	}
+	this.contextResize.cancel()
 	if (this._resizeObserver) this._resizeObserver.disconnect()
 	window.removeEventListener(RundownTiming.Events.timeupdateLowResolution, this.onTimeupdate)
 	window.removeEventListener(RundownTiming.Events.timeupdateHighResolution, this.onTimeupdate)
 }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/webui/src/client/ui/SegmentTimeline/TimelineGrid.tsx` around lines
444 - 452, componentWillUnmount must cancel the _.throttle stored on
this.contextResize to prevent its trailing invocation after unmount (which can
call repaint() / props.onResize()); update componentWillUnmount to call
this.contextResize.cancel() (following the same pattern used for other throttled
handlers) before unsetting observers/listeners so any queued trailing call is
cleared.