fix: bug when reading an empty "__removePackages.json" file

Author: nytamin

shared/packages/worker/src/worker/accessorHandlers/lib/GenericFileOperations.ts

@@ -160,13 +160,13 @@ export class GenericFileOperationsHandler {
 		if (this.fileHandler.getPackagesToRemove) return this.fileHandler.getPackagesToRemove()
 
 		const exists = await this.fileHandler.fileExists(this.deferRemovePackagesPath)
-		if (exists) {
-			const buf = await this.fileHandler.readFile(this.deferRemovePackagesPath)
-			const text = buf.toString('utf8')
-			const packagesToRemove: DelayPackageRemovalEntry[] = JSON.parse(text)
-			if (!Array.isArray(packagesToRemove)) return []
-			return packagesToRemove
-		} else return []
+		if (!exists) return []
+		const buf = await this.fileHandler.readFile(this.deferRemovePackagesPath)
+		const text = buf.toString('utf8')
+		if (text.length === 0) return []
+		const packagesToRemove: DelayPackageRemovalEntry[] = JSON.parse(text)
+		if (!Array.isArray(packagesToRemove)) return []
+		return packagesToRemove
 	}
 	/** Update the deferred-remove-packages list */
 	private async updatePackagesToRemove(

shared/packages/worker/src/worker/accessorHandlers/lib/json-write-file.ts

@@ -359,7 +359,7 @@ export class JSONWriteFilesBestEffortHandler extends JSONWriteHandler {
 		if (oldValue?.str === newValueStr) {
 			// do nothing
 		} else {
-			if (newValueStr === undefined) {
+			if (newValueStr === undefined || newValueStr === '') {
 				// undefined means remove the file
 				await this.fileHandler.unlinkIfExists(tmpFilePath)
 				await this.fileHandler.unlinkIfExists(filePath)