t-wise: Allow to Use Preset Configurations#115
Draft
uulm-janbaudisch wants to merge 1 commit into
Draft
Conversation
uulm-janbaudisch
force-pushed
the
twise-presets
branch
2 times, most recently
from
July 13, 2026 16:20
6af756f to
7d670f6
Compare
uulm-janbaudisch
force-pushed
the
twise-presets
branch
from
July 13, 2026 18:15
7d670f6 to
51dfee5
Compare
Comment on lines
+139
to
+142
| // TODO | ||
| /*if _preset.is_t_wise_covered(self.config, t) { | ||
| return true; | ||
| }*/ |
Collaborator
Author
There was a problem hiding this comment.
Enabling this check for the preset results in a sample without full t-wise coverage.
| .all(|interaction| sample.covers(interaction)) | ||
| TInteractionIter::new(&literals, min(t, literals.len())).all(|interaction| { | ||
| // TODO | ||
| sample.covers(interaction) //|| _preset.covers(interaction) |
Collaborator
Author
There was a problem hiding this comment.
The same holds for this check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables the usage of pre-set configurations for t-wise sampling.