From 2b362a0c8dda03861b771ec092f52506594b9014 Mon Sep 17 00:00:00 2001 From: Oleksandr Kosenko Date: Wed, 23 Apr 2025 23:47:44 -0400 Subject: [PATCH 01/17] Initial version --- .gitmodules | 3 +++ UI/frontend-plugins/CMakeLists.txt | 1 + UI/frontend-plugins/vertical-canvas | 1 + deps/libdshowcapture/src | 2 +- 4 files changed, 6 insertions(+), 1 deletion(-) create mode 160000 UI/frontend-plugins/vertical-canvas diff --git a/.gitmodules b/.gitmodules index 180e3fe06b69a5..2868e3cc93239f 100644 --- a/.gitmodules +++ b/.gitmodules @@ -7,3 +7,6 @@ [submodule "plugins/obs-websocket"] path = plugins/obs-websocket url = https://github.com/obsproject/obs-websocket.git +[submodule "UI/frontend-plugins/vertical-canvas"] + path = UI/frontend-plugins/vertical-canvas + url = https://github.com/SoftwareArchitector/vertical-canvas.git diff --git a/UI/frontend-plugins/CMakeLists.txt b/UI/frontend-plugins/CMakeLists.txt index fdaf40b6325763..06fd7dac6eb07b 100644 --- a/UI/frontend-plugins/CMakeLists.txt +++ b/UI/frontend-plugins/CMakeLists.txt @@ -2,3 +2,4 @@ add_subdirectory(aja-output-ui) add_subdirectory(decklink-captions) add_subdirectory(decklink-output-ui) add_subdirectory(frontend-tools) +add_subdirectory(vertical-canvas) diff --git a/UI/frontend-plugins/vertical-canvas b/UI/frontend-plugins/vertical-canvas new file mode 160000 index 00000000000000..cdb7b4f3e0815d --- /dev/null +++ b/UI/frontend-plugins/vertical-canvas @@ -0,0 +1 @@ +Subproject commit cdb7b4f3e0815da5859823444d06715a4c7af3a1 diff --git a/deps/libdshowcapture/src b/deps/libdshowcapture/src index ef8c1d2e19c93e..88786383243938 160000 --- a/deps/libdshowcapture/src +++ b/deps/libdshowcapture/src @@ -1 +1 @@ -Subproject commit ef8c1d2e19c93e664100dd41e1a0df4f8ad45430 +Subproject commit 8878638324393815512f802640b0d5ce940161f1 From ecd627e72d323c966abceab958b40f8506e058ea Mon Sep 17 00:00:00 2001 From: Oleksandr Kosenko Date: Thu, 24 Apr 2025 00:10:06 -0400 Subject: [PATCH 02/17] Run build --- .github/workflows/pr-pull.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pr-pull.yaml b/.github/workflows/pr-pull.yaml index c44ad9cf890c9f..e56973461c7198 100644 --- a/.github/workflows/pr-pull.yaml +++ b/.github/workflows/pr-pull.yaml @@ -5,7 +5,8 @@ on: pull_request: paths-ignore: - '**.md' - branches: [master] + branches: + - '**' types: [ opened, synchronize, reopened ] permissions: contents: read From d89f9f53691453544e667a3775dd4ab176f53c4c Mon Sep 17 00:00:00 2001 From: Oleksandr Kosenko Date: Thu, 24 Apr 2025 00:14:15 -0400 Subject: [PATCH 03/17] Run build --- .github/workflows/push.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/push.yaml b/.github/workflows/push.yaml index 8614e81ae95003..4ee68bee672e1d 100644 --- a/.github/workflows/push.yaml +++ b/.github/workflows/push.yaml @@ -5,8 +5,7 @@ on: paths-ignore: - '**.md' branches: - - master - - 'release/**' + - '**' tags: - '*' permissions: From 0050afaa576683e367062b10d24f7a0c89ed731b Mon Sep 17 00:00:00 2001 From: Oleksandr Kosenko Date: Thu, 24 Apr 2025 16:44:30 -0400 Subject: [PATCH 04/17] Try to build without version checking --- .github/workflows/build-project.yaml | 158 +-------------------------- cmake/macos/compilerconfig.cmake | 18 +-- 2 files changed, 11 insertions(+), 165 deletions(-) diff --git a/.github/workflows/build-project.yaml b/.github/workflows/build-project.yaml index 166adc9d2d5ad3..a3dcda04b9b0db 100644 --- a/.github/workflows/build-project.yaml +++ b/.github/workflows/build-project.yaml @@ -57,6 +57,7 @@ jobs: done echo "commitHash=${GITHUB_SHA:0:9}" >> $GITHUB_OUTPUT + macos-build: name: macOS ๐Ÿ runs-on: macos-14 @@ -168,164 +169,7 @@ jobs: path: ${{ github.workspace }}/.ccache key: ${{ runner.os }}-ccache-${{ matrix.target }}-${{ needs.check-event.outputs.config }} - ubuntu-build: - name: Ubuntu ๐Ÿง - strategy: - matrix: - os: [ubuntu-24.04] - runs-on: ${{ matrix.os }} - needs: check-event - defaults: - run: - shell: bash - steps: - - uses: actions/checkout@v4 - with: - submodules: recursive - fetch-depth: 0 - - - uses: actions/cache/restore@v4 - id: ccache-cache - with: - path: ${{ github.workspace }}/.ccache - key: ${{ runner.os }}-${{ matrix.os }}-ccache-x86_64-${{ needs.check-event.outputs.config }} - restore-keys: | - ${{ runner.os }}-${{ matrix.os }}-ccache-x86_64- - - - name: Build OBS Studio ๐Ÿงฑ - uses: ./.github/actions/build-obs - env: - TWITCH_CLIENTID: ${{ secrets.TWITCH_CLIENT_ID }} - TWITCH_HASH: ${{ secrets.TWITCH_HASH }} - RESTREAM_CLIENTID: ${{ secrets.RESTREAM_CLIENTID }} - RESTREAM_HASH: ${{ secrets.RESTREAM_HASH }} - YOUTUBE_CLIENTID: ${{ secrets.YOUTUBE_CLIENTID }} - YOUTUBE_CLIENTID_HASH: ${{ secrets.YOUTUBE_CLIENTID_HASH }} - YOUTUBE_SECRET: ${{ secrets.YOUTUBE_SECRET }} - YOUTUBE_SECRET_HASH: ${{ secrets.YOUTUBE_SECRET_HASH }} - with: - target: x86_64 - config: ${{ needs.check-event.outputs.config }} - - - name: Package OBS Studio ๐Ÿ“€ - uses: ./.github/actions/package-obs - with: - target: x86_64 - config: ${{ needs.check-event.outputs.config }} - package: ${{ fromJSON(needs.check-event.outputs.package) }} - - - name: Upload Source Tarball ๐Ÿ—œ๏ธ - uses: actions/upload-artifact@v4 - with: - name: obs-studio-${{ matrix.os }}-sources-${{ needs.check-event.outputs.commitHash }} - path: ${{ github.workspace }}/build_ubuntu/obs-studio-*-sources.* - - - name: Upload Artifacts ๐Ÿ“ก - uses: actions/upload-artifact@v4 - with: - name: obs-studio-${{ matrix.os }}-x86_64-${{ needs.check-event.outputs.commitHash }} - path: ${{ github.workspace }}/build_ubuntu/obs-studio-*-x86_64-ubuntu-gnu.* - - name: Upload Debug Symbol Artifacts ๐Ÿชฒ - uses: actions/upload-artifact@v4 - if: ${{ fromJSON(needs.check-event.outputs.package) }} - with: - name: obs-studio-${{ matrix.os }}-x86_64-${{ needs.check-event.outputs.commitHash }}-dbgsym - path: ${{ github.workspace }}/build_ubuntu/obs-studio-*-x86_64-ubuntu-gnu-dbgsym.ddeb - - - uses: actions/cache/save@v4 - if: github.event_name != 'pull_request' && steps.ccache-cache.outputs.cache-hit != 'true' - with: - path: ${{ github.workspace }}/.ccache - key: ${{ runner.os }}-${{ matrix.os }}-ccache-x86_64-${{ needs.check-event.outputs.config }} - - flatpak-build: - name: Flatpak ๐Ÿ“ฆ - runs-on: ubuntu-24.04 - needs: check-event - defaults: - run: - shell: bash - env: - FLATPAK_BUILD_SHARE_PATH: flatpak_app/files/share - container: - image: ghcr.io/flathub-infra/flatpak-github-actions:kde-6.6 - options: --privileged - steps: - - uses: actions/checkout@v4 - with: - submodules: recursive - fetch-depth: 0 - set-safe-directory: ${{ env.GITHUB_WORKSPACE }} - - - name: Set Up Environment ๐Ÿ”ง - id: setup - env: - GH_TOKEN: ${{ github.token }} - run: | - : Set Up Environment ๐Ÿ”ง - if [[ "${RUNNER_DEBUG}" ]]; then set -x; fi - - git config --global --add safe.directory "${GITHUB_WORKSPACE}" - - echo '::group::Install actions/gh-actions-cache' - gh extension install actions/gh-actions-cache - echo '::endgroup::' - - cache_key='flatpak-builder-${{ hashFiles('build-aux/**/*.json') }}' - cache_ref='master' - read -r key size unit _ ref _ <<< \ - "$(gh actions-cache list -B ${cache_ref} --key "${cache_key}-x86_64" | head -1)" - - if [[ "${key}" ]]; then - echo "cacheHit=true" >> $GITHUB_OUTPUT - else - echo "cacheHit=false" >> $GITHUB_OUTPUT - fi - - echo "cacheKey=${cache_key}" >> $GITHUB_OUTPUT - - - name: Validate Flatpak manifest - uses: ./.github/actions/flatpak-builder-lint - with: - artifact: manifest - path: build-aux/com.obsproject.Studio.json - - - name: Build Flatpak Manifest ๐Ÿงพ - uses: flathub-infra/flatpak-github-actions/flatpak-builder@e5fa5a8fe51d76f770ad9d240e4ad5898b1c6a53 - with: - build-bundle: ${{ fromJSON(needs.check-event.outputs.package) }} - bundle: obs-studio-flatpak-${{ needs.check-event.outputs.commitHash }}.flatpak - manifest-path: ${{ github.workspace }}/build-aux/com.obsproject.Studio.json - cache: ${{ fromJSON(steps.setup.outputs.cacheHit) || (github.event_name == 'push' && github.ref_name == 'master')}} - restore-cache: ${{ fromJSON(steps.setup.outputs.cacheHit) }} - cache-key: ${{ steps.setup.outputs.cacheKey }} - mirror-screenshots-url: https://dl.flathub.org/media - - - name: Validate AppStream - uses: ./.github/actions/flatpak-builder-lint - with: - artifact: appstream - path: ${{ env.FLATPAK_BUILD_SHARE_PATH }}/metainfo/com.obsproject.Studio.metainfo.xml - - - name: Verify Icon and Metadata in app-info - working-directory: ${{ env.FLATPAK_BUILD_SHARE_PATH }} - run: | - : Verify Icon and Metadata in app-info - test -f app-info/icons/flatpak/128x128/com.obsproject.Studio.png || { echo "::error::Missing 128x128 icon in app-info"; exit 1; } - test -f app-info/xmls/com.obsproject.Studio.xml.gz || { echo "::error::Missing com.obsproject.Studio.xml.gz in app-info"; exit 1; } - - - name: Validate build directory - uses: ./.github/actions/flatpak-builder-lint - with: - artifact: builddir - path: flatpak_app - - - name: Validate repository - uses: ./.github/actions/flatpak-builder-lint - with: - artifact: repo - path: repo windows-build: name: Windows ๐ŸชŸ diff --git a/cmake/macos/compilerconfig.cmake b/cmake/macos/compilerconfig.cmake index 584b5a05a0e890..553dd6d4346028 100644 --- a/cmake/macos/compilerconfig.cmake +++ b/cmake/macos/compilerconfig.cmake @@ -23,17 +23,19 @@ set_property(CACHE CMAKE_OSX_ARCHITECTURES PROPERTY STRINGS arm64 x86_64) # Ensure recent enough Xcode and platform SDK set(_obs_macos_minimum_sdk 14.2) # Keep in sync with Xcode set(_obs_macos_minimum_xcode 15.1) # Keep in sync with SDK -message(DEBUG "macOS SDK Path: ${CMAKE_OSX_SYSROOT}") +message(STATUS "macOS SDK Path: ${CMAKE_OSX_SYSROOT}") string(REGEX MATCH ".+/MacOSX.platform/Developer/SDKs/MacOSX([0-9]+\\.[0-9])+\\.sdk$" _ ${CMAKE_OSX_SYSROOT}) set(_obs_macos_current_sdk ${CMAKE_MATCH_1}) message(DEBUG "macOS SDK version: ${_obs_macos_current_sdk}") -if(_obs_macos_current_sdk VERSION_LESS _obs_macos_minimum_sdk) - message( - FATAL_ERROR - "Your macOS SDK version (${_obs_macos_current_sdk}) is too low. " - "The macOS ${_obs_macos_minimum_sdk} SDK (Xcode ${_obs_macos_minimum_xcode}) is required to build OBS." - ) -endif() + +#if(_obs_macos_current_sdk VERSION_LESS _obs_macos_minimum_sdk) +# message( +# FATAL_ERROR +# "Your macOS SDK version (${_obs_macos_current_sdk}) is too low. " +# "The macOS ${_obs_macos_minimum_sdk} SDK (Xcode ${_obs_macos_minimum_xcode}) is required to build OBS." +# ) +#endif() + unset(_obs_macos_current_sdk) unset(_obs_macos_minimum_sdk) unset(_obs_macos_minimum_xcode) From a0451b2dbdd7e1750212970e1410f9f83aa62cf4 Mon Sep 17 00:00:00 2001 From: Oleksandr Kosenko Date: Thu, 24 Apr 2025 16:47:57 -0400 Subject: [PATCH 05/17] Try build --- cmake/macos/compilerconfig.cmake | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/cmake/macos/compilerconfig.cmake b/cmake/macos/compilerconfig.cmake index 553dd6d4346028..4cf49a59c3aa62 100644 --- a/cmake/macos/compilerconfig.cmake +++ b/cmake/macos/compilerconfig.cmake @@ -24,9 +24,10 @@ set_property(CACHE CMAKE_OSX_ARCHITECTURES PROPERTY STRINGS arm64 x86_64) set(_obs_macos_minimum_sdk 14.2) # Keep in sync with Xcode set(_obs_macos_minimum_xcode 15.1) # Keep in sync with SDK message(STATUS "macOS SDK Path: ${CMAKE_OSX_SYSROOT}") -string(REGEX MATCH ".+/MacOSX.platform/Developer/SDKs/MacOSX([0-9]+\\.[0-9])+\\.sdk$" _ ${CMAKE_OSX_SYSROOT}) -set(_obs_macos_current_sdk ${CMAKE_MATCH_1}) -message(DEBUG "macOS SDK version: ${_obs_macos_current_sdk}") + +#string(REGEX MATCH ".+/MacOSX.platform/Developer/SDKs/MacOSX([0-9]+\\.[0-9])+\\.sdk$" _ ${CMAKE_OSX_SYSROOT}) +#set(_obs_macos_current_sdk ${CMAKE_MATCH_1}) +#message(DEBUG "macOS SDK version: ${_obs_macos_current_sdk}") #if(_obs_macos_current_sdk VERSION_LESS _obs_macos_minimum_sdk) # message( From 6f0372c4bcfcd5d4088aee14b4e563baded2d7f7 Mon Sep 17 00:00:00 2001 From: Oleksandr Kosenko Date: Thu, 24 Apr 2025 19:00:47 -0400 Subject: [PATCH 06/17] Update vertical canvas --- UI/frontend-plugins/vertical-canvas | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UI/frontend-plugins/vertical-canvas b/UI/frontend-plugins/vertical-canvas index cdb7b4f3e0815d..be80216182812e 160000 --- a/UI/frontend-plugins/vertical-canvas +++ b/UI/frontend-plugins/vertical-canvas @@ -1 +1 @@ -Subproject commit cdb7b4f3e0815da5859823444d06715a4c7af3a1 +Subproject commit be80216182812e956ead9c123bf6d0a856b39375 From 7183745c66f6c361cdf96708eef30dbf99f289bb Mon Sep 17 00:00:00 2001 From: Oleksandr Kosenko Date: Thu, 24 Apr 2025 20:05:09 -0400 Subject: [PATCH 07/17] Add log --- UI/frontend-plugins/vertical-canvas | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UI/frontend-plugins/vertical-canvas b/UI/frontend-plugins/vertical-canvas index be80216182812e..e961f39179743d 160000 --- a/UI/frontend-plugins/vertical-canvas +++ b/UI/frontend-plugins/vertical-canvas @@ -1 +1 @@ -Subproject commit be80216182812e956ead9c123bf6d0a856b39375 +Subproject commit e961f39179743de4b386a5c0c6ca3edeb74f4687 From 71d277c80c40b55bf68e01cae765d97edbd9f2cf Mon Sep 17 00:00:00 2001 From: Oleksandr Kosenko Date: Thu, 24 Apr 2025 21:48:42 -0400 Subject: [PATCH 08/17] Add log --- UI/frontend-plugins/vertical-canvas | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UI/frontend-plugins/vertical-canvas b/UI/frontend-plugins/vertical-canvas index e961f39179743d..70957fe674729a 160000 --- a/UI/frontend-plugins/vertical-canvas +++ b/UI/frontend-plugins/vertical-canvas @@ -1 +1 @@ -Subproject commit e961f39179743de4b386a5c0c6ca3edeb74f4687 +Subproject commit 70957fe674729a49eaa2c4665a159235fc74805d From 92e1909078ace205d688cd737b69952491e90345 Mon Sep 17 00:00:00 2001 From: Oleksandr Kosenko Date: Thu, 15 May 2025 18:34:46 -0400 Subject: [PATCH 09/17] Use staging-london-4.restream.io instead of live.restream.io for vertical canvas testing --- UI/frontend-plugins/vertical-canvas | 2 +- plugins/rtmp-services/rtmp-common.c | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/UI/frontend-plugins/vertical-canvas b/UI/frontend-plugins/vertical-canvas index 70957fe674729a..273ef2a7be3c1b 160000 --- a/UI/frontend-plugins/vertical-canvas +++ b/UI/frontend-plugins/vertical-canvas @@ -1 +1 @@ -Subproject commit 70957fe674729a49eaa2c4665a159235fc74805d +Subproject commit 273ef2a7be3c1b29402af7095cd8c724bbe9a7bc diff --git a/plugins/rtmp-services/rtmp-common.c b/plugins/rtmp-services/rtmp-common.c index 980103da12ca09..4f80c8da9cb8ac 100644 --- a/plugins/rtmp-services/rtmp-common.c +++ b/plugins/rtmp-services/rtmp-common.c @@ -151,6 +151,9 @@ static void rtmp_common_update(void *data, obs_data_t *settings) service->service = bstrdup(obs_data_get_string(settings, "service")); service->protocol = bstrdup(obs_data_get_string(settings, "protocol")); service->server = bstrdup(obs_data_get_string(settings, "server")); + if (!strcmp(service->server, "rtmp://live.restream.io/live")) + service->server = bstrdup("rtmp://staging-london-4.restream.io/live"); + service->key = bstrdup(obs_data_get_string(settings, "key")); service->supports_additional_audio_track = false; service->video_codecs = NULL; From 06ee19ff6a5bafaacab0eeed035c38e0f433fb99 Mon Sep 17 00:00:00 2001 From: Oleksandr Kosenko Date: Wed, 21 May 2025 12:25:26 -0400 Subject: [PATCH 10/17] Submodule update --- UI/frontend-plugins/vertical-canvas | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UI/frontend-plugins/vertical-canvas b/UI/frontend-plugins/vertical-canvas index 273ef2a7be3c1b..1a762b5562d0a9 160000 --- a/UI/frontend-plugins/vertical-canvas +++ b/UI/frontend-plugins/vertical-canvas @@ -1 +1 @@ -Subproject commit 273ef2a7be3c1b29402af7095cd8c724bbe9a7bc +Subproject commit 1a762b5562d0a942ae25f264951f5ec6fa470602 From 1763f1f7f689eaa55becd1cb29d458ead342b427 Mon Sep 17 00:00:00 2001 From: Oleksandr Kosenko Date: Wed, 21 May 2025 12:36:04 -0400 Subject: [PATCH 11/17] Update submodule --- UI/frontend-plugins/vertical-canvas | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UI/frontend-plugins/vertical-canvas b/UI/frontend-plugins/vertical-canvas index 1a762b5562d0a9..35ad655745ff88 160000 --- a/UI/frontend-plugins/vertical-canvas +++ b/UI/frontend-plugins/vertical-canvas @@ -1 +1 @@ -Subproject commit 1a762b5562d0a942ae25f264951f5ec6fa470602 +Subproject commit 35ad655745ff88df8823d0d894a8c74862479d13 From 3d5c2dda655e1997030742f1d16a0ea1c0aeee7d Mon Sep 17 00:00:00 2001 From: Oleksandr Kosenko Date: Wed, 21 May 2025 12:41:15 -0400 Subject: [PATCH 12/17] Submodule update --- UI/frontend-plugins/vertical-canvas | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UI/frontend-plugins/vertical-canvas b/UI/frontend-plugins/vertical-canvas index 35ad655745ff88..f855689b07cd78 160000 --- a/UI/frontend-plugins/vertical-canvas +++ b/UI/frontend-plugins/vertical-canvas @@ -1 +1 @@ -Subproject commit 35ad655745ff88df8823d0d894a8c74862479d13 +Subproject commit f855689b07cd78e7a24d8dbdcb49bebf8ef64f43 From 7e6b511add66106500396a4f1359d11e2f3528fb Mon Sep 17 00:00:00 2001 From: Oleksandr Kosenko Date: Wed, 21 May 2025 13:08:25 -0400 Subject: [PATCH 13/17] Update submodule --- UI/frontend-plugins/vertical-canvas | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UI/frontend-plugins/vertical-canvas b/UI/frontend-plugins/vertical-canvas index f855689b07cd78..6e0c674f2ca7d4 160000 --- a/UI/frontend-plugins/vertical-canvas +++ b/UI/frontend-plugins/vertical-canvas @@ -1 +1 @@ -Subproject commit f855689b07cd78e7a24d8dbdcb49bebf8ef64f43 +Subproject commit 6e0c674f2ca7d436497d84196835c13ffedefedf From 8c1b48978c0a3c7ce675d563bc5ac77dd4692ed9 Mon Sep 17 00:00:00 2001 From: Oleksandr Kosenko Date: Thu, 5 Jun 2025 15:35:40 -0400 Subject: [PATCH 14/17] Update vertical plugin --- UI/frontend-plugins/vertical-canvas | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UI/frontend-plugins/vertical-canvas b/UI/frontend-plugins/vertical-canvas index 6e0c674f2ca7d4..bbaba1a3165d89 160000 --- a/UI/frontend-plugins/vertical-canvas +++ b/UI/frontend-plugins/vertical-canvas @@ -1 +1 @@ -Subproject commit 6e0c674f2ca7d436497d84196835c13ffedefedf +Subproject commit bbaba1a3165d8967ccbacf461206cb9a6a2363e3 From c33b6d5c9b5837eadd17c0ab7fca11ebc55a4548 Mon Sep 17 00:00:00 2001 From: Oleksandr Kosenko Date: Mon, 9 Jun 2025 00:56:18 -0400 Subject: [PATCH 15/17] Update PRODUCT_BUNDLE_IDENTIFIER --- cmake/macos/helpers.cmake | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cmake/macos/helpers.cmake b/cmake/macos/helpers.cmake index eb2b96d7537920..bfaa205161fb2b 100644 --- a/cmake/macos/helpers.cmake +++ b/cmake/macos/helpers.cmake @@ -43,7 +43,7 @@ function(set_target_properties_obs target) set_target_properties( ${target} PROPERTIES - OUTPUT_NAME OBS + OUTPUT_NAME ObsVertical MACOSX_BUNDLE TRUE MACOSX_BUNDLE_INFO_PLIST "${CMAKE_CURRENT_SOURCE_DIR}/cmake/macos/Info.plist.in" XCODE_EMBED_FRAMEWORKS_REMOVE_HEADERS_ON_COPY YES @@ -54,8 +54,8 @@ function(set_target_properties_obs target) set_target_xcode_properties( ${target} - PROPERTIES PRODUCT_BUNDLE_IDENTIFIER com.obsproject.obs-studio - PRODUCT_NAME OBS + PROPERTIES PRODUCT_BUNDLE_IDENTIFIER io.restream.home + PRODUCT_NAME ObsVertical ASSETCATALOG_COMPILER_APPICON_NAME AppIcon CURRENT_PROJECT_VERSION ${OBS_BUILD_NUMBER} MARKETING_VERSION ${OBS_VERSION_CANONICAL} From 24e1114896ed22e7e790787c253000d096cc5bd7 Mon Sep 17 00:00:00 2001 From: Oleksandr Kosenko Date: Mon, 9 Jun 2025 01:10:40 -0400 Subject: [PATCH 16/17] Update PRODUCT_BUNDLE_IDENTIFIER --- cmake/macos/helpers.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmake/macos/helpers.cmake b/cmake/macos/helpers.cmake index bfaa205161fb2b..e4386d90f8c2eb 100644 --- a/cmake/macos/helpers.cmake +++ b/cmake/macos/helpers.cmake @@ -54,7 +54,7 @@ function(set_target_properties_obs target) set_target_xcode_properties( ${target} - PROPERTIES PRODUCT_BUNDLE_IDENTIFIER io.restream.home + PROPERTIES PRODUCT_BUNDLE_IDENTIFIER io.restream.obsvertical PRODUCT_NAME ObsVertical ASSETCATALOG_COMPILER_APPICON_NAME AppIcon CURRENT_PROJECT_VERSION ${OBS_BUILD_NUMBER} From 64c2dc6dba6dfe51fe6a1cb4a285ac0738d19d3b Mon Sep 17 00:00:00 2001 From: Oleksandr Kosenko Date: Mon, 9 Jun 2025 01:22:00 -0400 Subject: [PATCH 17/17] Update helpers.cmake --- cmake/macos/helpers.cmake | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmake/macos/helpers.cmake b/cmake/macos/helpers.cmake index e4386d90f8c2eb..dede3634992951 100644 --- a/cmake/macos/helpers.cmake +++ b/cmake/macos/helpers.cmake @@ -43,7 +43,7 @@ function(set_target_properties_obs target) set_target_properties( ${target} PROPERTIES - OUTPUT_NAME ObsVertical + OUTPUT_NAME OBS MACOSX_BUNDLE TRUE MACOSX_BUNDLE_INFO_PLIST "${CMAKE_CURRENT_SOURCE_DIR}/cmake/macos/Info.plist.in" XCODE_EMBED_FRAMEWORKS_REMOVE_HEADERS_ON_COPY YES @@ -55,7 +55,7 @@ function(set_target_properties_obs target) set_target_xcode_properties( ${target} PROPERTIES PRODUCT_BUNDLE_IDENTIFIER io.restream.obsvertical - PRODUCT_NAME ObsVertical + PRODUCT_NAME OBS ASSETCATALOG_COMPILER_APPICON_NAME AppIcon CURRENT_PROJECT_VERSION ${OBS_BUILD_NUMBER} MARKETING_VERSION ${OBS_VERSION_CANONICAL}