feat: update embed from hw.glich.co to scaleengineer.com#57
Merged
Sohan-Rout merged 1 commit intoJul 5, 2026
Merged
Conversation
|
@RohitLakh is attempting to deploy a commit to the Ecma Projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hw.glich.coembed URLs with the canonicalscaleengineer.com/embed/daily/dsaURLDailyDSAEmbedcomponent to only acceptmobileandthemeprops, hardcoding the Scale Engineer URL internallymountedstate handling inside the component so consumers no longer need to manage itsrc,mounted,desktopHeight,mobileHeight,linkHref,linkText,linkClassName,linkStyle)Changes
app/components/ui/DailyDSAEmbed.jsx— Simplified API to{ mobile, theme }. Component is now"use client", manages its own mount state, and builds the iframesrcfrom thethemeprop.<DailyDSAEmbed mounted={mounted} src={...} desktopHeight={400} ... />calls with<DailyDSAEmbed mobile={false} theme={theme} />(desktop) and<DailyDSAEmbed mobile theme={theme} />(mobile). Removed unusedmountedstate from each file.Result
hw.glich.coscaleengineer.comwith proper dark/light theme support