Skip to content

feat: First version of the sam-powerBI query tool plugin.#159

Merged
peetkes merged 8 commits into
mainfrom
peetkes/sam-powerbi
Apr 28, 2026
Merged

feat: First version of the sam-powerBI query tool plugin.#159
peetkes merged 8 commits into
mainfrom
peetkes/sam-powerbi

Conversation

@peetkes

@peetkes peetkes commented Apr 24, 2026

Copy link
Copy Markdown
Collaborator

This tool connects over rest with a powerBI instance and uses authentication

What is the purpose of this change?

Generic tool to connect to powerBI

How was this change implemented?

Added extra plugin for PowerBI

Key Design Decisions (optional - delete if not applicable)

Why did you choose this approach over alternatives?

How was this change tested?

  • Manual testing: [describe scenarios]
  • Unit tests: [new/modified tests]
  • Integration tests: [if applicable]
  • Known limitations: [what wasn't tested]

Is there anything the reviewers should focus on/be aware of?

Special attention areas, potential risks, or open questions

@peetkes peetkes requested a review from cyrus2281 April 24, 2026 07:56
@peetkes peetkes self-assigned this Apr 24, 2026
@peetkes peetkes removed their assignment Apr 24, 2026

@cyrus2281 cyrus2281 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires Unit tests
Plus adjustments in pyproject.yaml

Comment thread sam-powerbi/tests/test_placeholder.py Outdated
Comment thread sam-powerbi/pyproject.toml
Comment thread sam-powerbi/pyproject.toml Outdated

@cyrus2281 cyrus2281 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peetkes peetkes enabled auto-merge (squash) April 28, 2026 07:00
@peetkes peetkes changed the title First version of the sam-powerBI query tool plugin. feat(sam-powerbi) First version of the sam-powerBI query tool plugin. Apr 28, 2026
@peetkes peetkes changed the title feat(sam-powerbi) First version of the sam-powerBI query tool plugin. feat(sam-powerbi): First version of the sam-powerBI query tool plugin. Apr 28, 2026
@peetkes peetkes self-assigned this Apr 28, 2026
@cyrus2281 cyrus2281 changed the title feat(sam-powerbi): First version of the sam-powerBI query tool plugin. feat: First version of the sam-powerBI query tool plugin. Apr 28, 2026
@sonarqube-solacecloud

Copy link
Copy Markdown

@sonarqube-solacecloud

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@github-actions

Copy link
Copy Markdown

✅ SonarQube Quality Gate - All Passed

Project Quality Gate Status Analysis
sam-event-mesh-identity-provider ✅ Passed See analysis details on SonarQube
sam-powerbi ✅ Passed See analysis details on SonarQube
sam-sql-database-tool ✅ Passed See analysis details on SonarQube

Quality gate checks run for each changed project.

@github-actions

Copy link
Copy Markdown

✅ FOSSA Guard (PR Diff) - No New Issues Introduced

Diff mode compares PR head against base revision and reports only newly introduced issues.

Check Scope Status
FOSSA Vulnerabilities Per-Project (PR Diff) ✅ Passed
License Check Per-Project (PR Diff) ✅ Passed

Projects With New Issues

  • None
Project FOSSA Vulnerabilities License Check FOSSA Report
sam-event-mesh-identity-provider ✅ Passed ✅ Passed View report
sam-powerbi ✅ Passed ✅ Passed View report
sam-sql-database-tool ✅ Passed ✅ Passed View report

Only newly introduced issues are shown in this report.

@peetkes peetkes merged commit 9fd163a into main Apr 28, 2026
17 of 22 checks passed
@peetkes peetkes deleted the peetkes/sam-powerbi branch April 28, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants