fixed sdk user agent version (#33)

nik-solcast · web-flow · commit bc8b2628b3cc · 2024-11-14T16:25:58.000+11:00
* fixed sdk user agent version

* fixed version format
diff --git a/docs/index.md b/docs/index.md
@@ -23,7 +23,7 @@ var liveClient = new LiveClient();
 var response = await liveClient.GetRadiationAndWeather(
     latitude: -33.856784,
     longitude: 151.215297,
-    output_parameteres: ["air_temp", "dni", "ghi" ]
+    outputParameteres: ["air_temp", "dni", "ghi" ]
 );
 ```
 
diff --git a/generate_sdk_csharp.py b/generate_sdk_csharp.py
@@ -171,7 +171,7 @@ def generate_base_client():
 
             // Get the version from the assembly metadata for User-Agent
             var version = GetAssemblyVersion();
-            _httpClient.DefaultRequestHeaders.UserAgent.ParseAdd($"solcast-api-csharp/{version}");
+            _httpClient.DefaultRequestHeaders.UserAgent.ParseAdd($"solcast-api-csharp-sdk/{version}");
         }
 
         private static string GetAssemblyVersion()
@@ -181,7 +181,8 @@ def generate_base_client():
                 typeof(AssemblyInformationalVersionAttribute)
             );
 
-            return attribute?.InformationalVersion ?? "1.0.0";
+            var version = attribute?.InformationalVersion ?? "1.0.0";
+            return version.Split('+')[0];
         }
     }
 }
diff --git a/src/Solcast/Clients/BaseClient.cs b/src/Solcast/Clients/BaseClient.cs
@@ -19,7 +19,7 @@ protected BaseClient()
 
             // Get the version from the assembly metadata for User-Agent
             var version = GetAssemblyVersion();
-            _httpClient.DefaultRequestHeaders.UserAgent.ParseAdd($"solcast-api-csharp/{version}");
+            _httpClient.DefaultRequestHeaders.UserAgent.ParseAdd($"solcast-api-csharp-sdk/{version}");
         }
 
         private static string GetAssemblyVersion()

Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,7 @@ def generate_base_client():`
`171`	`171`
`172`	`172`	`// Get the version from the assembly metadata for User-Agent`
`173`	`173`	`var version = GetAssemblyVersion();`
`174`		`- _httpClient.DefaultRequestHeaders.UserAgent.ParseAdd($"solcast-api-csharp/{version}");`
	`174`	`+ _httpClient.DefaultRequestHeaders.UserAgent.ParseAdd($"solcast-api-csharp-sdk/{version}");`
`175`	`175`	`}`
`176`	`176`
`177`	`177`	`private static string GetAssemblyVersion()`
`@@ -181,7 +181,8 @@ def generate_base_client():`
`181`	`181`	`typeof(AssemblyInformationalVersionAttribute)`
`182`	`182`	`);`
`183`	`183`
`184`		`- return attribute?.InformationalVersion ?? "1.0.0";`
	`184`	`+ var version = attribute?.InformationalVersion ?? "1.0.0";`
	`185`	`+ return version.Split('+')[0];`
`185`	`186`	`}`
`186`	`187`	`}`
`187`	`188`	`}`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ protected BaseClient()`
`19`	`19`
`20`	`20`	`// Get the version from the assembly metadata for User-Agent`
`21`	`21`	`var version = GetAssemblyVersion();`
`22`		`- _httpClient.DefaultRequestHeaders.UserAgent.ParseAdd($"solcast-api-csharp/{version}");`
	`22`	`+ _httpClient.DefaultRequestHeaders.UserAgent.ParseAdd($"solcast-api-csharp-sdk/{version}");`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`private static string GetAssemblyVersion()`