new outine structure, ts ignores

Author: timea-solid

README.md

@@ -78,3 +78,11 @@ contacts (A VCARD Address Book, Group, Individual, Organization) can be handled
 pane. Any other pane which wants to deal with contacts can just use the pane within its own user interface.
 
 ![Mapping many classes on the L to panes on the R](https://solidos.github.io/solid-panes/doc/images/panes-for-classes.svg)
+
+
+## Generative AI usage
+The SolidOS team is using GitHub Copilot integrated in Visual Studio Code. 
+We have added comments in the code to make it explicit which parts are 100% written by AI. 
+
+### Prompt usage hitory:
+* Model Claude Opus 4.6: Initially solid-panes is loaded into a HTML shell form mashlib that looks like ... Also, an iFrame is rendered inside the <div class="TabulatorOutline" id="DummyUUID"> for “isolated pane rendering”. Analize the solid-panes code for what it uses from this HTML and suggest a new HTML structure which is mobile and accessibility friendly. Lets go ahead and make chnages in this code as suggested to accommodate the new databwroser HTML.

dev/dev-mash.css

@@ -8,81 +8,54 @@
 @import url("./dev-light.css");
 @import url("./dev-mash-utilities.css");
 
-/* I couldn't find the code for the collapse image. this is a quick work around
-to make the collapsing easier to use ( the triangles dont jump 20 pixels). ~cm2
-*/
-img[title="Hide details."] {
-  float: left;
-}
-
-html {
-  height: 100%;
-  line-height: 1.15;
-}
-body {
-  height: 100%;
-  background-color: var(--color-background);
-  color: var(--color-text);
+html, body {
+  margin: 0;
+  padding: 0;
   font-family: var(--font-family-base);
-}
-
-/* Improved heading hierarchy */
-h1, h2, h3, h4, h5, h6 {
-  color: var(--color-primary);
-  font-weight: 600;
-  line-height: var(--line-height-tight);
-  margin-top: 0;
-  margin-bottom: var(--spacing-sm);
-}
-
-h1 { font-size: 2em; }    /* 32px */
-h2 { font-size: 1.5em; }  /* 24px */
-h3 { font-size: 1.25em; } /* 20px */
-h4 { font-size: 1.125em; }/* 18px */
-h5, h6 { font-size: 1em; }/* 16px */
-
-/* Better paragraph spacing */
-p {
-  margin-bottom: var(--spacing-md);
+  font-size: var(--font-size-base);
   line-height: var(--line-height-base);
-  max-width: 65ch; /* Optimal reading width */
-}
-
-/* Improved link accessibility */
-a {
-  color: var(--color-primary);
-  text-decoration: underline;
-  text-underline-offset: 0.125em;
-  text-decoration-thickness: 0.0625em;
-}
-
-a:hover, a:focus {
-  text-decoration-thickness: 0.125em;
+  background: var(--color-background);
+  color: var(--color-text);
+  -webkit-font-smoothing: antialiased;
+  -moz-osx-font-smoothing: grayscale;
+  text-rendering: optimizeLegibility;
 }
 
-
-/* Main page elements in databrowser.html */
-#PageBody {
+/* ── App layout ── */
+body {
   display: flex;
   flex-direction: column;
+  min-height: 100dvh;        /* dvh = dynamic viewport for mobile chrome */
 }
-#DummyUUID {
-  flex: 1 0 auto;
-}
+
 #PageHeader {
+  position: sticky;
+  top: 0;
+  z-index: 100;
   flex-shrink: 0;
 }
+
+#MainContent {
+  flex: 1 1 auto;
+  overflow-y: auto;
+  -webkit-overflow-scrolling: touch;   /* smooth iOS scroll */
+  padding: clamp(0.5rem, 2vw, 1.5rem); /* responsive gutter */
+  container-type: inline-size;          /* enable @container queries */
+}
+
 #PageFooter {
   flex-shrink: 0;
 }
 
+
 .warning {
   color: var(--color-warning);
 }
 .selected {
   background-color: var(--color-selected-bg);
 }
 
+/* used in profile-pane as success button */
 .licOkay {
   background-color: var(--color-success-bg);
 }
@@ -1409,3 +1382,56 @@ End of styles for tableViewPane
   -moz-box-shadow: $x-axis $y-axis $blur $color;
   -o-box-shadow: $x-axis $y-axis $blur $color;
 }
+
+/* Generated by AI */
+@media screen and (max-width: 768px) {
+  #PageHeader,
+  #PageFooter {
+    width: 100%;
+  }
+
+  #MainContent {
+    padding-top: 0.75rem;
+    padding-right: max(0.75rem, env(safe-area-inset-right));
+    padding-bottom: max(0.75rem, env(safe-area-inset-bottom));
+    padding-left: max(0.75rem, env(safe-area-inset-left));
+  }
+
+  .TabulatorOutline,
+  .outline-view {
+    overflow-x: auto;
+    -webkit-overflow-scrolling: touch;
+  }
+
+  .TabulatorOutline table,
+  .outline-view table {
+    min-width: 100%;
+  }
+
+  img.outlineImage,
+  img.pic,
+  img.foafPic {
+    height: auto;
+    max-width: 100%;
+  }
+
+  div.description,
+  div.premises,
+  div.justification,
+  div.mildNotice {
+    box-sizing: border-box;
+    margin-left: 0;
+    margin-right: 0;
+    width: 100%;
+  }
+}
+
+html[data-layout="mobile"] #PageBody {
+  min-height: var(--app-height, 100dvh);
+}
+
+html[data-layout="mobile"] #MainContent {
+  overscroll-behavior-x: contain;
+}
+
+/* END of Generated by AI */

dev/loader.ts

@@ -5,6 +5,7 @@ import { solidLogicSingleton, store, authSession } from 'solid-logic'
 import { getOutliner } from '../src'
 import Pane from 'profile-pane'
 import './dev-mash.css'
+import { DataBrowserContext, RenderEnvironment } from 'pane-registry'
 
 // Add custom properties to the Window interface for TypeScript
 declare global {
@@ -27,15 +28,24 @@ async function renderPane (uri: string) {
   await new Promise((resolve, reject) => {
     store.fetcher.load(doc).then(resolve, reject)
   })
-  const context = {
+
+  const devEnvironment : RenderEnvironment = {
+    layout: 'desktop', // or 'mobile'
+    layoutPreference: 'desktop', // or 'mobile' or 'auto'
+    inputMode: 'pointer', // or 'touch'
+    theme: 'light', // or 'dark'
+    viewport: { width: 800, height: 480 } // this is the default viewport for the browser window
+  }
+  const context : DataBrowserContext = {
     // see https://github.com/solidos/solid-panes/blob/005f90295d83e499fd626bd84aeb3df10135d5c1/src/index.ts#L30-L34
     dom: document,
     getOutliner,
     session: {
       store: store,
       paneRegistry,
       logic: solidLogicSingleton
-    }
+    },
+    environment: devEnvironment
   }
 
   console.log(subject, context)

package-lock.json

@@ -15,6 +15,7 @@ export const basicPreferencesPane: PaneDefinition = {
   // The subject should be the logged in user.
   render: (subject, context) => {
     const dom = context.dom
+    // @ts-ignore
     const store = context.session.store as Store
 
     function complainIfBad (ok: Boolean, mess: any) {

src/dashboard/basicPreferences.ts

@@ -20,6 +20,7 @@ const pane: PaneDefinition = {
 
   render: function (subject, context) {
     const dom = context.dom
+    // @ts-ignore
     const store = context.session.store as Store
     const canonizedSubject = store.canon(subject) as BlankNode | NamedNode | Variable
     const types = store.findTypeURIs(canonizedSubject)

src/internal/internalPane.ts

@@ -14,7 +14,9 @@ export function createContext (
     getOutliner,
     session: {
       paneRegistry,
+      // @ts-ignore
       store,
+      // @ts-ignore
       logic
     }
   }

src/outline/context.ts

@@ -464,10 +464,10 @@ export default function (context) {
   async function showDashboard (options = {}) {
     const dashboardContainer = getDashboardContainer()
     const outlineContainer = getOutlineContainer()
-    // reuse dashboard if already children already is inserted
+    // reuse dashboard if children already inserted
     if (dashboardContainer.childNodes.length > 0 && options.pane) {
-      outlineContainer.style.display = 'none'
-      dashboardContainer.style.display = 'inherit'
+      outlineContainer.setAttribute('hidden', '')
+      dashboardContainer.removeAttribute('hidden')
       const tab = dashboardContainer.querySelector(
         `[data-global-pane-name="${options.pane}"]`
       )
@@ -490,7 +490,8 @@ export default function (context) {
     authSession.events.on('logout', closeDashboard)
 
     // finally - switch to showing dashboard
-    outlineContainer.style.display = 'none'
+    outlineContainer.setAttribute('hidden', '')
+    dashboardContainer.removeAttribute('hidden')
     dashboardContainer.appendChild(dashboard)
     const tab = dashboardContainer.querySelector(
       `[data-global-pane-name="${options.pane}"]`
@@ -500,35 +501,37 @@ export default function (context) {
     }
 
     function closeDashboard () {
-      dashboardContainer.style.display = 'none'
-      outlineContainer.style.display = 'inherit'
+      dashboardContainer.setAttribute('hidden', '')
+      outlineContainer.removeAttribute('hidden')
     }
   }
   this.showDashboard = showDashboard
 
   function getDashboardContainer () {
-    return getOrCreateContainer('GlobalDashboard')
+    return getOrCreateContainer('GlobalDashboard', 'Dashboard')
   }
 
   function getOutlineContainer () {
-    return getOrCreateContainer('outline')
+    return getOrCreateContainer('OutlineView', 'Resource browser')
   }
 
   /**
-   * Get element with id or create a new on the fly with that id
+   * Get element with id or create a new section on the fly with that id
    *
    * @param {string} id The ID of the element you want to get or create
+   * @param {string} [ariaLabel] Optional aria-label for accessibility
    * @returns {HTMLElement}
    */
-  function getOrCreateContainer (id) {
+  function getOrCreateContainer (id, ariaLabel) {
     return (
       document.getElementById(id) ||
       (() => {
-        const dashboardContainer = document.createElement('div')
-        dashboardContainer.id = id
+        const container = document.createElement('section')
+        container.id = id
+        if (ariaLabel) container.setAttribute('aria-label', ariaLabel)
         const mainContainer =
           document.querySelector('[role="main"]') || document.body
-        return mainContainer.appendChild(dashboardContainer)
+        return mainContainer.appendChild(container)
       })()
     )
   }
@@ -581,8 +584,9 @@ export default function (context) {
       const paneHiddenStyle =
         'width: 24px; border-radius: 0.5em; margin-left: 1em; padding: 3px'
       const paneIconTray = td.appendChild(dom.createElement('nav'))
-      paneIconTray.style =
-        'display:flex; justify-content: flex-start; align-items: center;'
+      paneIconTray.setAttribute('role', 'toolbar')
+      paneIconTray.setAttribute('aria-label', 'Pane views')
+      paneIconTray.classList.add('paneIconTray')
 
       const relevantPanes = options.hideList
         ? []
@@ -1577,7 +1581,7 @@ export default function (context) {
             outline.GotoSubject(object, true)
             /* //deal with this later
             deselectAll();
-            var newTr=dom.getElementById('outline').lastChild;
+            var newTr=dom.getElementById('OutlineView').lastChild;
             setSelected(newTr.firstChild.firstChild.childNodes[1].lastChild,true);
             function setSelectedAfterward(uri){
                 deselectAll();
@@ -2242,7 +2246,7 @@ export default function (context) {
   @param table   -- option  -- a table element in which to put the outline.
 */
   this.GotoSubject = function (subject, expand, pane, solo, referrer, table) {
-    table = table || dom.getElementById('outline') // if does not exist just add one? nowhere to out it
+    table = table || dom.getElementById('OutlineView') // if does not exist just add one? nowhere to out it
     if (solo) {
       UI.utils.emptyNode(table)
       table.style.width = '100%'

src/outline/manager.js

@@ -1418,8 +1418,11 @@ export function UserInput (outline) {
         false
       )
       window.addEventListener('mousedown', UserInput.Mousedown, false)
-      document.getElementById('outline').oncontextmenu = function () {
-        return false
+      const outlineView = document.getElementById('OutlineView')
+      if (outlineView) {
+        outlineView.oncontextmenu = function () {
+          return false
+        }
       }
 
       if (e.button === 2) {

src/outline/userInput.js

@@ -16,6 +16,7 @@ const paneDef: PaneDefinition = {
 
   // Does the subject deserve an pad pane?
   label: function (subject, context) {
+    // @ts-ignore
     const t = (context.session.store as Store).findTypeURIs(subject)
     if (t['http://www.w3.org/ns/pim/pad#Notepad']) {
       return 'pad'
@@ -26,6 +27,7 @@ const paneDef: PaneDefinition = {
   mintClass: ns.pad('Notepad'),
 
   mintNew: function (context, newPaneOptions: any) {
+    // @ts-ignore
     const store = context.session.store as Store
     const updater = store.updater
     if (newPaneOptions.me && !newPaneOptions.me.uri) {
@@ -77,6 +79,7 @@ const paneDef: PaneDefinition = {
   // @@ TODO Set better type for paneOptions
   render: function (subject, context, paneOptions: any) {
     const dom = context.dom
+    // @ts-ignore
     const store = context.session.store as Store
     // Utility functions
     const complainIfBad = function (ok: boolean, message: string) {