Skip to content

Commit 6530023

Browse files
author
Tim Berners-Lee
committed
MInor bug fixes. Before expeiment with modular rdflib.js
1 parent af9640b commit 6530023

2 files changed

Lines changed: 13 additions & 9 deletions

File tree

contact/contactPane.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -725,7 +725,7 @@ module.exports = {
725725
books.map(function (book) {
726726
var gs = book ? kb.each(book, ns.vcard('includesGroup')) : []
727727
var gs2 = gs.map(function (g) {return [ book, kb.any(g, ns.vcard('fn')), g] })
728-
groups = groups.concat(groups)
728+
groups = groups.concat(gs2)
729729
})
730730
groups.sort()
731731
}
@@ -1030,7 +1030,7 @@ module.exports = {
10301030
// Render a single contact Individual
10311031

10321032
if (t[ns.vcard('Individual').uri] || t[ns.vcard('Organization').uri]) { // https://timbl.rww.io/Apps/Contactator/individualForm.ttl
1033-
var individualFormDoc = kb.sym(tabulator.iconPrefix + 'js/panes/contact/individualForm.ttl')
1033+
var individualFormDoc = kb.sym( 'https://linkeddata.github.io/solid-app-set/contact/individualForm.ttl')
10341034
// var individualFormDoc = kb.sym('https://timbl.rww.io/Apps/Contactator/individualForm.ttl')
10351035
var individualForm = kb.sym(individualFormDoc.uri + '#form1')
10361036

@@ -1084,11 +1084,11 @@ module.exports = {
10841084
.setAttribute('style', 'height: 1em') // spacer
10851085

10861086
// Remaining properties from whatever ontollogy
1087-
tabulator.outline.appendPropertyTRs(div, plist, false,
1087+
UI.outline.appendPropertyTRs(div, plist, false,
10881088
function (pred, inverse) {
10891089
return !(pred.uri in predicateURIsDone)
10901090
})
1091-
tabulator.outline.appendPropertyTRs(div, qlist, true,
1091+
UI.outline.appendPropertyTRs(div, qlist, true,
10921092
function (pred, inverse) {
10931093
return !(pred.uri in predicateURIsDone)
10941094
})

meeting/meetingPane.js

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -201,9 +201,9 @@ module.exports = {
201201
console.log('Dropped URI list (2): ' + uris)
202202
if (uris) {
203203
uris.map(function (u) {
204-
var target = $rdf.sym(u)
205-
console.log('Dropped on attachemnt ' + u)
206-
var tool = makeToolNode(target, UI.ns.wf('attachment'), UI.utils.label(target), UI.icons.iconBase + 'noun_25830.svg')
204+
var target = $rdf.sym(u) // Attachment needs text label to disinguish I think not icon.
205+
console.log('Dropped on attachemnt ' + u) // icon was: UI.icons.iconBase + 'noun_25830.svg'
206+
var tool = makeToolNode(target, UI.ns.wf('attachment'), UI.utils.label(target), null)
207207
kb.add(tool, UI.ns.meeting('view'), 'iframe', meetingDoc)
208208
saveBackMeetingDoc()
209209
})
@@ -461,6 +461,7 @@ module.exports = {
461461

462462
var renderTabSettings = function(containerDiv, subject){
463463
containerDiv.innerHTML = ''
464+
containerDiv.style += "border-color: #eed;"
464465
containerDiv.appendChild(dom.createElement('h3')).textContent = 'Adjust this tab'
465466
if (kb.holds(subject, ns.rdf('type'), ns.meeting('Tool'))){
466467
var form = $rdf.sym('https://linkeddata.github.io/solid-app-set/meeting/meetingDetailsForm.ttl#settings')
@@ -474,12 +475,15 @@ module.exports = {
474475
break
475476
}
476477
}
477-
var ds = kb.statementsMatching(subject).concat(kb.statementsMatching(undefined, undefined, subject))
478+
var target = kb.any(subject, ns.meeting('target'))
479+
var ds = kb.statementsMatching(subject).
480+
concat(kb.statementsMatching(undefined, undefined, subject)).
481+
concat(kb.statementsMatching(meeting, undefined, target))
478482
kb.remove(ds) // Remove all links to and from the tab node
479483
saveBackMeetingDoc()
480484
})
481485
delButton.setAttribute('class', '')
482-
delButton.setAttribute('style', 'padding: 1em; font-size: 120%; background-color: red; color: white;')
486+
delButton.setAttribute('style', 'margin: 1em; border-radius: 0.5em; padding: 1em; font-size: 120%; background-color: red; color: white;')
483487
delButton.textContent = 'Delete this tab'
484488
containerDiv.appendChild(tipDiv(
485489
'Drag URL-bar icons of web pages into the tab bar on the left to add new meeting materials.'))

0 commit comments

Comments
 (0)