Skip to content

Commit dc3de6f

Browse files
committed
alligned mielstone 2k
1 parent 72c7287 commit dc3de6f

3 files changed

Lines changed: 24 additions & 84 deletions

File tree

src/mainPage/menu.css

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -65,22 +65,6 @@
6565
z-index: 100;
6666
}
6767

68-
html[data-layout='mobile'] .app-nav {
69-
position: fixed;
70-
top: var(--app-header-height, 4.5rem);
71-
left: 0;
72-
bottom: 0;
73-
z-index: 110;
74-
width: min(80vw, 320px);
75-
max-width: min(80vw, 320px);
76-
background: var(--color-background);
77-
border-right: 1px solid var(--color-border);
78-
padding: 0.75rem;
79-
overflow-y: auto;
80-
box-sizing: border-box;
81-
transition: transform 0.25s ease-in-out;
82-
}
83-
8468
.app-nav.mobile-hidden {
8569
transform: translateX(-100%);
8670
transition: transform 0.25s ease-in-out;

src/mainPage/menu.ts

Lines changed: 2 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ type MenuItem = {
1212

1313
const ensureMenuSkeleton = () => {
1414
const root = document.querySelector('[role="main"]') || document.body
15-
const headerHost = document.getElementById('mainSolidUiHeader') || document.querySelector('solid-ui-header') || document.getElementById('PageHeader')
1615

1716
let navMenu = document.getElementById('NavMenu') as HTMLElement | null
1817
if (!navMenu) {
@@ -42,12 +41,6 @@ const ensureMenuSkeleton = () => {
4241
toggle.type = 'button'
4342
toggle.setAttribute('aria-label', 'Toggle navigation menu')
4443
toggle.textContent = '\u2630'
45-
}
46-
47-
toggle.slot = 'navigation-toggle'
48-
if (headerHost && toggle.parentElement !== headerHost) {
49-
headerHost.appendChild(toggle)
50-
} else if (!headerHost && toggle.parentElement !== root) {
5144
root.insertBefore(toggle, root.firstChild)
5245
}
5346

@@ -145,42 +138,6 @@ const renderMenuItems = async (outliner: OutlineManager, container: HTMLElement)
145138
setActiveMenuItem(container, container.dataset.activePaneName)
146139
}
147140

148-
const applyMobileMenuStyles = (navMenu: HTMLElement, isOpen: boolean) => {
149-
navMenu.hidden = false
150-
navMenu.style.position = 'fixed'
151-
navMenu.style.top = 'var(--app-header-height, 4.5rem)'
152-
navMenu.style.left = '0'
153-
navMenu.style.bottom = '0'
154-
navMenu.style.width = 'min(80vw, 320px)'
155-
navMenu.style.maxWidth = 'min(80vw, 320px)'
156-
navMenu.style.zIndex = '110'
157-
navMenu.style.display = 'block'
158-
navMenu.style.visibility = 'visible'
159-
navMenu.style.overflowY = 'auto'
160-
navMenu.style.background = 'var(--color-background)'
161-
navMenu.style.borderRight = '1px solid var(--color-border)'
162-
navMenu.style.boxShadow = '0 0.75rem 2rem rgba(0, 0, 0, 0.2)'
163-
navMenu.style.transform = isOpen ? 'translateX(0)' : 'translateX(-100%)'
164-
}
165-
166-
const clearDesktopMenuStyles = (navMenu: HTMLElement) => {
167-
navMenu.hidden = false
168-
navMenu.style.position = ''
169-
navMenu.style.top = ''
170-
navMenu.style.left = ''
171-
navMenu.style.bottom = ''
172-
navMenu.style.width = ''
173-
navMenu.style.maxWidth = ''
174-
navMenu.style.zIndex = ''
175-
navMenu.style.display = ''
176-
navMenu.style.visibility = ''
177-
navMenu.style.overflowY = ''
178-
navMenu.style.background = ''
179-
navMenu.style.borderRight = ''
180-
navMenu.style.boxShadow = ''
181-
navMenu.style.transform = ''
182-
}
183-
184141
export const refreshMenu = (layout: 'mobile' | 'desktop') => {
185142
const navMenu = document.getElementById('NavMenu') as HTMLElement | null
186143
const toggle = document.getElementById('MenuToggleBtn') as HTMLButtonElement | null
@@ -191,15 +148,15 @@ export const refreshMenu = (layout: 'mobile' | 'desktop') => {
191148
if (layout === 'mobile') {
192149
navMenu.classList.add('mobile-hidden')
193150
navMenu.classList.remove('mobile-visible')
194-
applyMobileMenuStyles(navMenu, false)
195151
toggle.hidden = false
196152
overlay.hidden = true
153+
navMenu.hidden = false
197154
toggle.setAttribute('aria-expanded', 'false')
198155
} else {
199156
navMenu.classList.remove('mobile-hidden', 'mobile-visible')
200-
clearDesktopMenuStyles(navMenu)
201157
toggle.hidden = true
202158
overlay.hidden = true
159+
navMenu.hidden = false
203160
toggle.setAttribute('aria-expanded', 'false')
204161
}
205162
}
@@ -215,7 +172,6 @@ export const createLeftSideMenu = async (outliner: OutlineManager) => {
215172
if (!navMenu || !menuToggle || !menuOverlay) return
216173
navMenu.classList.remove('mobile-visible')
217174
navMenu.classList.add('mobile-hidden')
218-
applyMobileMenuStyles(navMenu, false)
219175
menuToggle.setAttribute('aria-expanded', 'false')
220176
menuOverlay.hidden = true
221177
}
@@ -224,7 +180,6 @@ export const createLeftSideMenu = async (outliner: OutlineManager) => {
224180
if (!navMenu || !menuToggle || !menuOverlay) return
225181
navMenu.classList.remove('mobile-hidden')
226182
navMenu.classList.add('mobile-visible')
227-
applyMobileMenuStyles(navMenu, true)
228183
menuToggle.setAttribute('aria-expanded', 'true')
229184
menuOverlay.hidden = false
230185
}

src/outline/manager.js

Lines changed: 22 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -336,25 +336,20 @@ export default function (context) {
336336
)
337337
}
338338

339-
const widget = UI.tabs.tabWidget({
340-
dom,
341-
subject: me,
342-
items,
343-
renderMain,
344-
renderTab,
345-
ordered: true,
346-
orientation: 0,
347-
backgroundColor: '#eeeeee', // black?
348-
selectedTab: options.selectedTab,
349-
onClose: options.onClose
350-
})
351-
352-
const widgetNav = widget.querySelector('nav')
353-
if (widgetNav) {
354-
widgetNav.style.display = 'none'
355-
}
356-
357-
div.appendChild(widget)
339+
div.appendChild(
340+
UI.tabs.tabWidget({
341+
dom,
342+
subject: me,
343+
items,
344+
renderMain,
345+
renderTab,
346+
ordered: true,
347+
orientation: 0,
348+
backgroundColor: '#eeeeee', // black?
349+
selectedTab: options.selectedTab,
350+
onClose: options.onClose
351+
})
352+
)
358353
return div
359354
}
360355
this.getDashboard = globalAppTabs
@@ -631,7 +626,9 @@ export default function (context) {
631626
paneIconTray.setAttribute('aria-label', 'Pane views')
632627
paneIconTray.classList.add('paneIconTray')
633628

634-
const relevantPanes = await getRelevantPanes(subject, context)
629+
const relevantPanes = options.hideList
630+
? []
631+
: await getRelevantPanes(subject, context)
635632
tr.firstPane = requiredPane || getPane(relevantPanes, subject)
636633
const paneNumber = relevantPanes.indexOf(tr.firstPane)
637634

@@ -805,7 +802,11 @@ export default function (context) {
805802
UI.widgets.makeDraggable(strong, subject)
806803
}
807804

808-
header.appendChild(await renderPaneIconTray(td))
805+
header.appendChild(
806+
await renderPaneIconTray(td, {
807+
hideList: showHeader
808+
})
809+
)
809810

810811
// set DOM methods
811812
tr.firstChild.tabulatorSelect = function () {

0 commit comments

Comments
 (0)