Refactor view params to object

This makes it easier to later add additional params, which I expect
to happen.

Author: Vinnl

scratchpad/pane.ts

@@ -1,9 +1,9 @@
 import { RevampPaneDefinition } from '../types'
 import { isPad, getTitle } from './data'
-import { view as scratchpadView } from './view';
+import { view as scratchpadView } from './view'
 
 export const pane: RevampPaneDefinition = {
   canHandle: (subject, store) => isPad(subject, store),
   label: (subject, store) => getTitle(store, subject),
-  attach: scratchpadView
+  view: scratchpadView
 }

scratchpad/paneWrapper.ts

@@ -37,8 +37,12 @@ const paneWrapper: PaneDefinition = {
 
   render: function (subject, _dom) {
     const container = document.createElement('div')
-    const user = UI.authn.currentUser()
-    pane.attach(container, subject, UI.store, user)
+    pane.view({
+      container: container,
+      subject: subject,
+      store: UI.store,
+      user: UI.authn.currentUser()
+    })
     return container
   }
 }

scratchpad/view.ts

@@ -1,17 +1,12 @@
-import { NamedNode, IndexedFormula } from 'rdflib';
-import { getContents, getSetContentsStatements } from './data';
-
-export function view(
-  container: HTMLElement,
-  subject: NamedNode,
-  store: IndexedFormula,
-  user?: NamedNode
-) {
+import { getContents, getSetContentsStatements } from './data'
+import { ViewParams } from '../types'
+
+export function view ({ container, subject, store, user }: ViewParams) {
   toViewMode()
 
-  function toViewMode() {
+  function toViewMode () {
     const content = getContents(store, subject)
-    container.innerHTML = '';
+    container.innerHTML = ''
 
     const lines = content.split('\n')
     lines.forEach((line) => {
@@ -30,13 +25,13 @@ export function view(
     }
   }
 
-  function toEditMode() {
+  function toEditMode () {
     if (!user) {
       return
     }
 
     const content = getContents(store, subject)
-    container.innerHTML = '<form><textarea></textarea><button type="submit">Save</button></form>';
+    container.innerHTML = '<form><textarea></textarea><button type="submit">Save</button></form>'
 
     const textArea = container.getElementsByTagName('textarea')[0]
     textArea.textContent = content

types.ts

@@ -26,9 +26,16 @@ interface NewPaneOptions {
   refreshTarget: HTMLTableElement;
 }
 
+export interface ViewParams {
+  container: HTMLElement;
+  subject: NamedNode;
+  store: IndexedFormula;
+  user?: NamedNode;
+};
+
 export interface RevampPaneDefinition {
   canHandle: (subject: NamedNode, store: IndexedFormula) => boolean;
-  attach: (container: HTMLElement, subject: NamedNode, store: IndexedFormula, user?: NamedNode) => void;
+  view: (params: ViewParams) => void;
   label: (subject: NamedNode, store: IndexedFormula) => string | null;
 };
 interface NewPaneOptions {