Skip to content

Commit cb7475e

Browse files
committed
Merge branch 'post-milestone3m' of https://github.com/solidos/solid-ui into post-milestone3m
2 parents 42bbfce + 8f01bf0 commit cb7475e

3 files changed

Lines changed: 6 additions & 4 deletions

File tree

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -425,8 +425,8 @@ You are logged in as nameOfLoggedIn user.
425425

426426
* Raptor mini: add a readme to the Footer component with example.
427427

428-
* Claude Sonnet 4.6: Make the dop down as a list under the input field and entlarge the pop up, make it higher, adjustable to fit the drop down. And make the drop down arrow area larger
428+
* Claude Sonnet 4.6: Make the drop down as a list under the input field and enlarge the pop up, make it higher, adjustable to fit the drop down. And make the drop down arrow area larger
429429

430-
* GPT-5.4 Model: can you wire up the keyboard interactions and aria attributes for Select.
430+
* GPT-5.4 Model: can you wire up the keyboard interactions and aria attributes for Select?
431431

432432
* GPT-5.4 Model: Take the code from /Users/sharon/2025Dev/solid-ui/src/media/media-capture.ts and make it a web component. Make it work in forms as well as not. Make it configurable and follow LoginButton.

src/v2/components/forms/combobox/Combobox.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,14 +53,16 @@ export class Combobox extends LitElement {
5353
layout: { type: String, reflect: true },
5454
value: { type: String, reflect: true },
5555
inputValue: { type: String },
56+
options: { type: Array, attribute: false },
5657
_popupOpen: { state: true },
5758
_activeIndex: { state: true }
5859
}
5960

6061
static styles = [
6162
listboxStyles,
6263
css`
63-
:host { // default theme
64+
:host {
65+
/* default theme */
6466
display: inline-block;
6567
position: relative;
6668
box-sizing: border-box;

src/v2/components/forms/select/Select.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export class Select extends LitElement {
5353
listboxStyles,
5454
css`
5555
:host {
56-
// default theme
56+
/* default theme */
5757
display: inline-block;
5858
position: relative;
5959
z-index: var(--select-z-index, 400);

0 commit comments

Comments
 (0)